github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/pull/2154#issuecomment-1691788400 | https://api.github.com/repos/simonw/datasette/issues/2154 | 1691788400 | IC_kwDOBm6k_c5k1qRw | 9599 | 2023-08-24T14:25:56Z | 2023-08-24T14:25:56Z | OWNER | Can be tested with: ```bash pip install https://github.com/simonw/datasette/archive/6d57a8c23043e99b27f7a2afbe58f4d58815fd51.zip ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1865281760 | |
https://github.com/simonw/datasette/pull/2154#issuecomment-1691798722 | https://api.github.com/repos/simonw/datasette/issues/2154 | 1691798722 | IC_kwDOBm6k_c5k1szC | 22429695 | 2023-08-24T14:31:42Z | 2023-08-29T16:15:12Z | NONE | ## [Codecov](https://app.codecov.io/gh/simonw/datasette/pull/2154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report Patch coverage: **`100.00%`** and project coverage change: **`+0.03%`** :tada: > Comparison is base [(`2e28258`)](https://app.codecov.io/gh/simonw/datasette/commit/2e2825869fc2655b5fcadc743f6f9dec7a49bc65?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) 92.82% compared to head [(`3e49fd3`)](https://app.codecov.io/gh/simonw/datasette/pull/2154?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) 92.85%. > Report is 3 commits behind head on main. <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## main #2154 +/- ## ========================================== + Coverage 92.82% 92.85% +0.03% ========================================== Files 40 40 Lines 5948 6008 +60 ========================================== + Hits 5521 5579 +58 - Misses 427 429 +2 ``` | [Files Changed](https://app.codecov.io/gh/simonw/datasette/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage Δ | | |---|---|---| | [datasette/views/special.py](https://app.codecov.io/gh/simonw/datasette/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3ZpZXdzL3NwZWNpYWwucHk=) | `94.06% <ø> (-0.85%)` | :arrow_down: | | [datasette/app.py](https://app.codecov.io/gh/simonw/datasette/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2FwcC5weQ==) | `94.37% <10… | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1865281760 | |
https://github.com/simonw/datasette/pull/2154#issuecomment-1691845306 | https://api.github.com/repos/simonw/datasette/issues/2154 | 1691845306 | IC_kwDOBm6k_c5k14K6 | 9599 | 2023-08-24T14:57:39Z | 2023-08-24T14:57:39Z | OWNER | Notes on manual testing so far - it looks like this might be working! - https://github.com/simonw/datasette/issues/2102#issuecomment-1691824713 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1865281760 | |
https://github.com/simonw/datasette/pull/2154#issuecomment-1696618784 | https://api.github.com/repos/simonw/datasette/issues/2154 | 1696618784 | IC_kwDOBm6k_c5lIFkg | 9599 | 2023-08-29T00:58:34Z | 2023-08-29T00:58:34Z | OWNER | Should this have `implies_can_view=True` too? Probably: https://github.com/simonw/datasette/blob/d64a9896f743f87b673d58859a0ec16685594e79/datasette/default_permissions.py#L20-L22 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1865281760 | |
https://github.com/simonw/datasette/pull/2154#issuecomment-1696642671 | https://api.github.com/repos/simonw/datasette/issues/2154 | 1696642671 | IC_kwDOBm6k_c5lILZv | 9599 | 2023-08-29T01:35:37Z | 2023-08-29T01:35:37Z | OWNER | Reminder that I also need to confirm that `insert-row` works if you have it at the instance level, the database level or the resource level in `_r`. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1865281760 | |
https://github.com/simonw/datasette/pull/2154#issuecomment-1696644066 | https://api.github.com/repos/simonw/datasette/issues/2154 | 1696644066 | IC_kwDOBm6k_c5lILvi | 9599 | 2023-08-29T01:37:47Z | 2023-08-29T03:00:25Z | OWNER | Code for this might be cleaner with a `Restrictions()` class that takes a `"_r"` dictionary to the constructor and can then answer questions like `.any_resource_has_permission("view-table")` - where it can resolve aliases etc as well. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1865281760 | |
https://github.com/simonw/datasette/pull/2154#issuecomment-1697612168 | https://api.github.com/repos/simonw/datasette/issues/2154 | 1697612168 | IC_kwDOBm6k_c5lL4GI | 9599 | 2023-08-29T14:57:54Z | 2023-08-29T14:57:54Z | OWNER | The code to refactor is this: https://github.com/simonw/datasette/blob/d64a9896f743f87b673d58859a0ec16685594e79/datasette/default_permissions.py#L181-L280 I'm going to turn that into a more general `restrictions_allow_action` function. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1865281760 | |
https://github.com/simonw/datasette/pull/2154#issuecomment-1697725150 | https://api.github.com/repos/simonw/datasette/issues/2154 | 1697725150 | IC_kwDOBm6k_c5lMTre | 9599 | 2023-08-29T15:54:12Z | 2023-08-29T15:54:12Z | OWNER | In that last commit I also upgraded `Permission` from a named tuple to a dataclass, and added a `implies_can_view=True` private (not documented) option to it. Last step is to refactor the code to use that new property. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1865281760 |