github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/122#issuecomment-378279612 | https://api.github.com/repos/simonw/datasette/issues/122 | 378279612 | MDEyOklzc3VlQ29tbWVudDM3ODI3OTYxMg== | 9599 | 2018-04-03T14:55:54Z | 2018-04-03T14:55:54Z | OWNER | The new documentation for the `_shape=` parameter is now live at http://datasette.readthedocs.io/en/latest/json_api.html | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
275092453 | |
https://github.com/simonw/datasette/pull/181#issuecomment-378293484 | https://api.github.com/repos/simonw/datasette/issues/181 | 378293484 | MDEyOklzc3VlQ29tbWVudDM3ODI5MzQ4NA== | 9599 | 2018-04-03T15:34:29Z | 2018-04-03T15:34:29Z | OWNER | Here's what this looks like: ![2018-04-03 at 8 32 am](https://user-images.githubusercontent.com/9599/38259345-9e1c75ea-3719-11e8-83c9-2160c6fa079c.png) I need to figure out the right way to handle licensing of bundled software like this - it's MIT licensed which is compatible with Datasette's Apache 2 license, but I feel like bundled licensed software (including codemirror) needs to be recognized in the README or docs somehow. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
289425975 | |
https://github.com/simonw/datasette/pull/181#issuecomment-378293599 | https://api.github.com/repos/simonw/datasette/issues/181 | 378293599 | MDEyOklzc3VlQ29tbWVudDM3ODI5MzU5OQ== | 9599 | 2018-04-03T15:34:50Z | 2018-04-03T15:36:58Z | OWNER | Let's only show the "Format SQL" button if the user has JavaScript enabled. We can do that in this code here: https://github.com/bsmithgall/datasette/blob/4a7151a58d6ab7c8404a91beef7083e8a5807cf8/datasette/templates/_codemirror_foot.html#L14-L21 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
289425975 | |
https://github.com/simonw/datasette/pull/181#issuecomment-378295376 | https://api.github.com/repos/simonw/datasette/issues/181 | 378295376 | MDEyOklzc3VlQ29tbWVudDM3ODI5NTM3Ng== | 9599 | 2018-04-03T15:39:57Z | 2018-04-03T15:39:57Z | OWNER | On the licensing front: it looks like the way Django handles this is to keep the licensing header in the files intact, e.g. https://github.com/django/django/blob/6deaddcca367d0143c815aaa42342021baa3b41e/django/contrib/admin/static/admin/js/vendor/jquery/jquery.js So for this change, adding a comment at the top of `sql-formatter.min.js` which references the MIT license would do the trick. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
289425975 | |
https://github.com/simonw/datasette/pull/181#issuecomment-378297842 | https://api.github.com/repos/simonw/datasette/issues/181 | 378297842 | MDEyOklzc3VlQ29tbWVudDM3ODI5Nzg0Mg== | 1957344 | 2018-04-03T15:47:13Z | 2018-04-03T15:47:13Z | NONE | I can work on that -- would you prefer to inline a `display: hidden` and then have the javascript flip the visibility or include it as css? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
289425975 | |
https://github.com/simonw/datasette/issues/183#issuecomment-378281740 | https://api.github.com/repos/simonw/datasette/issues/183 | 378281740 | MDEyOklzc3VlQ29tbWVudDM3ODI4MTc0MA== | 9599 | 2018-04-03T15:01:43Z | 2018-04-03T15:01:43Z | OWNER | I'm having trouble replicating this bug. In particular, I don't understand what you mean by "these are then rendered in the datasette query box using single quotes" - since canned queries aren't displayed in a textarea. Do you have an example database / metadata.json I can use to investigate this further? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
291639118 |