github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/pull/200#issuecomment-380606998 | https://api.github.com/repos/simonw/datasette/issues/200 | 380606998 | MDEyOklzc3VlQ29tbWVudDM4MDYwNjk5OA== | 9599 | 2018-04-11T21:50:14Z | 2018-04-11T21:50:14Z | OWNER | We should only do this if we're certain the spatialite module has been loaded. I could imagine someone having a `sql_statements_log` table of their own without using spatialite for example. I think the most reliable way to detect spatialite is to run `SELECT AddGeometryColumn(1, 2, 3, 4, 5);` against a `:memory:` database and see if it throws an exception - similar to how we detect FTS. We could add this as a `detect_spatialite()` function in `utils.py` and call it once on startup. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
313494458 | |
https://github.com/simonw/datasette/issues/184#issuecomment-380608340 | https://api.github.com/repos/simonw/datasette/issues/184 | 380608340 | MDEyOklzc3VlQ29tbWVudDM4MDYwODM0MA== | 9599 | 2018-04-11T21:55:41Z | 2018-04-11T21:55:41Z | OWNER | Yuck, nasty - OK I get it, this happens with ANY non-existent table name. Let's fix that - these should clearly return an HTTP 404. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
292011379 | |
https://github.com/simonw/datasette/issues/193#issuecomment-380619851 | https://api.github.com/repos/simonw/datasette/issues/193 | 380619851 | MDEyOklzc3VlQ29tbWVudDM4MDYxOTg1MQ== | 9599 | 2018-04-11T22:48:19Z | 2018-04-11T22:48:19Z | OWNER | I can clean this up further with the mechanism I'm using for #184 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
310882100 | |
https://github.com/simonw/datasette/pull/200#issuecomment-380608372 | https://api.github.com/repos/simonw/datasette/issues/200 | 380608372 | MDEyOklzc3VlQ29tbWVudDM4MDYwODM3Mg== | 45057 | 2018-04-11T21:55:46Z | 2018-04-11T21:55:46Z | CONTRIBUTOR | > I think the most reliable way to detect spatialite is to run `SELECT AddGeometryColumn(1, 2, 3, 4, 5);` against a `:memory:` database and see if it throws an exception Or just see if there's a `geometry_columns` table? I think that's quite unlikely to be added by accident (and it's an OGC standard). It also tells you if Spatialite is installed in the database rather than just loaded. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
313494458 |