github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/pull/280#issuecomment-391141391 | https://api.github.com/repos/simonw/datasette/issues/280 | 391141391 | MDEyOklzc3VlQ29tbWVudDM5MTE0MTM5MQ== | 565628 | 2018-05-22T21:08:39Z | 2018-05-22T21:08:39Z | CONTRIBUTOR | I'm going to clean this up for consistency tomorrow morning so hold off merging until then please On Tue, May 22, 2018 at 6:34 PM, Simon Willison <notifications@github.com> wrote: > Yeah let's try this without pysqlite3 and see if we still get the correct > version. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/simonw/datasette/pull/280#issuecomment-391076458>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AAihfMI-H6CBt-Py0xdBbH2xDK0KsjT2ks5t1EwYgaJpZM4UI_2m> > . > | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
325373747 | |
https://github.com/simonw/datasette/pull/280#issuecomment-391076458 | https://api.github.com/repos/simonw/datasette/issues/280 | 391076458 | MDEyOklzc3VlQ29tbWVudDM5MTA3NjQ1OA== | 9599 | 2018-05-22T17:34:13Z | 2018-05-22T17:34:13Z | OWNER | Yeah let's try this without pysqlite3 and see if we still get the correct version. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
325373747 | |
https://github.com/simonw/datasette/pull/280#issuecomment-391076239 | https://api.github.com/repos/simonw/datasette/issues/280 | 391076239 | MDEyOklzc3VlQ29tbWVudDM5MTA3NjIzOQ== | 9599 | 2018-05-22T17:33:33Z | 2018-05-22T17:33:33Z | OWNER | This looks amazing! Can't wait to try this out this evening. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
325373747 | |
https://github.com/simonw/datasette/pull/280#issuecomment-391059008 | https://api.github.com/repos/simonw/datasette/issues/280 | 391059008 | MDEyOklzc3VlQ29tbWVudDM5MTA1OTAwOA== | 565628 | 2018-05-22T16:40:27Z | 2018-05-22T16:40:27Z | CONTRIBUTOR | ```python >>> import sqlite3 >>> sqlite3.sqlite_version '3.23.1' >>> ``` running the above in the container seems to show 3.23.1 too so maybe we don't need pysqlite3 at all? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
325373747 |