github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/306#issuecomment-395463497 | https://api.github.com/repos/simonw/datasette/issues/306 | 395463497 | MDEyOklzc3VlQ29tbWVudDM5NTQ2MzQ5Nw== | 9599 | 2018-06-07T15:29:28Z | 2018-06-07T15:29:28Z | OWNER | I started sketching this out in a branch, see pull request #307 - but I've decided I don't like it. I'm going to close this ticket and stick with regular expression URL routing for the moment. If I change my mind in the future the code in #307 lives in separate files (`datasette/routes.py` and `tests/test_routes.py`) so bringing it back into the project will be trivial. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
329661905 | |
https://github.com/simonw/datasette/pull/307#issuecomment-395463598 | https://api.github.com/repos/simonw/datasette/issues/307 | 395463598 | MDEyOklzc3VlQ29tbWVudDM5NTQ2MzU5OA== | 9599 | 2018-06-07T15:29:41Z | 2018-06-07T15:29:41Z | OWNER | Closing this pull request for reasons outlined here: https://github.com/simonw/datasette/issues/306#issuecomment-395463497 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
330323860 |