github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/266#issuecomment-397729945 | https://api.github.com/repos/simonw/datasette/issues/266 | 397729945 | MDEyOklzc3VlQ29tbWVudDM5NzcyOTk0NQ== | 9599 | 2018-06-15T20:13:05Z | 2018-06-15T20:13:05Z | OWNER | The "This data as ..." area of the page is getting a bit untidy, especially if I'm going to add other download options in the future. I think I'll move the HTML to the page footer (less concerns about taking up lots of space there) and then have a bit of JavaScript that turns it into a show/hide menu of some sort in its current location. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
323681589 | |
https://github.com/simonw/datasette/issues/233#issuecomment-397729500 | https://api.github.com/repos/simonw/datasette/issues/233 | 397729500 | MDEyOklzc3VlQ29tbWVudDM5NzcyOTUwMA== | 9599 | 2018-06-15T20:11:14Z | 2018-06-15T20:11:14Z | OWNER | The `.json` and `.csv` links displayed on the table page should default to using `?_labels=1` if Datasette detects that there are foreign key expansions available for the page. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
316444720 | |
https://github.com/simonw/datasette/issues/233#issuecomment-397729319 | https://api.github.com/repos/simonw/datasette/issues/233 | 397729319 | MDEyOklzc3VlQ29tbWVudDM5NzcyOTMxOQ== | 9599 | 2018-06-15T20:10:24Z | 2018-06-15T20:10:24Z | OWNER | I'm also going to add the ability to specify individual columns that you want to expand using `?_label=city_id&_label=state_id` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
316444720 | |
https://github.com/simonw/datasette/issues/233#issuecomment-397668427 | https://api.github.com/repos/simonw/datasette/issues/233 | 397668427 | MDEyOklzc3VlQ29tbWVudDM5NzY2ODQyNw== | 9599 | 2018-06-15T16:07:43Z | 2018-06-15T16:07:43Z | OWNER | Demo: https://datasette-json-labels-demo.now.sh/fixtures-fda0fea/facetable.json?_labels=1&_shape=array | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
316444720 | |
https://github.com/simonw/datasette/issues/233#issuecomment-397663968 | https://api.github.com/repos/simonw/datasette/issues/233 | 397663968 | MDEyOklzc3VlQ29tbWVudDM5NzY2Mzk2OA== | 9599 | 2018-06-15T15:51:17Z | 2018-06-15T15:51:17Z | OWNER | Nearly done, but I need the HTML view to ignore the `?_labels=1` param (it throws an error at the moment). | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
316444720 | |
https://github.com/simonw/datasette/issues/233#issuecomment-397648080 | https://api.github.com/repos/simonw/datasette/issues/233 | 397648080 | MDEyOklzc3VlQ29tbWVudDM5NzY0ODA4MA== | 9599 | 2018-06-15T14:56:21Z | 2018-06-15T14:56:21Z | OWNER | I considered including a `"table"` key like this: ``` "qLegalStatus": { "value" 2, "label": "Private", "table": "qLegalStatus" } ``` This would help generate the HTML links using just the JSON data. But... I realized that in a list of 50 rows that value would be duplicated 50 times which is a bit nasty. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
316444720 | |
https://github.com/simonw/datasette/issues/233#issuecomment-397637302 | https://api.github.com/repos/simonw/datasette/issues/233 | 397637302 | MDEyOklzc3VlQ29tbWVudDM5NzYzNzMwMg== | 9599 | 2018-06-15T14:24:08Z | 2018-06-15T14:55:19Z | OWNER | I'm going with the terminology "labels" here. You'll be able to add ``?_labels=1`` and the JSON will look something like this: ``` { "rowid": 233, "TreeID": 121240, "qLegalStatus": { "value" 2, "label": "Private" } "qSpecies": { "value": 16, "label": "Sycamore" } "qAddress": "91 Commonwealth Ave", ... } ``` I need this to help build foreign key expansions for CSV files, see #266 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
316444720 | |
https://github.com/simonw/datasette/issues/266#issuecomment-389570841 | https://api.github.com/repos/simonw/datasette/issues/266 | 389570841 | MDEyOklzc3VlQ29tbWVudDM4OTU3MDg0MQ== | 9599 | 2018-05-16T15:54:49Z | 2018-06-15T07:41:09Z | OWNER | At the most basic level, this will work based on an extension. Most places you currently put a `.json` extension should also allow a `.csv` extension. By default this will return the exact results you see on the current page (default max will remain 1000). ## Streaming all records Where things get interested is *streaming mode*. This will be an option which returns ALL matching records as a streaming CSV file, even if that ends up being millions of records. I think the best way to build this will be on top of the existing mechanism used to efficiently implement keyset pagination via `_next=` tokens. ## Expanding foreign keys For tables with foreign key references it would be useful if the CSV format could expand those references to include the labels from `label_column` - maybe via an additional `?_expand=1` option. When expanding each foreign key column will be shown twice: rowid,city_id,city_id_label,state | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
323681589 | |
https://github.com/simonw/datasette/issues/266#issuecomment-397534498 | https://api.github.com/repos/simonw/datasette/issues/266 | 397534498 | MDEyOklzc3VlQ29tbWVudDM5NzUzNDQ5OA== | 9599 | 2018-06-15T07:13:52Z | 2018-06-15T07:13:52Z | OWNER | Also needs documentation. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
323681589 | |
https://github.com/simonw/datasette/issues/266#issuecomment-397534404 | https://api.github.com/repos/simonw/datasette/issues/266 | 397534404 | MDEyOklzc3VlQ29tbWVudDM5NzUzNDQwNA== | 9599 | 2018-06-15T07:13:20Z | 2018-06-15T07:13:20Z | OWNER | Still to add: the streaming version that iterates through all of the pages, as seen in experimental commit https://github.com/simonw/datasette/commit/ced379ea325787b8c3bf0a614daba1fa4856a3bd | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
323681589 | |
https://github.com/simonw/datasette/issues/266#issuecomment-397534196 | https://api.github.com/repos/simonw/datasette/issues/266 | 397534196 | MDEyOklzc3VlQ29tbWVudDM5NzUzNDE5Ng== | 9599 | 2018-06-15T07:12:16Z | 2018-06-15T07:12:16Z | OWNER | The first version of this is now shipped to master. I ended up rewriting most of the experimental branch to deal with the nasty issue described in #303 Demo is available on https://fivethirtyeight.datasettes.com/fivethirtyeight-ab24e01/most-common-name%2Fsurnames ![2018-06-15 at 12 11 am](https://user-images.githubusercontent.com/9599/41455090-bd5ece30-7030-11e8-8da4-11fbb1f2ef8b.png) Here's the CSV version of that page: https://fivethirtyeight.datasettes.com/fivethirtyeight-ab24e01/most-common-name%2Fsurnames.csv | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
323681589 |