github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/272#issuecomment-404514973 | https://api.github.com/repos/simonw/datasette/issues/272 | 404514973 | MDEyOklzc3VlQ29tbWVudDQwNDUxNDk3Mw== | 647359 | 2018-07-12T13:38:24Z | 2018-07-12T13:38:24Z | NONE | Okay. I reckon the latest version should have all the kinds of components you'd need: Recently added ASGI components for Routing and Static Files support, as well as making few tweaks to make sure requests and responses are instantiated efficiently. Don't have any redirect-to-slash / redirect-to-non-slash stuff out of the box yet, which it looks like you might miss. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
324188953 | |
https://github.com/simonw/datasette/issues/339#issuecomment-404565566 | https://api.github.com/repos/simonw/datasette/issues/339 | 404565566 | MDEyOklzc3VlQ29tbWVudDQwNDU2NTU2Ng== | 9599 | 2018-07-12T16:08:42Z | 2018-07-12T16:08:42Z | OWNER | I'm going to turn this into an issue about better supporting the above option. | { "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
340396247 | |
https://github.com/simonw/datasette/issues/332#issuecomment-402243153 | https://api.github.com/repos/simonw/datasette/issues/332 | 402243153 | MDEyOklzc3VlQ29tbWVudDQwMjI0MzE1Mw== | 9599 | 2018-07-03T17:58:50Z | 2018-07-12T16:10:39Z | OWNER | I think I'm going to return `null` in the JSON for infinity/nan values by default, but if you send `_nan=1` I will instead return invalid JSON with `Infinity` or `NaN` in it (since you have opted in to getting those and hence should be able to handle them). | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
337141108 | |
https://github.com/simonw/datasette/issues/332#issuecomment-404567587 | https://api.github.com/repos/simonw/datasette/issues/332 | 404567587 | MDEyOklzc3VlQ29tbWVudDQwNDU2NzU4Nw== | 9599 | 2018-07-12T16:15:29Z | 2018-07-12T16:17:54Z | OWNER | Here's how plotly handled this issue: https://github.com/plotly/plotly.py/pull/203 - see also https://github.com/plotly/plotly.py/blob/213602df6c89b45ce2b811ed2591171c961408e7/plotly/utils.py#L137 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
337141108 | |
https://github.com/simonw/datasette/issues/332#issuecomment-404569003 | https://api.github.com/repos/simonw/datasette/issues/332 | 404569003 | MDEyOklzc3VlQ29tbWVudDQwNDU2OTAwMw== | 9599 | 2018-07-12T16:20:06Z | 2018-07-12T16:20:06Z | OWNER | And here's how django-rest-framework did it: https://github.com/encode/django-rest-framework/pull/4918/files | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
337141108 | |
https://github.com/simonw/datasette/issues/332#issuecomment-404574598 | https://api.github.com/repos/simonw/datasette/issues/332 | 404574598 | MDEyOklzc3VlQ29tbWVudDQwNDU3NDU5OA== | 9599 | 2018-07-12T16:39:51Z | 2018-07-12T16:39:51Z | OWNER | Since my data is all flat lists of values I don't think I need to customize the JSON encoder itself (no need to deal with nested values). I'll fix the data on its way into the encoder instead. This will also help if I decide to move to uJSON for better performance #48 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
337141108 | |
https://github.com/simonw/datasette/issues/339#issuecomment-404576136 | https://api.github.com/repos/simonw/datasette/issues/339 | 404576136 | MDEyOklzc3VlQ29tbWVudDQwNDU3NjEzNg== | 12617395 | 2018-07-12T16:45:08Z | 2018-07-12T16:45:08Z | NONE | Thanks for the quick reply. Looks like that is working well. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
340396247 |