github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/332#issuecomment-405968983 | https://api.github.com/repos/simonw/datasette/issues/332 | 405968983 | MDEyOklzc3VlQ29tbWVudDQwNTk2ODk4Mw== | 9599 | 2018-07-18T15:18:57Z | 2018-07-18T15:18:57Z | OWNER | Maybe argument should be `?_json_nan=1` since that makes it more explicitly obvious what is going on here. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
337141108 | |
https://github.com/simonw/datasette/issues/308#issuecomment-405971920 | https://api.github.com/repos/simonw/datasette/issues/308 | 405971920 | MDEyOklzc3VlQ29tbWVudDQwNTk3MTkyMA== | 9599 | 2018-07-18T15:27:12Z | 2018-07-18T15:27:12Z | OWNER | It looks like there are a few extra options we should support: https://devcenter.heroku.com/articles/heroku-cli-commands ``` -t, --team=team team to use --region=region specify region for the app to run in --space=space the private space to create the app in ``` Since these differ from the options for Zeit Now I think this means splitting up `datasette publish now` and `datasette publish Heroku` into separate subcommands. | { "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
330826972 | |
https://github.com/simonw/datasette/issues/333#issuecomment-405975025 | https://api.github.com/repos/simonw/datasette/issues/333 | 405975025 | MDEyOklzc3VlQ29tbWVudDQwNTk3NTAyNQ== | 9599 | 2018-07-18T15:36:11Z | 2018-07-18T15:40:04Z | OWNER | A `force_https_api_urls` config option would work here - if set, Datasette will ignore the incoming protocol and always use https. The `datasette deploy now` command could then add that as an option passed to `datasette serve`. This is the pattern which is producing incorrect URLs on Zeit Now, because the Sanic `request.url` property is not being correctly set. https://github.com/simonw/datasette/blob/6e37f091edec35e2706197489f54fff5d890c63c/datasette/views/table.py#L653-L655 Suggested help text: > Always use https:// for URLs output as part of Datasette API responses | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
338768551 | |
https://github.com/simonw/datasette/issues/333#issuecomment-405988035 | https://api.github.com/repos/simonw/datasette/issues/333 | 405988035 | MDEyOklzc3VlQ29tbWVudDQwNTk4ODAzNQ== | 9599 | 2018-07-18T16:12:35Z | 2018-07-18T16:12:35Z | OWNER | I'll add a `absolute_url(request, path)` method on the base view class which knows to check the new config option. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
338768551 |