github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/272#issuecomment-408105251 | https://api.github.com/repos/simonw/datasette/issues/272 | 408105251 | MDEyOklzc3VlQ29tbWVudDQwODEwNTI1MQ== | 9599 | 2018-07-26T13:54:06Z | 2018-07-26T13:54:06Z | OWNER | Tom shipped my fix for that bug already, so https://datasette-starlette-demo.now.sh/ is now serving CSS! | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
324188953 | |
https://github.com/simonw/datasette/issues/272#issuecomment-408093480 | https://api.github.com/repos/simonw/datasette/issues/272 | 408093480 | MDEyOklzc3VlQ29tbWVudDQwODA5MzQ4MA== | 9599 | 2018-07-26T13:15:55Z | 2018-07-26T13:46:40Z | OWNER | I'm now hacking around with an initial version of this in the [starlette branch](https://github.com/simonw/datasette/tree/starlette). Here's my work in progress, deployed using `datasette publish now fixtures.db -n datasette-starlette-demo --branch=starlette --extra-options="--asgi"` https://datasette-starlette-demo.now.sh/ Lots more work to do - the CSS isn't being served correctly for example, it's showing this error when I hit `/-/static/app.css`: ``` INFO: 127.0.0.1 - "GET /-/static/app.css HTTP/1.1" 200 ERROR: Exception in ASGI application Traceback (most recent call last): File "/Users/simonw/Dropbox/Development/datasette/venv/lib/python3.6/site-packages/uvicorn/protocols/http/httptools_impl.py", line 363, in run_asgi result = await asgi(self.receive, self.send) File "/Users/simonw/Dropbox/Development/datasette/venv/lib/python3.6/site-packages/starlette/staticfiles.py", line 91, in __call__ await response(receive, send) File "/Users/simonw/Dropbox/Development/datasette/venv/lib/python3.6/site-packages/starlette/response.py", line 180, in __call__ {"type": "http.response.body", "body": chunk, "more_body": False} File "/Users/simonw/Dropbox/Development/datasette/venv/lib/python3.6/site-packages/uvicorn/protocols/http/httptools_impl.py", line 483, in send raise RuntimeError("Response content shorter than Content-Length") RuntimeError: Response content shorter than Content-Length ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
324188953 | |
https://github.com/simonw/datasette/issues/272#issuecomment-408097719 | https://api.github.com/repos/simonw/datasette/issues/272 | 408097719 | MDEyOklzc3VlQ29tbWVudDQwODA5NzcxOQ== | 9599 | 2018-07-26T13:29:38Z | 2018-07-26T13:29:38Z | OWNER | It looks like that's a bug in Starlette - filed here: https://github.com/encode/starlette/issues/32 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
324188953 | |
https://github.com/simonw/datasette/issues/348#issuecomment-407983375 | https://api.github.com/repos/simonw/datasette/issues/348 | 407983375 | MDEyOklzc3VlQ29tbWVudDQwNzk4MzM3NQ== | 9599 | 2018-07-26T05:46:01Z | 2018-07-26T05:46:01Z | OWNER | Oops, forgot to commit those unit tests. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
344656114 | |
https://github.com/simonw/datasette/pull/349#issuecomment-407980716 | https://api.github.com/repos/simonw/datasette/issues/349 | 407980716 | MDEyOklzc3VlQ29tbWVudDQwNzk4MDcxNg== | 9599 | 2018-07-26T05:28:54Z | 2018-07-26T05:28:54Z | OWNER | Documentation here: http://datasette.readthedocs.io/en/latest/plugins.html#publish-subcommand-publish The best way to write a new publish plugin is to check out how the Heroku and Now default plugins are implemented: https://github.com/simonw/datasette/tree/master/datasette/publish | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
344695978 | |
https://github.com/simonw/datasette/issues/217#issuecomment-407980050 | https://api.github.com/repos/simonw/datasette/issues/217 | 407980050 | MDEyOklzc3VlQ29tbWVudDQwNzk4MDA1MA== | 9599 | 2018-07-26T05:24:17Z | 2018-07-26T05:24:17Z | OWNER | Documentation: http://datasette.readthedocs.io/en/latest/plugins.html#publish-subcommand-publish | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
314725342 | |
https://github.com/simonw/datasette/issues/301#issuecomment-407979065 | https://api.github.com/repos/simonw/datasette/issues/301 | 407979065 | MDEyOklzc3VlQ29tbWVudDQwNzk3OTA2NQ== | 9599 | 2018-07-26T05:17:34Z | 2018-07-26T05:17:34Z | OWNER | This code now lives in https://github.com/simonw/datasette/blob/master/datasette/publish/heroku.py | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
328155946 |