github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/393#issuecomment-450943172 | https://api.github.com/repos/simonw/datasette/issues/393 | 450943172 | MDEyOklzc3VlQ29tbWVudDQ1MDk0MzE3Mg== | 9599 | 2019-01-02T18:28:43Z | 2019-01-02T18:28:43Z | OWNER | Definitely a bug, thanks. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
395236066 | |
https://github.com/simonw/datasette/issues/393#issuecomment-450943632 | https://api.github.com/repos/simonw/datasette/issues/393 | 450943632 | MDEyOklzc3VlQ29tbWVudDQ1MDk0MzYzMg== | 9599 | 2019-01-02T18:30:20Z | 2019-01-02T18:30:20Z | OWNER | This is the code which is meant to add those options as hidden form fields: https://github.com/simonw/datasette/blob/fe5b6ea95a973534fe8a44907c0ea2449aae7602/datasette/templates/table.html#L150-L155 It's clearly not working. Need to fix this and add a corresponding unit test. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
395236066 | |
https://github.com/simonw/datasette/issues/393#issuecomment-450944166 | https://api.github.com/repos/simonw/datasette/issues/393 | 450944166 | MDEyOklzc3VlQ29tbWVudDQ1MDk0NDE2Ng== | 9599 | 2019-01-02T18:32:12Z | 2019-01-02T18:32:12Z | OWNER | Here's the test that needs updating: https://github.com/simonw/datasette/blob/8b8ae55e7c8b9e1dceef53f55a330b596ca44d41/tests/test_html.py#L427-L435 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
395236066 | |
https://github.com/simonw/datasette/issues/391#issuecomment-450964512 | https://api.github.com/repos/simonw/datasette/issues/391 | 450964512 | MDEyOklzc3VlQ29tbWVudDQ1MDk2NDUxMg== | 9599 | 2019-01-02T19:45:12Z | 2019-01-02T19:45:12Z | OWNER | Thanks, I've fixed this. I had to re-alias it against now: ``` ~ $ now alias google-trends-pnwhfwvgqf.now.sh https://google-trends.datasettes.com/ > Assigning alias google-trends.datasettes.com to deployment google-trends-pnwhfwvgqf.now.sh > Certificate for google-trends.datasettes.com (cert_uXaADIuNooHS3tZ) created [18s] > Success! google-trends.datasettes.com now points to google-trends-pnwhfwvgqf.now.sh [20s] ``` | { "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
392610803 |