github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/425#issuecomment-480558501 | https://api.github.com/repos/simonw/datasette/issues/425 | 480558501 | MDEyOklzc3VlQ29tbWVudDQ4MDU1ODUwMQ== | 9599 | 2019-04-07T04:32:28Z | 2019-04-07T04:32:28Z | OWNER | Here's the problem: https://github.com/simonw/datasette/blob/6f6d0ff2b41f1cacaf42287b1b230b646bcba9ee/datasette/templates/query.html#L30-L36 Need an else block here that adds the SQL as a hidden form field. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
430103450 | |
https://github.com/simonw/datasette/issues/420#issuecomment-480556166 | https://api.github.com/repos/simonw/datasette/issues/420 | 480556166 | MDEyOklzc3VlQ29tbWVudDQ4MDU1NjE2Ng== | 9599 | 2019-04-07T03:35:59Z | 2019-04-07T03:48:14Z | OWNER | Still need to solve: `TableView.data()` - but this is the one with a row count in hence the need to solve #422 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
421971339 | |
https://github.com/simonw/datasette/issues/420#issuecomment-480552387 | https://api.github.com/repos/simonw/datasette/issues/420 | 480552387 | MDEyOklzc3VlQ29tbWVudDQ4MDU1MjM4Nw== | 9599 | 2019-04-07T02:06:20Z | 2019-04-07T02:06:20Z | OWNER | `expand_foreign_keys()` relies on the `.inspect()` command having automatically derived the `label_column` for a table, which it does using this code: https://github.com/simonw/datasette/blob/97331f3435ba1583a0f9dbcaffc25de8894cf1f8/datasette/inspect.py#L34-L42 This needs access to the column names for the table. I think we can drop this entirely in favour of a new utility function - and that function can incorporate the metadata check as well. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
421971339 |