github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/pull/441#issuecomment-488373631 | https://api.github.com/repos/simonw/datasette/issues/441 | 488373631 | MDEyOklzc3VlQ29tbWVudDQ4ODM3MzYzMQ== | 9599 | 2019-05-01T18:43:17Z | 2019-05-01T18:43:17Z | OWNER | I plan to merge this in about 7 hours time (after work). I may tweak the plugin format a little bit before the next Datasette release though (best to merge first, make changes later I think) - for consistency with some other upcoming hooks (the facet hook in particular). I'll discuss that with you while I'm working on it. Thanks so much for this, it's a really neat addition! | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
438437973 | |
https://github.com/simonw/datasette/issues/438#issuecomment-488370672 | https://api.github.com/repos/simonw/datasette/issues/438 | 488370672 | MDEyOklzc3VlQ29tbWVudDQ4ODM3MDY3Mg== | 9599 | 2019-05-01T18:33:57Z | 2019-05-01T18:33:57Z | OWNER | Yeah this is a good call. Having pytest set some kind of flag (maybe an environment variable?) that disables auto-plugin discovery is a very reasonable fix here. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
438200529 | |
https://github.com/simonw/datasette/pull/441#issuecomment-488247617 | https://api.github.com/repos/simonw/datasette/issues/441 | 488247617 | MDEyOklzc3VlQ29tbWVudDQ4ODI0NzYxNw== | 45057 | 2019-05-01T09:57:50Z | 2019-05-01T09:57:50Z | CONTRIBUTOR | Just for the record, this PR is now finished and ready to merge from my perspective. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
438437973 |