github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/453#issuecomment-489421634 | https://api.github.com/repos/simonw/datasette/issues/453 | 489421634 | MDEyOklzc3VlQ29tbWVudDQ4OTQyMTYzNA== | 9599 | 2019-05-05T12:24:24Z | 2019-05-05T12:24:24Z | OWNER | Demo: https://latest.datasette.io/fixtures.json?sql=select+blah <img width="793" alt="Mozilla_Firefox" src="https://user-images.githubusercontent.com/9599/57193981-2c4dce80-6f0f-11e9-859e-032fb21e75ed.png"> | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
440332621 | |
https://github.com/simonw/datasette/issues/454#issuecomment-489420385 | https://api.github.com/repos/simonw/datasette/issues/454 | 489420385 | MDEyOklzc3VlQ29tbWVudDQ4OTQyMDM4NQ== | 9599 | 2019-05-05T12:07:56Z | 2019-05-05T12:10:13Z | OWNER | Since I want the option to store more than one host, I don't think this should be a command-line option or a `--config` setting. Instead, I'm inclined to add this to `metadata.json`. Maybe this should be a plugin? That way the `metadata.json` setting could look like this: ``` { "title": "Title of this instance", "plugins": { "datasette-cors": { "allowed_origins": ["https://example.com"] } } } ``` This could be implemented easily on top of ASGI #272. (It should probably raise an exception on startup if any of the `allowed_origins` ends with a slash e.g. `"https://example.com/"` since that's not actually a valid origin, and it's an easy mistake to make.) | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
440437037 | |
https://github.com/simonw/datasette/issues/454#issuecomment-489420661 | https://api.github.com/repos/simonw/datasette/issues/454 | 489420661 | MDEyOklzc3VlQ29tbWVudDQ4OTQyMDY2MQ== | 9599 | 2019-05-05T12:11:01Z | 2019-05-05T12:11:01Z | OWNER | Also worth considering: `Access-Control-Max-Age: 86400` support - maybe as a `"max_age"` setting for the plugin. This can reduce the number of preflight checks the browser needs to make. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
440437037 | |
https://github.com/simonw/datasette/issues/454#issuecomment-489433651 | https://api.github.com/repos/simonw/datasette/issues/454 | 489433651 | MDEyOklzc3VlQ29tbWVudDQ4OTQzMzY1MQ== | 9599 | 2019-05-05T14:52:46Z | 2019-05-05T14:52:46Z | OWNER | I really like the idea of this as a plugin, because it will provide a great example of an ASGI plugin including how to build unit tests against Datasette plugins which actually start up a Datasette server and run some requests through it. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
440437037 |