github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/435#issuecomment-491541721 | https://api.github.com/repos/simonw/datasette/issues/435 | 491541721 | MDEyOklzc3VlQ29tbWVudDQ5MTU0MTcyMQ== | 9599 | 2019-05-11T20:32:21Z | 2019-05-11T20:32:21Z | OWNER | Demo of the finished feature: https://latest.datasette.io/fixtures/facetable?_trace=1 <img width="1294" alt="image" src="https://user-images.githubusercontent.com/9599/57574617-2ebd9600-73f1-11e9-9a1a-458f1b7d0d66.png"> | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
435531034 | |
https://github.com/simonw/datasette/issues/435#issuecomment-491534162 | https://api.github.com/repos/simonw/datasette/issues/435 | 491534162 | MDEyOklzc3VlQ29tbWVudDQ5MTUzNDE2Mg== | 9599 | 2019-05-11T18:33:02Z | 2019-05-11T18:36:33Z | OWNER | I don't like the shape of the JSON: ``` "_traces": { "num_traces": 20, "traces": { "duration": 0.015190839767456055, "queries": [ [ "sql", [ "fixtures", "select 1 from sqlite_master where type='table' and name=?", [ "facetable.json" ] ], 1557599406.7231224, 1557599406.723611, 0.4887580871582031 ], [ ``` I want this instead: ``` "_traces": { "num_traces": 20, "sum_duration_ms": 0.015190839767456055, "traces": [ { "type": "sql", "database": "fixtures", "sql": "select 1 from sqlite_master where type='table' and name=?", "args": ["facetable.json"], "start": 1557599406.7231224, "end": 1557599406.723611, "duration_ms": 0.4887580871582031 } | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
435531034 |