github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/pull/533#issuecomment-507895104 | https://api.github.com/repos/simonw/datasette/issues/533 | 507895104 | MDEyOklzc3VlQ29tbWVudDUwNzg5NTEwNA== | 9599 | 2019-07-03T00:46:20Z | 2019-07-03T00:46:33Z | OWNER | I'd like to rename `_rows_and_columns.html` to `_table.html`. There is at least one project out there using the current filename though: https://github.com/baltimore-sun-data/salaries-datasette/blob/master/templates/_rows_and_columns.html - I shall file an issue there to let them know about the backwards incompatible change. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
463492395 | |
https://github.com/simonw/datasette/issues/521#issuecomment-507922465 | https://api.github.com/repos/simonw/datasette/issues/521 | 507922465 | MDEyOklzc3VlQ29tbWVudDUwNzkyMjQ2NQ== | 9599 | 2019-07-03T03:23:55Z | 2019-07-03T03:23:55Z | OWNER | Fixed by #533 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
459621683 | |
https://github.com/simonw/datasette/issues/215#issuecomment-507929913 | https://api.github.com/repos/simonw/datasette/issues/215 | 507929913 | MDEyOklzc3VlQ29tbWVudDUwNzkyOTkxMw== | 9599 | 2019-07-03T04:08:28Z | 2019-07-03T04:08:28Z | OWNER | I just closed #520 which means this is now technically possible. But... doing it using the new `asgi_wrapper` hook https://datasette.readthedocs.io/en/latest/plugins.html#asgi-wrapper-datasette isn't particularly obvious. I'm going to leave this ticket open for the moment. I think I need at least one example plugin to show that this approach is good enough - and it's still quite possible that I'll add an extra, easier hook for this. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
314506669 | |
https://github.com/simonw/datasette/issues/520#issuecomment-507935352 | https://api.github.com/repos/simonw/datasette/issues/520 | 507935352 | MDEyOklzc3VlQ29tbWVudDUwNzkzNTM1Mg== | 9599 | 2019-07-03T04:40:34Z | 2019-07-03T04:40:34Z | OWNER | Documentation for the new hook: https://datasette.readthedocs.io/en/latest/plugins.html#asgi-wrapper-datasette | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
459598080 | |
https://github.com/simonw/datasette/issues/538#issuecomment-508224962 | https://api.github.com/repos/simonw/datasette/issues/538 | 508224962 | MDEyOklzc3VlQ29tbWVudDUwODIyNDk2Mg== | 9599 | 2019-07-03T19:24:32Z | 2019-07-03T19:24:32Z | OWNER | Initial syntax suggestion: ```json { "title": "datasette-auth-github demo", "plugins": { "datasette-auth-github": { "client_id": "986f5d837b45e32ee6dd", "client_secret": {"$env": "GITHUB_CLIENT_SECRET"} } } } ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
463915863 | |
https://github.com/simonw/datasette/issues/538#issuecomment-508225524 | https://api.github.com/repos/simonw/datasette/issues/538 | 508225524 | MDEyOklzc3VlQ29tbWVudDUwODIyNTUyNA== | 9599 | 2019-07-03T19:26:32Z | 2019-07-03T19:26:32Z | OWNER | Another useful option is the ability to load secrets from a file. This allows the file to have permissions set on it to only be read by the Datasette user. It also interacts well with the Kubernetes secrets mechanism, which is file-based. ```json { "plugins": { "datasette-auth-github": { "client_id": "986f5d837b45e32ee6dd", "client_secret": {"$file": "/secrets/github-client-secret"} } } } | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
463915863 |