github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/pull/554#issuecomment-510542280 | https://api.github.com/repos/simonw/datasette/issues/554 | 510542280 | MDEyOklzc3VlQ29tbWVudDUxMDU0MjI4MA== | 9599 | 2019-07-11T15:47:31Z | 2019-07-11T15:47:31Z | OWNER | Thanks for this! The tests are failing for Python 3.5 right now which is strange. https://travis-ci.org/simonw/datasette/jobs/556272017 One failure looks like this: ``` app_client = <tests.fixtures.TestClient object at 0x7fb7803285f8> def test_static(app_client): response = app_client.get("/-/static/app2.css") > assert response.status == 404 E assert 500 == 404 E + where 500 = <tests.fixtures.TestResponse object at 0x7fb780328a58>.status /home/travis/build/simonw/datasette/tests/test_html.py:56: AssertionError ----------------------------- Captured stderr call ----------------------------- Traceback (most recent call last): File "/home/travis/build/simonw/datasette/datasette/utils/asgi.py", line 100, in __call__ return await view(new_scope, receive, send) File "/home/travis/build/simonw/datasette/datasette/utils/asgi.py", line 303, in inner_static full_path = (Path(root_path) / path).resolve().absolute() File "/opt/python/3.5.6/lib/python3.5/pathlib.py", line 1109, in resolve s = self._flavour.resolve(self) File "/opt/python/3.5.6/lib/python3.5/pathlib.py", line 330, in resolve return _resolve(base, str(path)) or sep File "/opt/python/3.5.6/lib/python3.5/pathlib.py", line 315, in _resolve target = accessor.readlink(newpath) File "/opt/python/3.5.6/lib/python3.5/pathlib.py", line 422, in readlink return os.readlink(path) FileNotFoundError: [Errno 2] No such file or directory: '/home/travis/build/simonw/datasette/datasette/static/app2.css' ``` Maybe an exception was renamed between 3.5 and 3.6? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
465728430 | |
https://github.com/simonw/datasette/pull/556#issuecomment-510550279 | https://api.github.com/repos/simonw/datasette/issues/556 | 510550279 | MDEyOklzc3VlQ29tbWVudDUxMDU1MDI3OQ== | 9599 | 2019-07-11T16:07:27Z | 2019-07-11T16:07:27Z | OWNER | This is a really neat trick, thanks! | { "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
465773546 | |
https://github.com/simonw/datasette/pull/554#issuecomment-510558696 | https://api.github.com/repos/simonw/datasette/issues/554 | 510558696 | MDEyOklzc3VlQ29tbWVudDUxMDU1ODY5Ng== | 9599 | 2019-07-11T16:29:25Z | 2019-07-11T16:29:25Z | OWNER | Released as 0.29.1: https://datasette.readthedocs.io/en/latest/changelog.html#v0-29-1 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
465728430 | |
https://github.com/simonw/datasette/issues/511#issuecomment-510559337 | https://api.github.com/repos/simonw/datasette/issues/511 | 510559337 | MDEyOklzc3VlQ29tbWVudDUxMDU1OTMzNw== | 9599 | 2019-07-11T16:31:06Z | 2019-07-11T16:31:06Z | OWNER | @abdusco you mentioned Windows in #554 - can you confirm that Datasette is Windows compatible as of v0.29? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
456578474 | |
https://github.com/simonw/datasette/issues/511#issuecomment-510559836 | https://api.github.com/repos/simonw/datasette/issues/511 | 510559836 | MDEyOklzc3VlQ29tbWVudDUxMDU1OTgzNg== | 9599 | 2019-07-11T16:32:27Z | 2019-07-11T16:32:27Z | OWNER | Travis CI supports Windows - Uvicorn is using it here: https://github.com/encode/uvicorn/blob/15c4e9cfe2d996bd73ed6b542e44160f620b9519/.travis.yml | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
456578474 | |
https://github.com/simonw/datasette/pull/557#issuecomment-510562059 | https://api.github.com/repos/simonw/datasette/issues/557 | 510562059 | MDEyOklzc3VlQ29tbWVudDUxMDU2MjA1OQ== | 9599 | 2019-07-11T16:38:27Z | 2019-07-11T16:38:27Z | OWNER | Weird, Travis didn't even attempt to start a build for this branch/PR. Maybe something wrong with my `.travis.yml`? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
466996584 |