github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/638#issuecomment-557331366 | https://api.github.com/repos/simonw/datasette/issues/638 | 557331366 | MDEyOklzc3VlQ29tbWVudDU1NzMzMTM2Ng== | 9599 | 2019-11-22T00:19:40Z | 2019-11-22T00:19:40Z | OWNER | We currently use `select distinct wikipedia_url ...` to suggest facets. This query would only return rows which are represented twice or more: ```sql select wikipedia_url, count(*) as n from museums where wikipedia_url is not null group by wikipedia_url having n > 1 ``` https://www.niche-museums.com/museums?sql=select%0D%0A++wikipedia_url%2C+count%28*%29+as+n%0D%0Afrom%0D%0A++museums%0D%0Awhere%0D%0A++wikipedia_url+is+not+null%0D%0Agroup+by+wikipedia_url%0D%0Ahaving+n+%3E+1 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
526913133 | |
https://github.com/simonw/datasette/issues/638#issuecomment-557333467 | https://api.github.com/repos/simonw/datasette/issues/638 | 557333467 | MDEyOklzc3VlQ29tbWVudDU1NzMzMzQ2Nw== | 9599 | 2019-11-22T00:28:07Z | 2019-11-22T00:28:07Z | OWNER | It's not as simple as that - `planet_int` should be a suggested facet on https://latest.datasette.io/fixtures/facetable?_facet=planet_int because it returns two filters, even though one of those two is a value of 1. Switching to the new proposed SQL statement misses this. <img width="830" alt="fixtures__facetable__15_rows_and_museums__select___from__select_id__name__url__address__description__wikipedia_url__photo_url__photo_alt__latitude__longitude__press__permanently_closed__hours_from_museums_order_by_id___limit_0" src="https://user-images.githubusercontent.com/9599/69387809-dc044700-0c7b-11ea-8d78-5004af2a4434.png"> | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
526913133 | |
https://github.com/simonw/datasette/issues/638#issuecomment-557343750 | https://api.github.com/repos/simonw/datasette/issues/638 | 557343750 | MDEyOklzc3VlQ29tbWVudDU1NzM0Mzc1MA== | 9599 | 2019-11-22T01:14:59Z | 2019-11-22T01:14:59Z | OWNER | Demo: https://latest.datasette.io/fixtures/facetable doesn't suggest `distinct_some_null` as a facet. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
526913133 |