github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/648#issuecomment-563001064 | https://api.github.com/repos/simonw/datasette/issues/648 | 563001064 | MDEyOklzc3VlQ29tbWVudDU2MzAwMTA2NA== | 9599 | 2019-12-08T22:09:20Z | 2019-12-08T22:09:20Z | OWNER | Stretch goal: it would be neat if these pages could return custom HTTP headers (eg content-type) and maybe even status codes (eg for redirects) somehow. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
534492501 | |
https://github.com/simonw/datasette/issues/648#issuecomment-563000942 | https://api.github.com/repos/simonw/datasette/issues/648 | 563000942 | MDEyOklzc3VlQ29tbWVudDU2MzAwMDk0Mg== | 9599 | 2019-12-08T22:08:14Z | 2019-12-08T22:08:14Z | OWNER | Alternative idea: a new concept of "pages" which live inside `templates/pages/` and where the file name minus the `.html` extension defines the URL. `templates/about/me.html` would be served at `/about/me` - but only if no matching database and table were found. This only takes effect on 404 errors from core Datasette. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
534492501 | |
https://github.com/simonw/datasette/issues/649#issuecomment-562940252 | https://api.github.com/repos/simonw/datasette/issues/649 | 562940252 | MDEyOklzc3VlQ29tbWVudDU2Mjk0MDI1Mg== | 9599 | 2019-12-08T11:59:52Z | 2019-12-08T12:00:12Z | OWNER | The easiest solution would be to only show counts on the index pages for immutable (`-i`) databases. I don't like this, because the most common uses of Datasette don't in my opinion justify it. Most of the time Datasette will be running against a single, small, mutable database. I'd like to show counts in that case. Some options: - disable counts on the index page for mutable databases of more than one is attached - disable counts on the index page for databases where the file in disk is larger than a specified threshold (maybe 10MB? I'm making up this number) - implement an overall timer which cuts off table counting once the sum of time spent on it has gone beyond a second Worth prototyping a bit to see what works best. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
534530973 | |
https://github.com/simonw/datasette/issues/648#issuecomment-562913040 | https://api.github.com/repos/simonw/datasette/issues/648 | 562913040 | MDEyOklzc3VlQ29tbWVudDU2MjkxMzA0MA== | 9599 | 2019-12-08T04:56:43Z | 2019-12-08T04:56:43Z | OWNER | Idea: do this with a simple template naming convention. If you hit `/about` and there is no matching database, check for a template file called `about-page.html`. If it exists, render it. Otherwise return a 404 database not found. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
534492501 |