github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/674#issuecomment-586623462 | https://api.github.com/repos/simonw/datasette/issues/674 | 586623462 | MDEyOklzc3VlQ29tbWVudDU4NjYyMzQ2Mg== | 9599 | 2020-02-15T17:36:53Z | 2020-03-26T17:19:23Z | OWNER | ... actually we don't need to do that, we have a mechanism for that already: https://github.com/simonw/datasette/blob/f1442a8151f66ceef6517b6d3d045e2ec1d0f0ec/tests/build_small_spatialite_db.py | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
565552217 | |
https://github.com/simonw/datasette/issues/674#issuecomment-586625451 | https://api.github.com/repos/simonw/datasette/issues/674 | 586625451 | MDEyOklzc3VlQ29tbWVudDU4NjYyNTQ1MQ== | 9599 | 2020-02-15T17:57:43Z | 2020-02-15T17:57:43Z | OWNER | I don't have a unit test for other databases that can't be opened, but I tested it manually against a copy of an Apple Photos `photos.db` file (found using `find ~/Library | grep photos.db`) and got this: ``` $ datasette /tmp/photos.db Serve! files=('/tmp/photos.db',) (immutables=()) on port 8001 Usage: datasette serve [OPTIONS] [FILES]... Error: Connection to /tmp/photos.db failed check: no such module: RidList_VirtualReaderModule ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
565552217 | |
https://github.com/simonw/datasette/issues/674#issuecomment-586622557 | https://api.github.com/repos/simonw/datasette/issues/674 | 586622557 | MDEyOklzc3VlQ29tbWVudDU4NjYyMjU1Nw== | 9599 | 2020-02-15T17:26:43Z | 2020-02-15T17:38:56Z | OWNER | `datasette.utils.check_connection(conn)` I'd like it to be able to return an indicator of what the problem is, so that the spatialite check above can behave in a special way. So maybe it raises a `ConnectionProblem` exception if there is a problem? `SpatialiteConnectionProblem` can be a subclass of that. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
565552217 | |
https://github.com/simonw/datasette/issues/674#issuecomment-586622677 | https://api.github.com/repos/simonw/datasette/issues/674 | 586622677 | MDEyOklzc3VlQ29tbWVudDU4NjYyMjY3Nw== | 9599 | 2020-02-15T17:28:03Z | 2020-02-15T17:28:03Z | OWNER | I can unit test this with a minimal SpatiaLite database, created like this: https://github.com/simonw/datasette/issues/673#issuecomment-586449286 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
565552217 | |
https://github.com/simonw/datasette/issues/674#issuecomment-586622194 | https://api.github.com/repos/simonw/datasette/issues/674 | 586622194 | MDEyOklzc3VlQ29tbWVudDU4NjYyMjE5NA== | 9599 | 2020-02-15T17:22:57Z | 2020-02-15T17:22:57Z | OWNER | I did some research for this in #673 - I think the solution is to split this out into a separate utility function: https://github.com/simonw/datasette/blob/3ffb8f3b98252531d11897fd431711e9b8045ace/datasette/app.py#L219-L237 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
565552217 | |
https://github.com/simonw/datasette/issues/417#issuecomment-586599424 | https://api.github.com/repos/simonw/datasette/issues/417 | 586599424 | MDEyOklzc3VlQ29tbWVudDU4NjU5OTQyNA== | 82988 | 2020-02-15T15:12:19Z | 2020-02-15T15:12:33Z | CONTRIBUTOR | So could the polling support also allow you to call sqlite_utils to update a database with csv files? (Though I'm guessing you would only want to handle changed files? Do your scrapers check and cache csv datestamps/hashes?) | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
421546944 |