github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/676#issuecomment-590113889 | https://api.github.com/repos/simonw/datasette/issues/676 | 590113889 | MDEyOklzc3VlQ29tbWVudDU5MDExMzg4OQ== | 9599 | 2020-02-23T20:44:11Z | 2020-02-23T20:44:11Z | OWNER | Still needs documentation before I can land it in master. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
568091133 | |
https://github.com/simonw/datasette/issues/676#issuecomment-590113869 | https://api.github.com/repos/simonw/datasette/issues/676 | 590113869 | MDEyOklzc3VlQ29tbWVudDU5MDExMzg2OQ== | 9599 | 2020-02-23T20:43:59Z | 2020-02-23T20:43:59Z | OWNER | You can try this right now like so: pip install https://github.com/simonw/datasette/archive/search-raw.zip Then use the following: ?_search=foo*&_searchmode=raw` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
568091133 | |
https://github.com/simonw/datasette/issues/676#issuecomment-590110086 | https://api.github.com/repos/simonw/datasette/issues/676 | 590110086 | MDEyOklzc3VlQ29tbWVudDU5MDExMDA4Ng== | 9599 | 2020-02-23T20:06:03Z | 2020-02-23T20:06:52Z | OWNER | Nice thing about the "search mode" concept is that I can optionally reflect it in the HTML UI in some way - maybe with a checkbox for "raw" mode that only shows up if the user hits the page with `?_searchmode=raw` in the querystring. It also hints at potentially adding further search modes in the future. Not sure if I'd do that but it's an interesting potential avenue to explore. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
568091133 | |
https://github.com/simonw/datasette/issues/676#issuecomment-590109778 | https://api.github.com/repos/simonw/datasette/issues/676 | 590109778 | MDEyOklzc3VlQ29tbWVudDU5MDEwOTc3OA== | 9599 | 2020-02-23T20:02:28Z | 2020-02-23T20:02:28Z | OWNER | `?_search_raw=` doesn't work because it clashes with an existing feature - you can use `?_search_colname=` to search just within a specific column, and there could possibly be a column called `raw`. I could go with `?_searchraw=` - or maybe have an additional "mode" selection like `?_search=foo*&_searchmode=raw` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
568091133 | |
https://github.com/simonw/datasette/issues/676#issuecomment-590109450 | https://api.github.com/repos/simonw/datasette/issues/676 | 590109450 | MDEyOklzc3VlQ29tbWVudDU5MDEwOTQ1MA== | 9599 | 2020-02-23T19:59:11Z | 2020-02-23T19:59:11Z | OWNER | I'm going to call it `?_search_raw=` because it will pass through the value as a raw (unprocessed) argument to SQLite FTS, which means it will expose features other than just wildcards: https://www.sqlite.org/fts5.html#full_text_query_syntax | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
568091133 | |
https://github.com/simonw/datasette/issues/681#issuecomment-590107843 | https://api.github.com/repos/simonw/datasette/issues/681 | 590107843 | MDEyOklzc3VlQ29tbWVudDU5MDEwNzg0Mw== | 9599 | 2020-02-23T19:42:15Z | 2020-02-23T19:42:15Z | OWNER | Those security headers from your screenshot are definitely worth me thinking more about. Even if not as core features they could make a great officially supported plugin. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
569317377 | |
https://github.com/simonw/datasette/issues/681#issuecomment-590107464 | https://api.github.com/repos/simonw/datasette/issues/681 | 590107464 | MDEyOklzc3VlQ29tbWVudDU5MDEwNzQ2NA== | 9599 | 2020-02-23T19:38:16Z | 2020-02-23T19:38:16Z | OWNER | The `default_cache_ttl` config currently only takes effect for databases that are loaded in immutable mode using `-i database.db`: https://datasette.readthedocs.io/en/stable/performance.html#immutable-mode | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
569317377 | |
https://github.com/simonw/datasette/issues/681#issuecomment-590107309 | https://api.github.com/repos/simonw/datasette/issues/681 | 590107309 | MDEyOklzc3VlQ29tbWVudDU5MDEwNzMwOQ== | 9599 | 2020-02-23T19:36:33Z | 2020-02-23T19:36:33Z | OWNER | For adding extra HTTP headers I suggest writing a plugin. There's an example in the docs of one that adds a simple HTTP header here: https://datasette.readthedocs.io/en/stable/plugins.html#asgi-wrapper-datasette You don't need to bundle it up as a full Python package - you can create a `plugins/add_headers.py` file and run Datasette with `--plugins-dir=plugins/`: https://datasette.readthedocs.io/en/stable/plugins.html#writing-plugins | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
569317377 | |
https://github.com/simonw/datasette/issues/680#issuecomment-590106416 | https://api.github.com/repos/simonw/datasette/issues/680 | 590106416 | MDEyOklzc3VlQ29tbWVudDU5MDEwNjQxNg== | 9599 | 2020-02-23T19:26:40Z | 2020-02-23T19:26:40Z | OWNER | I think this should go a step further: I'd like some extra tests that run when a new build is being shipped and confirm that it has release notes in the right place. So this is a Travis CI responsibility. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
569275763 | |
https://github.com/simonw/datasette/issues/680#issuecomment-590030425 | https://api.github.com/repos/simonw/datasette/issues/680 | 590030425 | MDEyOklzc3VlQ29tbWVudDU5MDAzMDQyNQ== | 9599 | 2020-02-23T05:53:48Z | 2020-02-23T05:53:48Z | OWNER | For the actual implementation: I think this is a GitHub Action. It looks for new tags, and when a tag is created it builds the docs using Sphinx, extracts the latest HTML changelog entry using BeautifulSoup, cleans it up a bit (I think the only thing that needs doing is turning relative links into absolute ones), runs it through pypandoc to create `gfm`, then uses the GitHub releases API to post the changelog as a release. https://developer.github.com/v3/repos/releases/#create-a-release | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
569275763 | |
https://github.com/simonw/datasette/issues/680#issuecomment-590030258 | https://api.github.com/repos/simonw/datasette/issues/680 | 590030258 | MDEyOklzc3VlQ29tbWVudDU5MDAzMDI1OA== | 9599 | 2020-02-23T05:51:04Z | 2020-02-23T05:51:04Z | OWNER | Did a bunch of research in a Jupyter notebook and it looks like I can use `pypandoc` to achieve this conversion without too much trouble: https://gist.github.com/simonw/41d56712427e6a4178fc6495d664005f | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
569275763 |