github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/713#issuecomment-608062899 | https://api.github.com/repos/simonw/datasette/issues/713 | 608062899 | MDEyOklzc3VlQ29tbWVudDYwODA2Mjg5OQ== | 9599 | 2020-04-02T19:36:17Z | 2020-04-02T19:36:17Z | OWNER | Documentation: https://datasette.readthedocs.io/en/latest/metadata.html#using-yaml-for-metadata | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
592829135 | |
https://github.com/simonw/datasette/issues/713#issuecomment-608062703 | https://api.github.com/repos/simonw/datasette/issues/713 | 608062703 | MDEyOklzc3VlQ29tbWVudDYwODA2MjcwMw== | 9599 | 2020-04-02T19:35:53Z | 2020-04-02T19:35:53Z | OWNER | https://github.com/simonw/datasette/blob/6717c719dd36dc2adc0f9da38a8c8e08129e96b4/datasette/utils/__init__.py#L795-L803 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
592829135 | |
https://github.com/simonw/datasette/issues/713#issuecomment-608023877 | https://api.github.com/repos/simonw/datasette/issues/713 | 608023877 | MDEyOklzc3VlQ29tbWVudDYwODAyMzg3Nw== | 9599 | 2020-04-02T18:18:29Z | 2020-04-02T18:19:43Z | OWNER | Don't forget to fix the code in publish that loads and modifies metadata, e.g.: https://github.com/simonw/datasette/blob/2aaad72789c427875426673c1a43e67c86fc970e/datasette/utils/__init__.py#L361-L367 And: https://github.com/simonw/datasette/blob/2aaad72789c427875426673c1a43e67c86fc970e/datasette/publish/heroku.py#L156-L168 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
592829135 | |
https://github.com/simonw/datasette/issues/713#issuecomment-608022801 | https://api.github.com/repos/simonw/datasette/issues/713 | 608022801 | MDEyOklzc3VlQ29tbWVudDYwODAyMjgwMQ== | 9599 | 2020-04-02T18:16:23Z | 2020-04-02T18:16:23Z | OWNER | I'm going to try to parse as JSON first, then fall back to YAML, then error. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
592829135 | |
https://github.com/simonw/datasette/issues/713#issuecomment-608021760 | https://api.github.com/repos/simonw/datasette/issues/713 | 608021760 | MDEyOklzc3VlQ29tbWVudDYwODAyMTc2MA== | 9599 | 2020-04-02T18:14:20Z | 2020-04-02T18:14:58Z | OWNER | I'm going to depend on ~=5.3 https://github.com/yaml/pyyaml/blob/master/CHANGES - though I could probably depend on a much wider set of versions (or maybe even no pinned minimum version at all). | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
592829135 | |
https://github.com/simonw/datasette/issues/713#issuecomment-608020485 | https://api.github.com/repos/simonw/datasette/issues/713 | 608020485 | MDEyOklzc3VlQ29tbWVudDYwODAyMDQ4NQ== | 9599 | 2020-04-02T18:11:53Z | 2020-04-02T18:11:53Z | OWNER | I can add https://pypi.org/project/PyYAML/ as a dependency for this. One open question: how best to tell the difference between a JSON and a YAML file? I'd rather not do it based on a file extension. Since I'm going to read the whole file into memory anyway (rather than try to stream it) and I only load it once at startup, maybe I try to parse with one and, if there's a parsing error, try the other one before giving up? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
592829135 |