github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/797#issuecomment-638301073 | https://api.github.com/repos/simonw/datasette/issues/797 | 638301073 | MDEyOklzc3VlQ29tbWVudDYzODMwMTA3Mw== | 9599 | 2020-06-03T16:14:54Z | 2020-06-09T04:00:40Z | OWNER | I want a unit test that exercises this for both writable and regular canned queries. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
630120235 | |
https://github.com/simonw/datasette/issues/793#issuecomment-638462052 | https://api.github.com/repos/simonw/datasette/issues/793 | 638462052 | MDEyOklzc3VlQ29tbWVudDYzODQ2MjA1Mg== | 9599 | 2020-06-03T21:07:39Z | 2020-06-03T21:07:39Z | OWNER | I need to land and release the fix for signing cookies in https://github.com/simonw/asgi-csrf/issues/2 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
629524205 | |
https://github.com/simonw/datasette/issues/797#issuecomment-638461797 | https://api.github.com/repos/simonw/datasette/issues/797 | 638461797 | MDEyOklzc3VlQ29tbWVudDYzODQ2MTc5Nw== | 9599 | 2020-06-03T21:07:06Z | 2020-06-03T21:07:06Z | OWNER | Docs here (search for "params"): https://datasette.readthedocs.io/en/latest/sql_queries.html#canned-queries-named-parameters | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
630120235 | |
https://github.com/simonw/datasette/issues/797#issuecomment-638289878 | https://api.github.com/repos/simonw/datasette/issues/797 | 638289878 | MDEyOklzc3VlQ29tbWVudDYzODI4OTg3OA== | 9599 | 2020-06-03T15:57:47Z | 2020-06-03T15:57:47Z | OWNER | Also mention ability to pre-fill the form for writable canned queries using the querystring. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
630120235 | |
https://github.com/simonw/datasette/issues/698#issuecomment-638266171 | https://api.github.com/repos/simonw/datasette/issues/698 | 638266171 | MDEyOklzc3VlQ29tbWVudDYzODI2NjE3MQ== | 9599 | 2020-06-03T15:18:49Z | 2020-06-03T15:18:49Z | OWNER | Landed the work so far from #796! Here's the documentation: https://datasette.readthedocs.io/en/latest/sql_queries.html#writable-canned-queries | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
582517965 | |
https://github.com/simonw/datasette/issues/793#issuecomment-638265394 | https://api.github.com/repos/simonw/datasette/issues/793 | 638265394 | MDEyOklzc3VlQ29tbWVudDYzODI2NTM5NA== | 9599 | 2020-06-03T15:17:35Z | 2020-06-03T15:17:51Z | OWNER | I need this for writable canned queries in #698 and #796 too. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
629524205 | |
https://github.com/simonw/datasette/pull/796#issuecomment-638257697 | https://api.github.com/repos/simonw/datasette/issues/796 | 638257697 | MDEyOklzc3VlQ29tbWVudDYzODI1NzY5Nw== | 9599 | 2020-06-03T15:05:07Z | 2020-06-03T15:05:07Z | OWNER | I'm going to document this, land it and then continue to work on the other pieces - CSRF protection and .json mode - in separate tickets. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
629595228 | |
https://github.com/simonw/datasette/pull/796#issuecomment-638249652 | https://api.github.com/repos/simonw/datasette/issues/796 | 638249652 | MDEyOklzc3VlQ29tbWVudDYzODI0OTY1Mg== | 9599 | 2020-06-03T14:51:29Z | 2020-06-03T14:51:51Z | OWNER | Consider this one: ``` "delete_name": { "sql": "delete from names where rowid = :rowid", "write": True, "on_success_message": "Name deleted", }, ``` If the user enters an invalid `rowid` the query will still execute without errors and hence the success message will still be displayed. Can I address this? Maybe allow an optional `"rowcount_expected": 1` property? And if that count isn't matched treat the query as an error. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
629595228 | |
https://github.com/simonw/datasette/pull/796#issuecomment-638241738 | https://api.github.com/repos/simonw/datasette/issues/796 | 638241738 | MDEyOklzc3VlQ29tbWVudDYzODI0MTczOA== | 9599 | 2020-06-03T14:38:45Z | 2020-06-03T14:38:45Z | OWNER | Violating a unique constraint will throw an error. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
629595228 | |
https://github.com/simonw/datasette/pull/796#issuecomment-638241366 | https://api.github.com/repos/simonw/datasette/issues/796 | 638241366 | MDEyOklzc3VlQ29tbWVudDYzODI0MTM2Ng== | 9599 | 2020-06-03T14:38:03Z | 2020-06-03T14:38:31Z | OWNER | Maybe I need some kind of optional validation mechanism? SQLite lets me insert text or floating point numbers into integer columns right now, which feels wrong. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
629595228 | |
https://github.com/simonw/datasette/pull/796#issuecomment-638240919 | https://api.github.com/repos/simonw/datasette/issues/796 | 638240919 | MDEyOklzc3VlQ29tbWVudDYzODI0MDkxOQ== | 9599 | 2020-06-03T14:37:22Z | 2020-06-03T14:37:22Z | OWNER | I'm having trouble coming up with a canned SQL query that will only error with certain parameters, which I need in order to test out the `on_error_redirect` and `on_error_message` properties. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
629595228 | |
https://github.com/simonw/datasette/pull/796#issuecomment-638238144 | https://api.github.com/repos/simonw/datasette/issues/796 | 638238144 | MDEyOklzc3VlQ29tbWVudDYzODIzODE0NA== | 9599 | 2020-06-03T14:32:54Z | 2020-06-03T14:33:11Z | OWNER | I'm going to have `on_success_redirect` and `on_error_redirect` properties for specifying where the redirect should go too. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
629595228 | |
https://github.com/simonw/datasette/pull/796#issuecomment-638188196 | https://api.github.com/repos/simonw/datasette/issues/796 | 638188196 | MDEyOklzc3VlQ29tbWVudDYzODE4ODE5Ng== | 9599 | 2020-06-03T13:13:27Z | 2020-06-03T14:32:27Z | OWNER | "Query executed" is the default message, but it's pretty bland: <img width="805" alt="data__insert_into_names__name__values___name_" src="https://user-images.githubusercontent.com/9599/83640640-42d6b700-a561-11ea-9ed4-fe7815d24df2.png"> How about letting queries define custom success messages in their metadata configuration? `"on_success_message"` and `"on_error_message"` How can the system tell if an "update" query was actually successful? Maybe I should expose `.rowcount` somehow, so I can report back on how many rows were updated. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
629595228 | |
https://github.com/simonw/datasette/pull/796#issuecomment-638206851 | https://api.github.com/repos/simonw/datasette/issues/796 | 638206851 | MDEyOklzc3VlQ29tbWVudDYzODIwNjg1MQ== | 9599 | 2020-06-03T13:44:29Z | 2020-06-03T13:44:29Z | OWNER | Default message is now "Query executed, 1 row affected" as of https://github.com/simonw/datasette/pull/796/commits/f45c44ac8f3a9a2182d76c6bda44a06676499e4b | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
629595228 | |
https://github.com/simonw/datasette/pull/796#issuecomment-638205923 | https://api.github.com/repos/simonw/datasette/issues/796 | 638205923 | MDEyOklzc3VlQ29tbWVudDYzODIwNTkyMw== | 9599 | 2020-06-03T13:43:12Z | 2020-06-03T13:43:12Z | OWNER | For `.json` mode (when the URL has a `.json` suffix) I'm going to handle both form-encoded and JSON encoded inputs and return a 200 status code with JSON that tells you if the query executed successfully and how many rows were affected. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
629595228 | |
https://github.com/simonw/datasette/issues/698#issuecomment-638183337 | https://api.github.com/repos/simonw/datasette/issues/698 | 638183337 | MDEyOklzc3VlQ29tbWVudDYzODE4MzMzNw== | 9599 | 2020-06-03T13:05:03Z | 2020-06-03T13:05:03Z | OWNER | One challenge with this feature is that it confuses the messaging about what Datasette does somewhat. Prior to shipping this, Datasette's core value proposition is as a way to publish read-only data. That changed a little [in 0.37 in February](https://datasette.readthedocs.io/en/stable/changelog.html#v0-37) when plugins gained the supported ability to execute writes, but there was no way of doing that without a plugin. With this feature, Datasette becomes a read-write database solution. I should update the documentation to help explain this. Essentially the message is that Datasette can be used in one of two "modes" - it can be used just for sharing/publishing data, or you can use it to collect and manage data, most likely still in collaboration with plugins for things like authentication. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
582517965 | |
https://github.com/simonw/datasette/issues/698#issuecomment-637934813 | https://api.github.com/repos/simonw/datasette/issues/698 | 637934813 | MDEyOklzc3VlQ29tbWVudDYzNzkzNDgxMw== | 9599 | 2020-06-03T03:45:07Z | 2020-06-03T03:45:07Z | OWNER | Some extra thoughts now that this is mostly working: - "Edit this row" is such an obvious use-case. Could I automatically support row editing where every column except the primary key can be updated? - It would be useful to be able to link to a query in a way that pre-populates various form fields. The "edit" interface could then be a link that pre-populates the form with all of the existing values. - Can the redirect URL be configured to include values from the form submission? So you could e.g. add a blog post with a unique slug and then redirect to that URL? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
582517965 | |
https://github.com/simonw/datasette/issues/698#issuecomment-637879242 | https://api.github.com/repos/simonw/datasette/issues/698 | 637879242 | MDEyOklzc3VlQ29tbWVudDYzNzg3OTI0Mg== | 9599 | 2020-06-03T00:10:30Z | 2020-06-03T00:10:30Z | OWNER | Started a fresh pull request for this in #796 - the one in #703 got a bit untidy. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
582517965 |