github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/859#issuecomment-647194131 | https://api.github.com/repos/simonw/datasette/issues/859 | 647194131 | MDEyOklzc3VlQ29tbWVudDY0NzE5NDEzMQ== | 3243482 | 2020-06-21T23:15:54Z | 2020-06-21T23:26:09Z | CONTRIBUTOR | I'm not sure if table counts are to blame. There shouldn't be a ~3 orders of magnitude difference. ```fish user@klein /a/w/scrapyard (master)> set sql "select count(*) from table_1; select count(*) from table_2; select count(*) from table_3;" user@klein /a/w/scrapyard (master)> time sqlite3 scrapyard.db "$sql" 187489 46492 2229 ________________________________________________________ Executed in 25.57 millis fish external usr time 3.55 millis 0.00 micros 3.55 millis sys time 22.42 millis 1123.00 micros 21.30 millis ``` but not letting datasette count the tables definitely helps. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
642572841 | |
https://github.com/simonw/datasette/issues/687#issuecomment-647190177 | https://api.github.com/repos/simonw/datasette/issues/687 | 647190177 | MDEyOklzc3VlQ29tbWVudDY0NzE5MDE3Nw== | 9599 | 2020-06-21T22:32:36Z | 2020-06-21T22:32:36Z | OWNER | I'm going to break out the plugin hooks first in a single commit to make for a cleaner commit history (since that way git can hopefully detect that the content moved). | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
572896293 | |
https://github.com/simonw/datasette/issues/687#issuecomment-647190144 | https://api.github.com/repos/simonw/datasette/issues/687 | 647190144 | MDEyOklzc3VlQ29tbWVudDY0NzE5MDE0NA== | 9599 | 2020-06-21T22:32:13Z | 2020-06-21T22:32:13Z | OWNER | So the new plan is NOT to have a `plugins/` folder, but instead have several top-level pages: - Plugins (exists) - Writing plugins - Plugin hooks - Testing plugins - Internals for plugins (exists) | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
572896293 | |
https://github.com/simonw/datasette/issues/859#issuecomment-647189948 | https://api.github.com/repos/simonw/datasette/issues/859 | 647189948 | MDEyOklzc3VlQ29tbWVudDY0NzE4OTk0OA== | 9599 | 2020-06-21T22:30:12Z | 2020-06-21T22:30:43Z | OWNER | I'll write a little script which generates a 300MB SQLite file with a bunch of tables with lots of randomly generated rows in to help test this. Having a tool like that which can generate larger databases with different gnarly performance characteristics will be useful for other performance work too. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
642572841 | |
https://github.com/simonw/datasette/issues/859#issuecomment-647189666 | https://api.github.com/repos/simonw/datasette/issues/859 | 647189666 | MDEyOklzc3VlQ29tbWVudDY0NzE4OTY2Ng== | 9599 | 2020-06-21T22:26:55Z | 2020-06-21T22:26:55Z | OWNER | This makes a lot of sense. I implemented the mechanism for the index page because I have my own instance of Datasette that was running slow, but it had a dozen database files attached to it. I've not run into this with a single giant database file but it absolutely makes sense that the same optimization would be necessary for the database page there too. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
642572841 | |
https://github.com/simonw/datasette/issues/860#issuecomment-647189535 | https://api.github.com/repos/simonw/datasette/issues/860 | 647189535 | MDEyOklzc3VlQ29tbWVudDY0NzE4OTUzNQ== | 9599 | 2020-06-21T22:25:16Z | 2020-06-21T22:25:27Z | OWNER | This is also relevant to #639, and may mean I can close that ticket in place of this one. I'm going to get this at least to a proof-of-concept stage first though. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
642651572 | |
https://github.com/simonw/datasette/issues/357#issuecomment-647189045 | https://api.github.com/repos/simonw/datasette/issues/357 | 647189045 | MDEyOklzc3VlQ29tbWVudDY0NzE4OTA0NQ== | 9599 | 2020-06-21T22:19:58Z | 2020-06-21T22:19:58Z | OWNER | I'm going to take this in a different direction. I'm not happy with how `metadata.(json|yaml)` keeps growing new features. Rather than having a single plugin hook for all of `metadata.json` I'm going to split out the feature that shows actual real metadata for tables and databases - `source`, `license` etc - into its own plugin-powered mechanism. So I'm going to close this ticket and spin up a new one for that. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
348043884 | |
https://github.com/simonw/datasette/issues/859#issuecomment-647135713 | https://api.github.com/repos/simonw/datasette/issues/859 | 647135713 | MDEyOklzc3VlQ29tbWVudDY0NzEzNTcxMw== | 3243482 | 2020-06-21T14:30:02Z | 2020-06-21T14:30:02Z | CONTRIBUTOR | Oops, the same method is called from both index and database pages. But removing select count queries speed up the page load quite a bit. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
642572841 |