github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/900#issuecomment-667431123 | https://api.github.com/repos/simonw/datasette/issues/900 | 667431123 | MDEyOklzc3VlQ29tbWVudDY2NzQzMTEyMw== | 9599 | 2020-07-31T23:56:33Z | 2020-07-31T23:56:33Z | OWNER | I think this is the same issue as #865. I'll look at these together! | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
661605489 | |
https://github.com/simonw/datasette/issues/899#issuecomment-667430790 | https://api.github.com/repos/simonw/datasette/issues/899 | 667430790 | MDEyOklzc3VlQ29tbWVudDY2NzQzMDc5MA== | 9599 | 2020-07-31T23:54:40Z | 2020-07-31T23:54:40Z | OWNER | There's no mechanism that can do this at the moment. You could absolutely support this with a plugin, probably using the `asgi_wrapper` plugin hook. There's an existing package at https://pypi.org/project/asgi-ratelimit/ which may be usable for this - it may even be possible to configure that using https://github.com/simonw/datasette-configure-asgi rather than using it to write a custom plugin. Using a separate revers proxy would also be a good way to solve this. It depends which option would work best in your environment. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
660827546 | |
https://github.com/simonw/datasette/issues/913#issuecomment-667430352 | https://api.github.com/repos/simonw/datasette/issues/913 | 667430352 | MDEyOklzc3VlQ29tbWVudDY2NzQzMDM1Mg== | 9599 | 2020-07-31T23:52:10Z | 2020-07-31T23:52:10Z | OWNER | The bigger question here is when this mechanism should be used in place of `metadata.json` or `metadata.yml`. Especially since I'm already considering renaming or reworking that mechanism since plugin configuration has nothing to do with database metadata: #493 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
670209331 | |
https://github.com/simonw/datasette/issues/913#issuecomment-667429616 | https://api.github.com/repos/simonw/datasette/issues/913 | 667429616 | MDEyOklzc3VlQ29tbWVudDY2NzQyOTYxNg== | 9599 | 2020-07-31T23:48:25Z | 2020-07-31T23:49:59Z | OWNER | I could let plugins add additional options to `datasette serve` - but what if two plugins both try to register an option with the same name? A better solution could be to use the existing `--config` option - and allow plugins to register their own, namespaced config options. So you could do things like: datasette my.db --config datasette-insert:unsafe:1 Maybe even drop the `datasette-` prefix? datasette my.db --config insert:unsafe:1 I think I prefer keeping the prefix to be honest - it makes it more obvious that this is a setting which comes from a specific named plugin. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
670209331 | |
https://github.com/simonw/datasette/issues/913#issuecomment-667429690 | https://api.github.com/repos/simonw/datasette/issues/913 | 667429690 | MDEyOklzc3VlQ29tbWVudDY2NzQyOTY5MA== | 9599 | 2020-07-31T23:48:48Z | 2020-07-31T23:48:48Z | OWNER | Here's the code in Datasette that parses `--config` options at the moment: https://github.com/simonw/datasette/blob/7ca8c0521ac1ea48a3cd8d0fe9275d1316e54b43/datasette/cli.py#L25-L40 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
670209331 | |
https://github.com/simonw/datasette/issues/849#issuecomment-667424128 | https://api.github.com/repos/simonw/datasette/issues/849 | 667424128 | MDEyOklzc3VlQ29tbWVudDY2NzQyNDEyOA== | 9599 | 2020-07-31T23:21:56Z | 2020-07-31T23:23:24Z | OWNER | I'm going to change the default branch on the GitHub repository. If something breaks I can always change it back again. Done that! Default is now `main`. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
639072811 | |
https://github.com/simonw/datasette/issues/849#issuecomment-667424020 | https://api.github.com/repos/simonw/datasette/issues/849 | 667424020 | MDEyOklzc3VlQ29tbWVudDY2NzQyNDAyMA== | 9599 | 2020-07-31T23:21:30Z | 2020-07-31T23:21:30Z | OWNER | https://github.com/simonw/datasette/tree/main branch now exists and will automatically mirror master (and vice-versa). | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
639072811 | |
https://github.com/simonw/datasette/issues/849#issuecomment-667295759 | https://api.github.com/repos/simonw/datasette/issues/849 | 667295759 | MDEyOklzc3VlQ29tbWVudDY2NzI5NTc1OQ== | 9599 | 2020-07-31T18:45:35Z | 2020-07-31T18:45:35Z | OWNER | Watch out for places in the documentation that might link to `master` - e.g. here: https://github.com/simonw/datasette/blob/2d7fa8b9058dfbf9c7c371cdeec115d32a177dc9/docs/custom_templates.rst#L247 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
639072811 |