github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/928#issuecomment-672373061 | https://api.github.com/repos/simonw/datasette/issues/928 | 672373061 | MDEyOklzc3VlQ29tbWVudDY3MjM3MzA2MQ== | 9599 | 2020-08-11T23:56:19Z | 2020-08-11T23:56:19Z | OWNER | New implementation of the `install` command: https://github.com/simonw/datasette/blob/afdeda8216d4d3027f87583ccdbef17ad85022ef/datasette/cli.py#L235-L240 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
677272618 | |
https://github.com/simonw/datasette/issues/928#issuecomment-672372465 | https://api.github.com/repos/simonw/datasette/issues/928 | 672372465 | MDEyOklzc3VlQ29tbWVudDY3MjM3MjQ2NQ== | 9599 | 2020-08-11T23:54:28Z | 2020-08-11T23:54:28Z | OWNER | While debugging this I found a useful clue in https://github.com/pypa/pip/blob/e060970d51c5946beac8447eb95585d83019582d/src/pip/_internal/cli/main.py#L23-L47 ``` # Do not import and use main() directly! Using it directly is actively # discouraged by pip's maintainers. The name, location and behavior of # this function is subject to change, so calling it directly is not # portable across different pip versions. # In addition, running pip in-process is unsupported and unsafe. This is # elaborated in detail at # https://pip.pypa.io/en/stable/user_guide/#using-pip-from-your-program. # That document also provides suggestions that should work for nearly # all users that are considering importing and using main() directly. # However, we know that certain users will still want to invoke pip # in-process. If you understand and accept the implications of using pip # in an unsupported manner, the best approach is to use runpy to avoid # depending on the exact location of this entry point. # The following example shows how to use runpy to invoke pip in that # case: # # sys.argv = ["pip", your, args, here] # runpy.run_module("pip", run_name="__main__") # # Note that this will exit the process after running, unlike a direct # call to main. As it is not safe to do any processing after calling # main, this should not be an issue in practice. ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
677272618 | |
https://github.com/simonw/datasette/issues/928#issuecomment-672372197 | https://api.github.com/repos/simonw/datasette/issues/928 | 672372197 | MDEyOklzc3VlQ29tbWVudDY3MjM3MjE5Nw== | 9599 | 2020-08-11T23:53:38Z | 2020-08-11T23:53:38Z | OWNER | Caused by the tests for #925 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
677272618 | |
https://github.com/simonw/datasette/pull/927#issuecomment-672357176 | https://api.github.com/repos/simonw/datasette/issues/927 | 672357176 | MDEyOklzc3VlQ29tbWVudDY3MjM1NzE3Ng== | 9599 | 2020-08-11T23:32:08Z | 2020-08-11T23:33:09Z | OWNER | Needs documentation and tests. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
677265716 | |
https://github.com/simonw/datasette/pull/927#issuecomment-672357902 | https://api.github.com/repos/simonw/datasette/issues/927 | 672357902 | MDEyOklzc3VlQ29tbWVudDY3MjM1NzkwMg== | 9599 | 2020-08-11T23:32:39Z | 2020-08-11T23:32:39Z | OWNER | It works: ``` $ datasette --get '/:memory:.json?sql=select * from sqlite_master' | jq . { "database": ":memory:", "query_name": null, "rows": [], "truncated": false, "columns": [ "type", "name", "tbl_name", "rootpage", "sql" ], "query": { "sql": "select * from sqlite_master", "params": {} }, "private": false, "allow_execute_sql": true, "query_ms": 0.8032321929931641 } ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
677265716 | |
https://github.com/simonw/datasette/issues/926#issuecomment-672338113 | https://api.github.com/repos/simonw/datasette/issues/926 | 672338113 | MDEyOklzc3VlQ29tbWVudDY3MjMzODExMw== | 9599 | 2020-08-11T22:57:28Z | 2020-08-11T22:57:28Z | OWNER | I partly want this so I can easily implement a better `test` method for the Homebrew package. The test I have right now looks like this: https://github.com/simonw/homebrew-datasette/blob/8aa30aa183158051a987a7e3f50e7e3ee05d8ee9/Formula/datasette.rb#L125-L127 ``` test do system bin/"datasette", "--help" end ``` The Homebrew docs at https://docs.brew.sh/Formula-Cookbook#add-a-test-to-the-formula say: > We want tests that don't require any user input and test the basic functionality of the application. For example `foo build-foo input.foo` is a good test and (despite their widespread use) `foo --version` and `foo --help` are bad tests. However, a bad test is better than no test at all. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
677250834 | |
https://github.com/simonw/datasette/issues/923#issuecomment-672336720 | https://api.github.com/repos/simonw/datasette/issues/923 | 672336720 | MDEyOklzc3VlQ29tbWVudDY3MjMzNjcyMA== | 9599 | 2020-08-11T22:53:07Z | 2020-08-11T22:53:07Z | OWNER | https://github.com/simonw/datasette/blob/5126ecb1267ed3850bf3b0ab270accd031a02e79/docs/installation.rst#using-homebrew | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
677037043 | |
https://github.com/simonw/datasette/issues/923#issuecomment-672329101 | https://api.github.com/repos/simonw/datasette/issues/923 | 672329101 | MDEyOklzc3VlQ29tbWVudDY3MjMyOTEwMQ== | 9599 | 2020-08-11T22:35:13Z | 2020-08-11T22:35:13Z | OWNER | I added the `datasette install name-of-plugin` command in #925 mainly to simplify the process of installing plugins if Datasette itself was installed using homebrew. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
677037043 | |
https://github.com/simonw/datasette/issues/925#issuecomment-672328807 | https://api.github.com/repos/simonw/datasette/issues/925 | 672328807 | MDEyOklzc3VlQ29tbWVudDY3MjMyODgwNw== | 9599 | 2020-08-11T22:34:37Z | 2020-08-11T22:34:37Z | OWNER | This will simplify the instructions for installing plugins with Datasette install via homebrew, refs #923 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
677227912 | |
https://github.com/simonw/datasette/issues/925#issuecomment-672328436 | https://api.github.com/repos/simonw/datasette/issues/925 | 672328436 | MDEyOklzc3VlQ29tbWVudDY3MjMyODQzNg== | 9599 | 2020-08-11T22:33:32Z | 2020-08-11T22:33:42Z | OWNER | ``` $ datasette install --help Usage: datasette install [OPTIONS] PACKAGES... Install Python packages - e.g. Datasette plugins - into the same environment as Datasette Options: --help Show this message and exit. $ datasette uninstall --help Usage: datasette uninstall [OPTIONS] PACKAGES... Uninstall Python packages (e.g. plugins) from the Datasette environment Options: -y, --yes Don't ask for confirmation --help Show this message and exit. ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
677227912 | |
https://github.com/simonw/datasette/issues/925#issuecomment-672304650 | https://api.github.com/repos/simonw/datasette/issues/925 | 672304650 | MDEyOklzc3VlQ29tbWVudDY3MjMwNDY1MA== | 9599 | 2020-08-11T22:04:48Z | 2020-08-11T22:04:48Z | OWNER | Prototyped in this thread: https://github.com/simonw/datasette/issues/335#issuecomment-671005731 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
677227912 | |
https://github.com/simonw/datasette/issues/923#issuecomment-672288845 | https://api.github.com/repos/simonw/datasette/issues/923 | 672288845 | MDEyOklzc3VlQ29tbWVudDY3MjI4ODg0NQ== | 9599 | 2020-08-11T21:28:17Z | 2020-08-11T21:28:17Z | OWNER | Here's a pattern for installing plugins: ``` $ datasette plugins [] $ /usr/local/opt/datasette/libexec/bin/pip install datasette-vega Collecting datasette-vega Using cached datasette_vega-0.6.2-py3-none-any.whl (1.8 MB) Requirement already satisfied: datasette in /usr/local/Cellar/datasette/0.46/libexec/lib/python3.8/site-packages (from datasette-vega) (0.46) Requirement already satisfied: click~=7.1.1 in /usr/local/Cellar/datasette/0.46/libexec/lib/python3.8/site-packages (from datasette->datasette-vega) (7.1.2) Requirement already satisfied: click-default-group~=1.2.2 in /usr/local/Cellar/datasette/0.46/libexec/lib/python3.8/site-packages (from datasette->datasette-vega) (1.2.2) Requirement already satisfied: Jinja2<2.12.0,>=2.10.3 in /usr/local/Cellar/datasette/0.46/libexec/lib/python3.8/site-packages (from datasette->datasette-vega) (2.11.2) Requirement already satisfied: hupper~=1.9 in /usr/local/Cellar/datasette/0.46/libexec/lib/python3.8/site-packages (from datasette->datasette-vega) (1.10.2) Requirement already satisfied: pint~=0.9 in /usr/local/Cellar/datasette/0.46/libexec/lib/python3.8/site-packages (from datasette->datasette-vega) (0.14) Requirement already satisfied: pluggy~=0.13.0 in /usr/local/Cellar/datasette/0.46/libexec/lib/python3.8/site-packages (from datasette->datasette-vega) (0.13.1) Requirement already satisfied: uvicorn~=0.11 in /usr/local/Cellar/datasette/0.46/libexec/lib/python3.8/site-packages (from datasette->datasette-vega) (0.11.8) Requirement already satisfied: aiofiles<0.6,>=0.4 in /usr/local/Cellar/datasette/0.46/libexec/lib/python3.8/site-packages (from datasette->datasette-vega) (0.5.0) Requirement already satisfied: janus<0.6,>=0.4 in /usr/local/Cellar/datasette/0.46/libexec/lib/python3.8/site-packages (from datasette->datasette-vega) (0.5.0) Requirement already satisfied: asgi-csrf>=0.6 in /usr/local/Cellar/datasette/0.46/libexec/lib/python3.8/site-packages (from datasette->datasette-vega) (0.6.1) Requirement already satisfied: PyYAML~=5.3 in /usr/local/Ce… | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
677037043 | |
https://github.com/simonw/datasette/issues/923#issuecomment-672287754 | https://api.github.com/repos/simonw/datasette/issues/923 | 672287754 | MDEyOklzc3VlQ29tbWVudDY3MjI4Nzc1NA== | 9599 | 2020-08-11T21:25:33Z | 2020-08-11T21:25:33Z | OWNER | .. and confirm if `brew tap ...` is even needed if you run `brew install simonw/datasette/datasette` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
677037043 | |
https://github.com/simonw/datasette/issues/923#issuecomment-672089281 | https://api.github.com/repos/simonw/datasette/issues/923 | 672089281 | MDEyOklzc3VlQ29tbWVudDY3MjA4OTI4MQ== | 9599 | 2020-08-11T16:54:50Z | 2020-08-11T16:54:50Z | OWNER | Also need to talk about how you install plugins. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
677037043 | |
https://github.com/simonw/datasette/issues/335#issuecomment-672088880 | https://api.github.com/repos/simonw/datasette/issues/335 | 672088880 | MDEyOklzc3VlQ29tbWVudDY3MjA4ODg4MA== | 9599 | 2020-08-11T16:54:06Z | 2020-08-11T16:54:06Z | OWNER | It works! ``` $ brew tap simonw/datasette $ brew install simonw/datasette/datasette $ datasette --version datasette, version 0.46 ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
339505204 | |
https://github.com/simonw/datasette/issues/335#issuecomment-671733187 | https://api.github.com/repos/simonw/datasette/issues/335 | 671733187 | MDEyOklzc3VlQ29tbWVudDY3MTczMzE4Nw== | 9599 | 2020-08-11T05:25:23Z | 2020-08-11T05:25:23Z | OWNER | I got this almost working in `simonw/homebrew-datasette` - see https://github.com/simonw/homebrew-datasette/issues/2 for the last missing detail. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
339505204 |