github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/948#issuecomment-683448569 | https://api.github.com/repos/simonw/datasette/issues/948 | 683448569 | MDEyOklzc3VlQ29tbWVudDY4MzQ0ODU2OQ== | 9599 | 2020-08-30T17:39:09Z | 2020-08-30T18:34:34Z | OWNER | So the steps needed are: - Download and extract latest CodeMirror zip file - Rename `lib/codemirror.js` to `codemirror-5.57.0.js` - Rename `lib/codemirror.css` to `codemirror-5.57.0.css` - Rename `mode/sql/sql.js` to `codemirror-5.57.0-sql.js` - Edit both JS files to make the top comment a `/* */` block - Minify JavaScript files like this: - `npx uglify-js codemirror-5.57.0.js -o codemirror-5.57.0.min.js --comments '/LICENSE/'` - `npx uglify-js codemirror-5.57.0-sql.js -o codemirror-5.57.0-sql.min.js --comments '/LICENSE/'` - Check that the LICENSE comment did indeed survive minification - Minify CSS file like this: - `npx clean-css-cli codemirror-5.57.0.css -o codemirror-5.57.0.min.css` - Edit the `_codemirror.html` template to reference the new files - `git rm` the old files, `git add` the new files | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
684925907 | |
https://github.com/simonw/datasette/issues/948#issuecomment-683452613 | https://api.github.com/repos/simonw/datasette/issues/948 | 683452613 | MDEyOklzc3VlQ29tbWVudDY4MzQ1MjYxMw== | 9599 | 2020-08-30T18:16:28Z | 2020-08-30T18:16:28Z | OWNER | I added documentation on how to upgrade CodeMirror for the future here: https://docs.datasette.io/en/latest/contributing.html#upgrading-codemirror | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
684925907 | |
https://github.com/simonw/datasette/issues/655#issuecomment-683449837 | https://api.github.com/repos/simonw/datasette/issues/655 | 683449837 | MDEyOklzc3VlQ29tbWVudDY4MzQ0OTgzNw== | 9599 | 2020-08-30T17:51:38Z | 2020-08-30T17:51:38Z | OWNER | I think was fixed by #948 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
542553350 | |
https://github.com/simonw/datasette/issues/948#issuecomment-683449804 | https://api.github.com/repos/simonw/datasette/issues/948 | 683449804 | MDEyOklzc3VlQ29tbWVudDY4MzQ0OTgwNA== | 9599 | 2020-08-30T17:51:18Z | 2020-08-30T17:51:18Z | OWNER | Copy and paste on mobile safari seems to work now. #655 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
684925907 | |
https://github.com/simonw/datasette/issues/948#issuecomment-683448635 | https://api.github.com/repos/simonw/datasette/issues/948 | 683448635 | MDEyOklzc3VlQ29tbWVudDY4MzQ0ODYzNQ== | 9599 | 2020-08-30T17:39:54Z | 2020-08-30T17:39:54Z | OWNER | I'll wait for this to deploy to https://latest.datasette.io/ and then test it in various desktop and mobile browsers. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
684925907 | |
https://github.com/simonw/datasette/issues/948#issuecomment-683445704 | https://api.github.com/repos/simonw/datasette/issues/948 | 683445704 | MDEyOklzc3VlQ29tbWVudDY4MzQ0NTcwNA== | 9599 | 2020-08-30T17:11:58Z | 2020-08-30T17:33:30Z | OWNER | One catch: this stripped the license information from the top of the JS. I fixed this by editing the license to be a single `/* ... */` block comment instead of multiple `//` lines and running this: npx uglify-js codemirror-5.57.0.js -o codemirror-5.57.0.min.js --comments '/LICENSE/' | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
684925907 | |
https://github.com/simonw/datasette/issues/948#issuecomment-683445114 | https://api.github.com/repos/simonw/datasette/issues/948 | 683445114 | MDEyOklzc3VlQ29tbWVudDY4MzQ0NTExNA== | 9599 | 2020-08-30T17:06:39Z | 2020-08-30T17:06:39Z | OWNER | Minifying using `npx`: ``` npx uglify-js codemirror-5.57.0.js -o codemirror-5.57.0.min.js npx uglify-js codemirror-5.57.0-sql.js -o codemirror-5.57.0-sql.min.js npx clean-css-cli codemirror-5.57.0.css -o codemirror-5.57.0.min.css ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
684925907 | |
https://github.com/simonw/sqlite-utils/issues/145#issuecomment-683382252 | https://api.github.com/repos/simonw/sqlite-utils/issues/145 | 683382252 | MDEyOklzc3VlQ29tbWVudDY4MzM4MjI1Mg== | 96218 | 2020-08-30T06:27:25Z | 2020-08-30T06:27:52Z | CONTRIBUTOR | Note: had to adjust the test above because trying to exhaust a `SQLITE_MAX_VARIABLE_NUMBER` of 250000 in 99 records requires 2526 columns, and trips the ` "Rows can have a maximum of {} columns".format(SQLITE_MAX_VARS)` check even before it trips the default `SQLITE_MAX_COLUMN` value (2000). | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
688659182 | |
https://github.com/simonw/datasette/issues/957#issuecomment-683357092 | https://api.github.com/repos/simonw/datasette/issues/957 | 683357092 | MDEyOklzc3VlQ29tbWVudDY4MzM1NzA5Mg== | 9599 | 2020-08-30T00:15:51Z | 2020-08-30T00:16:02Z | OWNER | Weirdly even removing this single `datasette` import from `utils/asgi.py` didn't fix the circular import: https://github.com/simonw/datasette/blob/44cf424a94a85b74552075272660bb96a7432661/datasette/utils/asgi.py#L1-L3 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
688622148 | |
https://github.com/simonw/datasette/issues/957#issuecomment-683356440 | https://api.github.com/repos/simonw/datasette/issues/957 | 683356440 | MDEyOklzc3VlQ29tbWVudDY4MzM1NjQ0MA== | 9599 | 2020-08-30T00:08:18Z | 2020-08-30T00:10:26Z | OWNER | Annoyingly this seems to be the line that causes the circular import: ```python from .utils.asgi import Forbidden, NotFound, Response ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
688622148 | |
https://github.com/simonw/datasette/issues/957#issuecomment-683355993 | https://api.github.com/repos/simonw/datasette/issues/957 | 683355993 | MDEyOklzc3VlQ29tbWVudDY4MzM1NTk5Mw== | 9599 | 2020-08-30T00:02:11Z | 2020-08-30T00:04:18Z | OWNER | I tried doing this and got this error: ``` (datasette) datasette % pytest ==================================================================== test session starts ===================================================================== platform darwin -- Python 3.8.5, pytest-6.0.1, py-1.9.0, pluggy-0.13.1 rootdir: /Users/simon/Dropbox/Development/datasette, configfile: pytest.ini plugins: asyncio-0.14.0, timeout-1.4.2 collected 1 item / 23 errors =========================================================================== ERRORS =========================================================================== _____________________________________________________________ ERROR collecting tests/test_api.py _____________________________________________________________ ImportError while importing test module '/Users/simon/Dropbox/Development/datasette/tests/test_api.py'. Hint: make sure your test modules/packages have valid Python names. Traceback: /usr/local/opt/python@3.8/Frameworks/Python.framework/Versions/3.8/lib/python3.8/importlib/__init__.py:127: in import_module return _bootstrap._gcd_import(name[level:], package, level) tests/test_api.py:1: in <module> from datasette.plugins import DEFAULT_PLUGINS datasette/__init__.py:2: in <module> from .app import Datasette datasette/app.py:30: in <module> from .views.base import DatasetteError, ureg datasette/views/base.py:12: in <module> from datasette.plugins import pm datasette/plugins.py:26: in <module> mod = importlib.import_module(plugin) /usr/local/opt/python@3.8/Frameworks/Python.framework/Versions/3.8/lib/python3.8/importlib/__init__.py:127: in import_module return _bootstrap._gcd_import(name[level:], package, level) datasette/publish/heroku.py:2: in <module> from datasette import hookimpl E ImportError: cannot import name 'hookimpl' from partially initialized module 'datasette' (… | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
688622148 |