github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/pull/994#issuecomment-703878831 | https://api.github.com/repos/simonw/datasette/issues/994 | 703878831 | MDEyOklzc3VlQ29tbWVudDcwMzg3ODgzMQ== | 22429695 | 2020-10-05T20:45:39Z | 2020-10-09T16:18:24Z | NONE | # [Codecov](https://codecov.io/gh/simonw/datasette/pull/994?src=pr&el=h1) Report > Merging [#994](https://codecov.io/gh/simonw/datasette/pull/994?src=pr&el=desc) into [main](https://codecov.io/gh/simonw/datasette/commit/e807c4eac0e85ae15e013379b0dde1d797f1377d?el=desc) will **increase** coverage by `0.26%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/994/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1)](https://codecov.io/gh/simonw/datasette/pull/994?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## main #994 +/- ## ========================================== + Coverage 84.28% 84.55% +0.26% ========================================== Files 28 28 Lines 3850 3878 +28 ========================================== + Hits 3245 3279 +34 + Misses 605 599 -6 ``` | [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/994?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [datasette/utils/testing.py](https://codecov.io/gh/simonw/datasette/pull/994/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL3V0aWxzL3Rlc3RpbmcucHk=) | `95.16% <0.00%> (-4.84%)` | :arrow_down: | | [datasette/cli.py](https://codecov.io/gh/simonw/datasette/pull/994/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL2NsaS5weQ==) | `74.35% <0.00%> (ø)` | | | [datasette/utils/asgi.py](https://codecov.io/gh/simonw/datasette/pull/994/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL3V0aWxzL2FzZ2kucHk=) | `91.92% <0.00%> (ø)` | | | [datasette/app.py](https://codecov.io/gh/simonw/datasette/pull/994/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL2FwcC5weQ==) | `96.34% <0.00%> (+0.02%)` | :arrow_up: | | [datasette/views/table.py](https://codecov.io/gh/simonw/datasette/pull/994/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL3ZpZXdzL3RhYmxlLnB5) | `95.85% <0.00%> (+0.11%)` | :arrow_up: | | [datasette/views/base.py](https://codecov.io/gh/simonw/datasette/pull/994/diff?src=pr&el=tree#diff-ZGF0YX… | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
715146588 | |
https://github.com/simonw/datasette/issues/993#issuecomment-703928029 | https://api.github.com/repos/simonw/datasette/issues/993 | 703928029 | MDEyOklzc3VlQ29tbWVudDcwMzkyODAyOQ== | 9599 | 2020-10-05T22:42:45Z | 2020-10-05T22:42:59Z | OWNER | <img width="574" alt="fixtures__facetable__15_rows" src="https://user-images.githubusercontent.com/9599/95139485-65e8c180-0721-11eb-9e91-263aad6f6846.png"> The `NOT NULL` text shows up only for columns that are not null. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
715072935 | |
https://github.com/simonw/datasette/issues/992#issuecomment-703351641 | https://api.github.com/repos/simonw/datasette/issues/992 | 703351641 | MDEyOklzc3VlQ29tbWVudDcwMzM1MTY0MQ== | 9599 | 2020-10-05T01:31:36Z | 2020-10-05T01:31:36Z | OWNER | If I rename metadata to config in #493 then this should be `--setting` instead. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
714449879 | |
https://github.com/simonw/datasette/issues/741#issuecomment-703350401 | https://api.github.com/repos/simonw/datasette/issues/741 | 703350401 | MDEyOklzc3VlQ29tbWVudDcwMzM1MDQwMQ== | 9599 | 2020-10-05T01:26:12Z | 2020-10-05T01:26:12Z | OWNER | Relevant support question on Twitter: https://twitter.com/simonw/status/1312926103627988993 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
607223136 |