github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1054#issuecomment-717050585 | https://api.github.com/repos/simonw/datasette/issues/1054 | 717050585 | MDEyOklzc3VlQ29tbWVudDcxNzA1MDU4NQ== | 9599 | 2020-10-27T07:38:50Z | 2020-10-27T07:38:50Z | OWNER | Maybe imitate how Django does this, e.g. https://github.com/django/django/commit/6b9b2af7352908d40ca4d31bdb1b80c013cab29a | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
730199464 | |
https://github.com/simonw/datasette/issues/1054#issuecomment-717051707 | https://api.github.com/repos/simonw/datasette/issues/1054 | 717051707 | MDEyOklzc3VlQ29tbWVudDcxNzA1MTcwNw== | 9599 | 2020-10-27T07:41:21Z | 2020-10-27T07:41:21Z | OWNER | Essentially it's this problem: https://github.com/python-versioneer/python-versioneer/issues/140 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
730199464 | |
https://github.com/simonw/sqlite-utils/pull/189#issuecomment-717361487 | https://api.github.com/repos/simonw/sqlite-utils/issues/189 | 717361487 | MDEyOklzc3VlQ29tbWVudDcxNzM2MTQ4Nw== | 9599 | 2020-10-27T16:24:04Z | 2020-10-27T16:24:04Z | OWNER | This is great, thank you very much. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
729818242 | |
https://github.com/simonw/datasette/pull/1056#issuecomment-717489501 | https://api.github.com/repos/simonw/datasette/issues/1056 | 717489501 | MDEyOklzc3VlQ29tbWVudDcxNzQ4OTUwMQ== | 22429695 | 2020-10-27T19:39:41Z | 2020-10-27T19:39:41Z | NONE | # [Codecov](https://codecov.io/gh/simonw/datasette/pull/1056?src=pr&el=h1) Report > Merging [#1056](https://codecov.io/gh/simonw/datasette/pull/1056?src=pr&el=desc) into [main](https://codecov.io/gh/simonw/datasette/commit/26bb4a268127da2c38f4241abe45444b2a6f7874?el=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1056/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1)](https://codecov.io/gh/simonw/datasette/pull/1056?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## main #1056 +/- ## ======================================= Coverage 84.70% 84.70% ======================================= Files 28 28 Lines 3955 3955 ======================================= Hits 3350 3350 Misses 605 605 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1056?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1056?src=pr&el=footer). Last update [26bb4a2...a7b2aab](https://codecov.io/gh/simonw/datasette/pull/1056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
730752399 | |
https://github.com/simonw/datasette/issues/1058#issuecomment-717527606 | https://api.github.com/repos/simonw/datasette/issues/1058 | 717527606 | MDEyOklzc3VlQ29tbWVudDcxNzUyNzYwNg== | 9599 | 2020-10-27T20:44:06Z | 2020-10-27T20:44:06Z | OWNER | Example: https://github.com/simonw/datasette/blob/5a1519796037105bc20bcf2f91a76e022926c204/datasette/views/database.py#L26-L32 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
730802994 | |
https://github.com/simonw/datasette/issues/1057#issuecomment-717531272 | https://api.github.com/repos/simonw/datasette/issues/1057 | 717531272 | MDEyOklzc3VlQ29tbWVudDcxNzUzMTI3Mg== | 9599 | 2020-10-27T20:51:09Z | 2020-10-27T20:51:09Z | OWNER | That works! <img width="1370" alt="Banners_and_Alerts_and_SQLite___Mike_Bostock___Observable" src="https://user-images.githubusercontent.com/9599/97360439-717c6380-185b-11eb-9996-e0064e4b22d4.png"> | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
730797787 | |
https://github.com/simonw/sqlite-utils/pull/189#issuecomment-717359145 | https://api.github.com/repos/simonw/sqlite-utils/issues/189 | 717359145 | MDEyOklzc3VlQ29tbWVudDcxNzM1OTE0NQ== | 35681 | 2020-10-27T16:20:32Z | 2020-10-27T16:20:32Z | CONTRIBUTOR | No problem. I added a test. Let me know if it looks sufficient or if you want me to to tweak something! If you don't mind, would you tag this PR as "hacktoberfest-accepted"? If you do mind, no problem and I'm sorry for asking :) My kiddos like the shirts. | { "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
729818242 |