github
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | pull_request | body | repo | type | active_lock_reason | performed_via_github_app | reactions | draft | state_reason |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
733499930 | MDU6SXNzdWU3MzM0OTk5MzA= | 1072 | load_template hook doesn't work for include/extends | 9599 | closed | 0 | 6026070 | 20 | 2020-10-30T20:33:44Z | 2020-10-31T20:48:18Z | 2020-10-30T22:50:57Z | OWNER | Includes like this one always go to disk, without hitting the `load_template` plugin hook: ```html+jinja <footer class="ft">{% block footer %}{% include "_footer.html" %}{% endblock %}</footer> ``` | 107914493 | issue | { "url": "https://api.github.com/repos/simonw/datasette/issues/1072/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
completed | |||||
732905360 | MDU6SXNzdWU3MzI5MDUzNjA= | 1067 | Table actions menu on view pages, not on query pages | 9599 | closed | 0 | 6026070 | 6 | 2020-10-30T05:56:39Z | 2020-10-31T17:51:31Z | 2020-10-31T17:40:14Z | OWNER | Follow-on from #1066. | 107914493 | issue | { "url": "https://api.github.com/repos/simonw/datasette/issues/1067/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
completed | |||||
733390884 | MDU6SXNzdWU3MzMzOTA4ODQ= | 1070 | load_template() example in documentation showing loading from a database | 9599 | closed | 0 | 6026070 | 1 | 2020-10-30T17:45:03Z | 2020-10-31T16:22:51Z | 2020-10-31T16:22:45Z | OWNER | > I should include an example in the documentation that shows loading templates from a database table. _Originally posted by @simonw in https://github.com/simonw/datasette/pull/1069#issuecomment-719664530_ | 107914493 | issue | { "url": "https://api.github.com/repos/simonw/datasette/issues/1070/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
completed | |||||
733560417 | MDU6SXNzdWU3MzM1NjA0MTc= | 1073 | Remove load_template plugin hook | 9599 | closed | 0 | 6026070 | 1 | 2020-10-30T22:51:52Z | 2020-10-31T16:22:00Z | 2020-10-31T16:22:00Z | OWNER | I couldn't get it working correctly with async (necessary for include/extend to function), and on deeper investigation it appears that I can build something equivalent to what I wanted using the existing `prepare_jinja2_environment` hook. > I'm going to remove the `load_template` plugin hook and see if it's possible to build the edit templates extension against `prepare_jinja2_environment` instead. _Originally posted by @simonw in https://github.com/simonw/datasette/issues/1072#issuecomment-719833744_ | 107914493 | issue | { "url": "https://api.github.com/repos/simonw/datasette/issues/1073/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
completed | |||||
733485423 | MDU6SXNzdWU3MzM0ODU0MjM= | 1071 | Messages should be displayed full width | 9599 | closed | 0 | 6026070 | 1 | 2020-10-30T20:11:35Z | 2020-10-30T20:20:02Z | 2020-10-30T20:13:05Z | OWNER | In the pattern portfolio: <img width="907" alt="Datasette__Pattern_Portfolio_and_datasette_—_pipenv_shell_▸_Python_—_142×48" src="https://user-images.githubusercontent.com/9599/97752509-5a36b380-1ab1-11eb-9a26-700cb295fe11.png"> But they're currently showing like this: <img width="901" alt="Datasette___memory_" src="https://user-images.githubusercontent.com/9599/97752544-69b5fc80-1ab1-11eb-80c2-c88aabe6a832.png"> | 107914493 | issue | { "url": "https://api.github.com/repos/simonw/datasette/issues/1071/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
completed | |||||
732939921 | MDU6SXNzdWU3MzI5Mzk5MjE= | 1068 | Default menu links should check a real permission | 9599 | closed | 0 | 6026070 | 5 | 2020-10-30T07:08:34Z | 2020-10-30T15:44:13Z | 2020-10-30T15:42:11Z | OWNER | https://github.com/simonw/datasette/blob/18a64fbb29271ce607937110bbdb55488c43f4e0/datasette/default_menu_links.py#L4-L6 This should check a named permission so that it can be customized by permission plugins. | 107914493 | issue | { "url": "https://api.github.com/repos/simonw/datasette/issues/1068/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
completed | |||||
732859030 | MDU6SXNzdWU3MzI4NTkwMzA= | 1066 | Table actions menu plus plugin hook | 9599 | closed | 0 | 6026070 | 3 | 2020-10-30T03:46:54Z | 2020-10-30T05:18:36Z | 2020-10-30T05:16:50Z | OWNER | > For the table actions: attaching it to a cog icon next to the table name could make sense. > > <img width="503" alt="data__faa-wildlife-strikes__26_rows_where_where_AIRPORT____OIL_RIG__sorted_by_rowid_and_Fix_table_name_in_spatialite_example_command_by_jsfenfen_·_Pull_Request__1022_·_simonw_datasette" src="https://user-images.githubusercontent.com/9599/96168896-45192c80-0ed6-11eb-9d90-6172a8346468.png"> > > This is the column action icon at twice the size, color `#666`. _Originally posted by @simonw in https://github.com/simonw/datasette/issues/690#issuecomment-709497595_ | 107914493 | issue | { "url": "https://api.github.com/repos/simonw/datasette/issues/1066/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
completed | |||||
732798913 | MDU6SXNzdWU3MzI3OTg5MTM= | 1064 | Navigation menu plus plugin hook | 9599 | closed | 0 | 6026070 | 10 | 2020-10-30T00:49:36Z | 2020-10-30T03:45:16Z | 2020-10-30T03:45:16Z | OWNER | Needed for #690. Prototype in https://github.com/simonw/datasette/commit/0d7ac764861d84be24d661cf4104ce61ea11a82a | 107914493 | issue | { "url": "https://api.github.com/repos/simonw/datasette/issues/1064/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
completed |