github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/pull/1085#issuecomment-725731685 | https://api.github.com/repos/simonw/datasette/issues/1085 | 725731685 | MDEyOklzc3VlQ29tbWVudDcyNTczMTY4NQ== | 22429695 | 2020-11-12T00:01:18Z | 2020-11-12T00:01:18Z | NONE | # [Codecov](https://codecov.io/gh/simonw/datasette/pull/1085?src=pr&el=h1) Report > Merging [#1085](https://codecov.io/gh/simonw/datasette/pull/1085?src=pr&el=desc) (51e7651) into [main](https://codecov.io/gh/simonw/datasette/commit/2a981e2ac1d13125973904b777d00ea75e8df4e6?el=desc) (2a981e2) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1085/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1)](https://codecov.io/gh/simonw/datasette/pull/1085?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## main #1085 +/- ## ======================================= Coverage 91.38% 91.38% ======================================= Files 30 30 Lines 3785 3785 ======================================= Hits 3459 3459 Misses 326 326 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1085?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1085?src=pr&el=footer). Last update [2a981e2...51e7651](https://codecov.io/gh/simonw/datasette/pull/1085?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
740512882 | |
https://github.com/simonw/datasette/issues/1088#issuecomment-725829903 | https://api.github.com/repos/simonw/datasette/issues/1088 | 725829903 | MDEyOklzc3VlQ29tbWVudDcyNTgyOTkwMw== | 9599 | 2020-11-12T04:33:14Z | 2020-11-12T04:33:14Z | OWNER | I'm suspicious of this code: https://github.com/simonw/datasette/blob/e8e0a6f284ca953b2980186c4356594c07bd1929/datasette/views/table.py#L1032-L1045 This code uses a different exception: https://github.com/simonw/datasette/blob/e8e0a6f284ca953b2980186c4356594c07bd1929/datasette/views/table.py#L658-L663 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
741268956 | |
https://github.com/simonw/datasette/issues/1088#issuecomment-725830533 | https://api.github.com/repos/simonw/datasette/issues/1088 | 725830533 | MDEyOklzc3VlQ29tbWVudDcyNTgzMDUzMw== | 9599 | 2020-11-12T04:35:08Z | 2020-11-12T04:35:08Z | OWNER | Yup, swapping `QueryInterrupted` fixed this against my giant database. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
741268956 | |
https://github.com/simonw/datasette/issues/1088#issuecomment-725830716 | https://api.github.com/repos/simonw/datasette/issues/1088 | 725830716 | MDEyOklzc3VlQ29tbWVudDcyNTgzMDcxNg== | 9599 | 2020-11-12T04:35:38Z | 2020-11-12T04:35:38Z | OWNER | I'm going to fix this without a test, because writing a test for this is a bit fiddly and it's a very minor bug. If it comes back again I'll do the work to test for it. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
741268956 | |
https://github.com/simonw/datasette/issues/1089#issuecomment-726127465 | https://api.github.com/repos/simonw/datasette/issues/1089 | 726127465 | MDEyOklzc3VlQ29tbWVudDcyNjEyNzQ2NQ== | 9599 | 2020-11-12T14:54:11Z | 2020-11-12T14:54:11Z | OWNER | Suggested list to look out for from that PR: - simply/simple - easy/easier/easiest - obvious/obviously - just - merely - straightforward - ridiculous | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
741665726 | |
https://github.com/simonw/datasette/issues/865#issuecomment-726385422 | https://api.github.com/repos/simonw/datasette/issues/865 | 726385422 | MDEyOklzc3VlQ29tbWVudDcyNjM4NTQyMg== | 6739646 | 2020-11-12T22:40:14Z | 2020-11-12T22:40:14Z | NONE | Just tested with the latest Docker image, and it works pretty much everywhere! THANK YOU! I did notice that if I try to export json or csv, the base is not applied. Not sure if I should reopen this issue or open a new one. To see this, go here: https://corpora.tika.apache.org/datasette/corpora-metadata/REF_PARSE_EXCEPTION_TYPES Click/hover over json or CSV and you'll see that the 'datasette' base is not included. Again, many thanks! | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
644582921 | |
https://github.com/simonw/datasette/issues/865#issuecomment-726385782 | https://api.github.com/repos/simonw/datasette/issues/865 | 726385782 | MDEyOklzc3VlQ29tbWVudDcyNjM4NTc4Mg== | 6739646 | 2020-11-12T22:41:06Z | 2020-11-12T22:41:06Z | NONE | The same is true if I select advanced export and hit the 'export csv' at the bottom of the page. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
644582921 | |
https://github.com/simonw/datasette/issues/865#issuecomment-726412057 | https://api.github.com/repos/simonw/datasette/issues/865 | 726412057 | MDEyOklzc3VlQ29tbWVudDcyNjQxMjA1Nw== | 9599 | 2020-11-12T23:49:23Z | 2020-11-12T23:49:23Z | OWNER | @tballison thanks, I've split that out into a new issue #1091 | { "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
644582921 | |
https://github.com/simonw/datasette/issues/1091#issuecomment-726413829 | https://api.github.com/repos/simonw/datasette/issues/1091 | 726413829 | MDEyOklzc3VlQ29tbWVudDcyNjQxMzgyOQ== | 9599 | 2020-11-12T23:52:50Z | 2020-11-12T23:54:16Z | OWNER | Hmm... it's not just the `.csv` and `.json` export links - it's the column headings (which can be clicked to change the sort order) as well. Here's an extract of the HTML from that page: ```html <p class="export-links">This data as <a href="/corpora-metadata/REF_PARSE_EXCEPTION_TYPES.json">json</a>, <a href="/corpora-metadata/REF_PARSE_EXCEPTION_TYPES.csv?_size=max">CSV</a> ( <a href="#export">advanced</a>) </p> <div class="table-wrapper"> <table class="rows-and-columns"> <thead> <tr> <th class="col-Link" scope="col" data-column="Link" data-column-type="" data-column-not-null="0" data-is-pk="0"> Link </th> <th class="col-rowid" scope="col" data-column="rowid" data-column-type="integer" data-column-not-null="0" data-is-pk="1"> <a href="/corpora-metadata/REF_PARSE_EXCEPTION_TYPES?_sort_desc=rowid" rel="nofollow">rowid ▼</a> </th> <th class="col-PARSE_EXCEPTION_ID" scope="col" data-column="PARSE_EXCEPTION_ID" data-column-type="INTEGER" data-column-not-null="0" data-is-pk="0"> <a href="/corpora-metadata/REF_PARSE_EXCEPTION_TYPES?_sort=PARSE_EXCEPTION_ID" rel="nofollow">PARSE_EXCEPTION_ID</a> </th> <th class="col-PARSE_EXCEPTION_DESCRIPTION" scope="col" data-column="PARSE_EXCEPTION_DESCRIPTION" data-column-type="VARCHAR(128)" data-column-not-null="0" data-is-pk="0"> <a href="/corpora-metadata/REF_PARSE_EXCEPTION_TYPES?_sort=PARSE_EXCEPTION_DESCRIPTION" rel="nofollow">PARSE_EXCEPTION_DESCRIPTION</a> </th> </tr> </thead> <tbody> <tr> <td class="col-Link type-pk"> <a href="/datasette/corpora-metadata/REF_PARSE_EXCEPTION_TYPES/1">1</a> </td> <td class="col-rowid type-int">1</td> <td class="col-PARSE_EXCEPTION_ID type-int">0</td> <td class="col-PARSE_EXCEPTION_DESCRIPTION type-str">RUNTIME</td> </tr> <tr> <td class="col-Link type-pk"> <a href="/datasette/corpora-… | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
742011049 | |
https://github.com/simonw/datasette/issues/1091#issuecomment-726415019 | https://api.github.com/repos/simonw/datasette/issues/1091 | 726415019 | MDEyOklzc3VlQ29tbWVudDcyNjQxNTAxOQ== | 9599 | 2020-11-12T23:56:23Z | 2020-11-12T23:56:23Z | OWNER | @tballison is there any chance you're running any custom templates in that installation? I'm really confused as to why I can't replicate the bug. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
742011049 | |
https://github.com/simonw/datasette/issues/1091#issuecomment-726415991 | https://api.github.com/repos/simonw/datasette/issues/1091 | 726415991 | MDEyOklzc3VlQ29tbWVudDcyNjQxNTk5MQ== | 9599 | 2020-11-12T23:59:34Z | 2020-11-12T23:59:34Z | OWNER | The sort headers are generated by this template code: https://github.com/simonw/datasette/blob/5eb8e9bf250b26e30b017d39a392c33973997656/datasette/templates/_table.html#L11-L15 The export links use this code: https://github.com/simonw/datasette/blob/5eb8e9bf250b26e30b017d39a392c33973997656/datasette/templates/table.html#L134 https://github.com/simonw/datasette/blob/5eb8e9bf250b26e30b017d39a392c33973997656/datasette/templates/table.html#L180-L201 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
742011049 |