github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/pull/1368#issuecomment-856182547 | https://api.github.com/repos/simonw/datasette/issues/1368 | 856182547 | MDEyOklzc3VlQ29tbWVudDg1NjE4MjU0Nw== | 2670795 | 2021-06-07T18:59:47Z | 2021-06-07T23:04:25Z | CONTRIBUTOR | Note that if we went with a "update_metadata" hook, the hook signature would look something like this (it would return nothing): ``` update_metadata( datasette=self, metadata=metadata, key=key, database=database, table=table, fallback=fallback ) ``` The Datasette function `_metadata_recursive_update(self, orig, updated)` would disappear into the plugins. Doing this, though, we'd lose the easy ability to make the local metadata.yaml immutable (since we'd no longer have the recursive update). | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
913865304 | |
https://github.com/simonw/sqlite-utils/issues/266#issuecomment-856231119 | https://api.github.com/repos/simonw/sqlite-utils/issues/266 | 856231119 | MDEyOklzc3VlQ29tbWVudDg1NjIzMTExOQ== | 9599 | 2021-06-07T20:26:05Z | 2021-06-07T20:26:05Z | OWNER | https://github.com/python/cpython/blob/2ab27c4af4ddf7528e1375e77c787c7fbb09b5e6/Lib/typing.py#L2173-L2195 In Python 3.6 or higher can do this: ```python class Employee(NamedTuple): name: str id: int ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
913135723 | |
https://github.com/simonw/datasette/issues/1365#issuecomment-856212136 | https://api.github.com/repos/simonw/datasette/issues/1365 | 856212136 | MDEyOklzc3VlQ29tbWVudDg1NjIxMjEzNg== | 9599 | 2021-06-07T19:54:04Z | 2021-06-07T19:54:04Z | OWNER | I've hit this one too. I agree, fixing this in Datasette itself is better than fixing it in the tests across multiple other projects. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
913017577 | |
https://github.com/simonw/datasette/issues/1369#issuecomment-856208637 | https://api.github.com/repos/simonw/datasette/issues/1369 | 856208637 | MDEyOklzc3VlQ29tbWVudDg1NjIwODYzNw== | 9599 | 2021-06-07T19:47:23Z | 2021-06-07T19:47:23Z | OWNER | No point in showing the IDs twice if the blue label doesn't differ from the gray ID | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
913900374 | |
https://github.com/simonw/datasette/issues/1367#issuecomment-856160770 | https://api.github.com/repos/simonw/datasette/issues/1367 | 856160770 | MDEyOklzc3VlQ29tbWVudDg1NjE2MDc3MA== | 9599 | 2021-06-07T18:22:33Z | 2021-06-07T18:22:33Z | OWNER | Here's why: https://github.com/simonw/datasette/blob/03ec71193b9545536898a4bc7493274fec48bdd7/datasette/static/app.css#L455-L458 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
913823889 | |
https://github.com/simonw/datasette/issues/1366#issuecomment-856147969 | https://api.github.com/repos/simonw/datasette/issues/1366 | 856147969 | MDEyOklzc3VlQ29tbWVudDg1NjE0Nzk2OQ== | 9599 | 2021-06-07T18:03:03Z | 2021-06-07T18:03:03Z | OWNER | Here's an example of a test that uses it. It's necessary because sometimes fixtures that create temporary directories break in unexpected ways: https://github.com/simonw/datasette/blob/0a7621f96f8ad14da17e7172e8a7bce24ef78966/tests/test_plugins.py#L658-L666 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
913809802 | |
https://github.com/simonw/datasette/issues/1366#issuecomment-856147450 | https://api.github.com/repos/simonw/datasette/issues/1366 | 856147450 | MDEyOklzc3VlQ29tbWVudDg1NjE0NzQ1MA== | 9599 | 2021-06-07T18:02:13Z | 2021-06-07T18:02:13Z | OWNER | The hack in question is this fixture, which I've been using in an ad-hoc manner to work around errors while running the tests: https://github.com/simonw/datasette/blob/030deb4b25cda842ff7129ab7c18550c44dd8379/tests/conftest.py#L62-L75 I don't understand the underlying issue well enough to know how to get rid of it. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
913809802 | |
https://github.com/simonw/sqlite-utils/issues/266#issuecomment-855611939 | https://api.github.com/repos/simonw/sqlite-utils/issues/266 | 855611939 | MDEyOklzc3VlQ29tbWVudDg1NTYxMTkzOQ== | 9599 | 2021-06-07T06:07:41Z | 2021-06-07T06:07:41Z | OWNER | Looks like this is the way to do this: ```python Point = typing.NamedTuple( "Point", [('x', int), ('y', int)] ) ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
913135723 |