github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/878#issuecomment-971209475 | https://api.github.com/repos/simonw/datasette/issues/878 | 971209475 | IC_kwDOBm6k_c4543sD | 9599 | 2021-11-17T05:41:42Z | 2021-11-17T05:41:42Z | OWNER | I'm going to build a brand new implementation of the `TableView` class that doesn't subclass `BaseView` at all, instead using `asyncinject`. If I'm lucky that will clean up the grungiest part of the codebase. I can maybe even run the tests against old `TableView` and `TableView2` to check that they behave the same. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
648435885 | |
https://github.com/simonw/datasette/issues/878#issuecomment-971057553 | https://api.github.com/repos/simonw/datasette/issues/878 | 971057553 | IC_kwDOBm6k_c454SmR | 9599 | 2021-11-17T01:40:45Z | 2021-11-17T01:40:45Z | OWNER | I shipped that code as a new library, `asyncinject`: https://pypi.org/project/asyncinject/ - I'll open a new PR to attempt to refactor `TableView` to use it. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
648435885 | |
https://github.com/simonw/datasette/pull/1512#issuecomment-971056169 | https://api.github.com/repos/simonw/datasette/issues/1512 | 971056169 | IC_kwDOBm6k_c454SQp | 9599 | 2021-11-17T01:39:44Z | 2021-11-17T01:39:44Z | OWNER | Closing this PR because I shipped the code in it as a separate library instead. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1055402144 | |
https://github.com/simonw/datasette/pull/1512#issuecomment-971055677 | https://api.github.com/repos/simonw/datasette/issues/1512 | 971055677 | IC_kwDOBm6k_c454SI9 | 9599 | 2021-11-17T01:39:25Z | 2021-11-17T01:39:25Z | OWNER | https://github.com/simonw/asyncinject version 0.1a0 is now live on PyPI: https://pypi.org/project/asyncinject/ | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1055402144 | |
https://github.com/simonw/datasette/pull/1512#issuecomment-971010724 | https://api.github.com/repos/simonw/datasette/issues/1512 | 971010724 | IC_kwDOBm6k_c454HKk | 9599 | 2021-11-17T01:12:22Z | 2021-11-17T01:12:22Z | OWNER | I'm going to extract out the `asyncinject` stuff into a separate library. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1055402144 |