github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1527#issuecomment-988154238 | https://api.github.com/repos/simonw/datasette/issues/1527 | 988154238 | IC_kwDOBm6k_c465gl- | 9599 | 2021-12-07T18:05:26Z | 2021-12-07T18:05:26Z | OWNER | Found a new case of this bug: click the "Apply" button on https://latest.datasette.io/fixtures/facetable?_sort=pk&_city_id__gt=1 ![apply-bug](https://user-images.githubusercontent.com/9599/145082760-6947c769-480f-45c7-9916-b6cc7f5834f8.gif) | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1059555791 | |
https://github.com/simonw/sqlite-utils/issues/349#issuecomment-987458772 | https://api.github.com/repos/simonw/sqlite-utils/issues/349 | 987458772 | IC_kwDOCGYnMM4622zU | 9599 | 2021-12-07T01:00:41Z | 2021-12-07T01:00:41Z | OWNER | I think the syntax design of this looks like: ```python item_pk = db[item_table].lookup( {"_item_id": item_id}, item_to_insert, column_order=("_id", "_item_id"), pk="_id", indexes=("_version",), ) ``` So it's a sequence of column names... or a sequence of tuples for creating compound indexes: ```python db["dogs"].insert( {"name": "Cleo", "species": "Mutt", "hobbies": "Raiding picnics"}, indexes=(("name", "species"), "hobbies"), ) ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1071531082 | |
https://github.com/simonw/sqlite-utils/issues/349#issuecomment-987461427 | https://api.github.com/repos/simonw/sqlite-utils/issues/349 | 987461427 | IC_kwDOCGYnMM4623cz | 9599 | 2021-12-07T01:03:43Z | 2021-12-07T01:04:37Z | OWNER | In terms of types, I think that means it looks like this: ```python IndexesType = Iterable[ Union[str, Iterable[str]] ] def create( self, columns: Dict[str, Any], pk: Optional[Any] = None, ... indexes: Optional[IndexesType] = None, ): ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1071531082 | |
https://github.com/simonw/sqlite-utils/issues/351#issuecomment-987437043 | https://api.github.com/repos/simonw/sqlite-utils/issues/351 | 987437043 | IC_kwDOCGYnMM462xfz | 9599 | 2021-12-07T00:41:02Z | 2021-12-07T00:41:56Z | OWNER | The fix there was: ```diff @@ -463,7 +473,7 @@ def compile_convert(convert, imports): locals = {} globals = {"json": json} for import_ in imports: - globals[import_] = __import__(import_) + globals[import_.split(".")[0]] = __import__(import_) exec(code_o, globals, locals) ``` With this example (needs to be modified here): ``` git-history file items.xml --convert ' tree = xml.etree.ElementTree.fromstring(content) return [el.attrib for el in tree.iter("item")] ' --import xml.etree.ElementTree ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1072780607 | |
https://github.com/simonw/sqlite-utils/issues/352#issuecomment-987454872 | https://api.github.com/repos/simonw/sqlite-utils/issues/352 | 987454872 | IC_kwDOCGYnMM46212Y | 9599 | 2021-12-07T00:56:29Z | 2021-12-07T00:56:29Z | OWNER | Thought about this due to this issue, which should stay consistent with how the `sqlite-utils` CLI works: - https://github.com/simonw/git-history/issues/41 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1072792507 | |
https://github.com/simonw/datasette/issues/1544#issuecomment-988226523 | https://api.github.com/repos/simonw/datasette/issues/1544 | 988226523 | IC_kwDOBm6k_c465yPb | 9599 | 2021-12-07T20:02:00Z | 2021-12-07T20:02:00Z | OWNER | Here's the code at fault: https://github.com/simonw/datasette/blob/0a7621f96f8ad14da17e7172e8a7bce24ef78966/datasette/database.py#L288-L291 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1073712378 | |
https://github.com/simonw/datasette/issues/1544#issuecomment-988226938 | https://api.github.com/repos/simonw/datasette/issues/1544 | 988226938 | IC_kwDOBm6k_c465yV6 | 9599 | 2021-12-07T20:02:44Z | 2021-12-07T20:02:44Z | OWNER | I'm feeling rushed today so I'm going to fix this without adding a test! | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1073712378 |