github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1518#issuecomment-997082845 | https://api.github.com/repos/simonw/datasette/issues/1518 | 997082845 | IC_kwDOBm6k_c47bkbd | 9599 | 2021-12-17T23:10:09Z | 2021-12-17T23:10:17Z | OWNER | These changes so far are now in the 0.60a0 alpha: https://github.com/simonw/datasette/releases/tag/0.60a0 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1058072543 | |
https://github.com/simonw/datasette/pull/1559#issuecomment-997082676 | https://api.github.com/repos/simonw/datasette/issues/1559 | 997082676 | IC_kwDOBm6k_c47bkY0 | 9599 | 2021-12-17T23:09:41Z | 2021-12-17T23:09:41Z | OWNER | This is now available to try out in Datasette 0.60a0: https://github.com/simonw/datasette/releases/tag/0.60a0 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1082743068 | |
https://github.com/simonw/datasette/pull/1562#issuecomment-997082189 | https://api.github.com/repos/simonw/datasette/issues/1562 | 997082189 | IC_kwDOBm6k_c47bkRN | 9599 | 2021-12-17T23:08:14Z | 2021-12-17T23:08:14Z | OWNER | Oh that makes sense: In Python 3.6 this happens: ``` Collecting janus<1.1,>=0.6.2 Using cached janus-0.7.0-py3-none-any.whl (6.9 kB) ``` While in Python 3.7 or higher this happens: ``` Collecting janus<1.1,>=0.6.2 Downloading janus-1.0.0-py3-none-any.whl (6.9 kB) ``` So this is safe to apply because `pip` is smart enough to pick the version of Janus that works for that Python version. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1083246400 | |
https://github.com/simonw/datasette/pull/1562#issuecomment-997081673 | https://api.github.com/repos/simonw/datasette/issues/1562 | 997081673 | IC_kwDOBm6k_c47bkJJ | 9599 | 2021-12-17T23:06:38Z | 2021-12-17T23:06:38Z | OWNER | From this diff between `0.7.0` and `1.0`: https://github.com/aio-libs/janus/compare/v0.7.0...v1.0.0 It looks like the only change relevant to compatibility is `loop = asyncio.get_running_loop()` directly instead of falling back to `asyncio.get_event_loop()` if `get_running_loop` isn't available. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1083246400 | |
https://github.com/simonw/datasette/pull/1562#issuecomment-997080352 | https://api.github.com/repos/simonw/datasette/issues/1562 | 997080352 | IC_kwDOBm6k_c47bj0g | 9599 | 2021-12-17T23:03:08Z | 2021-12-17T23:03:08Z | OWNER | They say they've dropped 3.6 support, but Datasette's tests against 3.6 are still passing. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1083246400 | |
https://github.com/simonw/datasette/issues/1566#issuecomment-997078812 | https://api.github.com/repos/simonw/datasette/issues/1566 | 997078812 | IC_kwDOBm6k_c47bjcc | 9599 | 2021-12-17T22:58:55Z | 2021-12-17T22:58:55Z | OWNER | The release notes for the 0.60a0 alpha will be useful here: https://github.com/simonw/datasette/releases/tag/0.60a0 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1083669410 | |
https://github.com/simonw/datasette/issues/1565#issuecomment-997077410 | https://api.github.com/repos/simonw/datasette/issues/1565 | 997077410 | IC_kwDOBm6k_c47bjGi | 9599 | 2021-12-17T22:54:45Z | 2021-12-17T22:54:45Z | OWNER | The table page should expose the query both with and without the `limit` clause. The above gave me back: ```sql select id, ACCESS_TYP, UNIT_ID, UNIT_NAME, SUID_NMA, AGNCY_ID, AGNCY_NAME, AGNCY_LEV, AGNCY_TYP, AGNCY_WEB, LAYER, MNG_AG_ID, MNG_AGENCY, MNG_AG_LEV, MNG_AG_TYP, PARK_URL, COUNTY, ACRES, LABEL_NAME, YR_EST, DES_TP, GAP_STS, geometry from CPAD_2020a_Units where "AGNCY_LEV" = :p0 order by id limit 101 ``` But I actually wanted to run a `fetch()` against a version of that without the `order by id limit 101` bit (I wanted to figure out the `Extent()` of the `geometry` column) - so I need something like `datasette.table_sql_no_order_no_limit`. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1083657868 | |
https://github.com/simonw/datasette/issues/1565#issuecomment-997069128 | https://api.github.com/repos/simonw/datasette/issues/1565 | 997069128 | IC_kwDOBm6k_c47bhFI | 9599 | 2021-12-17T22:31:18Z | 2021-12-17T22:31:18Z | OWNER | This should aim to be as consistent as possible with the various arguments to hooks on https://docs.datasette.io/en/stable/plugin_hooks.html | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1083657868 | |
https://github.com/simonw/datasette/pull/1559#issuecomment-996961196 | https://api.github.com/repos/simonw/datasette/issues/1559 | 996961196 | IC_kwDOBm6k_c47bGus | 9599 | 2021-12-17T19:00:53Z | 2021-12-17T19:00:53Z | OWNER | I'm going to merge this to `main` now. I can continue the refactoring there, but having it in `main` means I can put out an alpha release with the new hook which will unblock me from running tests against it in this repo: https://github.com/simonw/datasette-leaflet-freedraw/pull/8 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1082743068 | |
https://github.com/simonw/datasette/pull/1559#issuecomment-996959325 | https://api.github.com/repos/simonw/datasette/issues/1559 | 996959325 | IC_kwDOBm6k_c47bGRd | 9599 | 2021-12-17T18:59:54Z | 2021-12-17T18:59:54Z | OWNER | I've convinced myself that this plugin hook design is good through this `datasette-leaflet-freedraw` prototype: https://github.com/simonw/datasette-leaflet-freedraw/blob/e8a16a0fe90656b8d655c02881d23a2b9833281d/datasette_leaflet_freedraw/__init__.py | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1082743068 | |
https://github.com/simonw/datasette/issues/473#issuecomment-996958442 | https://api.github.com/repos/simonw/datasette/issues/473 | 996958442 | IC_kwDOBm6k_c47bGDq | 9599 | 2021-12-17T18:59:27Z | 2021-12-17T18:59:27Z | OWNER | I'm happy with how the prototype that used this plugin in `datasette-leaflet-freedraw` turned out: https://github.com/simonw/datasette-leaflet-freedraw/blob/e8a16a0fe90656b8d655c02881d23a2b9833281d/datasette_leaflet_freedraw/__init__.py | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
445850934 | |
https://github.com/simonw/datasette/issues/473#issuecomment-996345233 | https://api.github.com/repos/simonw/datasette/issues/473 | 996345233 | IC_kwDOBm6k_c47YwWR | 9599 | 2021-12-17T01:20:31Z | 2021-12-17T18:13:01Z | OWNER | I could use this hook to add table filtering on a map to the existing `datasette-leaflet-freedraw` plugin. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
445850934 | |
https://github.com/simonw/datasette/pull/1559#issuecomment-996895423 | https://api.github.com/repos/simonw/datasette/issues/1559 | 996895423 | IC_kwDOBm6k_c47a2q_ | 9599 | 2021-12-17T17:28:44Z | 2021-12-17T17:28:44Z | OWNER | Before I land this I'm going to build one prototype plugin against it to confirm that the new hook is useful in its current shape. I'll add support for filtering a table by drawing on a map to https://datasette.io/plugins/datasette-leaflet-freedraw | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1082743068 | |
https://github.com/simonw/datasette/pull/1204#issuecomment-996488925 | https://api.github.com/repos/simonw/datasette/issues/1204 | 996488925 | IC_kwDOBm6k_c47ZTbd | 9599 | 2021-12-17T07:10:48Z | 2021-12-17T07:10:48Z | OWNER | I think this is missing the `_macro.html` template file but I have that in my Dropbox. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
793002853 | |
https://github.com/simonw/datasette/issues/473#issuecomment-996484551 | https://api.github.com/repos/simonw/datasette/issues/473 | 996484551 | IC_kwDOBm6k_c47ZSXH | 9599 | 2021-12-17T07:02:21Z | 2021-12-17T07:04:23Z | OWNER | The one slightly weird thing about this hook is how it adds `extra_context` without an obvious way for plugins to add extra HTML to the templates based on that context. Maybe I need the proposed mechanism from - #1191 Which has an in-progress PR: - #1204 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
445850934 | |
https://github.com/simonw/datasette/pull/1559#issuecomment-996286808 | https://api.github.com/repos/simonw/datasette/issues/1559 | 996286808 | IC_kwDOBm6k_c47YiFY | 9599 | 2021-12-17T00:01:43Z | 2021-12-17T00:01:43Z | OWNER | This already has tests and documentation, and I've used it to refactor out the logic for `?_where=` and `?_search=` and `?_through=`. Do I like this enough to land it on `main`? Also, I think I can still use it to refactor out the `Filters` code that implements `?col=x` and `?col__lt=5` and suchlike. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1082743068 | |
https://github.com/simonw/datasette/issues/473#issuecomment-996286199 | https://api.github.com/repos/simonw/datasette/issues/473 | 996286199 | IC_kwDOBm6k_c47Yh73 | 9599 | 2021-12-17T00:00:22Z | 2021-12-17T00:00:22Z | OWNER | Documentation for that hook in the PR branch: https://github.com/simonw/datasette/blob/54e9b3972f277431a001e685f78e5dd6403a6d8d/docs/plugin_hooks.rst#filters_from_requestrequest-database-table-datasette | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
445850934 | |
https://github.com/simonw/datasette/issues/1518#issuecomment-996286104 | https://api.github.com/repos/simonw/datasette/issues/1518 | 996286104 | IC_kwDOBm6k_c47Yh6Y | 9599 | 2021-12-17T00:00:07Z | 2021-12-17T00:00:07Z | OWNER | Documentation of the new hook in the PR: https://github.com/simonw/datasette/blob/54e9b3972f277431a001e685f78e5dd6403a6d8d/docs/plugin_hooks.rst#filters_from_requestrequest-database-table-datasette | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1058072543 |