github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1591#issuecomment-1013669543 | https://api.github.com/repos/simonw/datasette/issues/1591 | 1013669543 | IC_kwDOBm6k_c48a16n | 9599 | 2022-01-15T11:56:59Z | 2022-01-15T11:56:59Z | OWNER | There's actually already a way to move regular Datasette `--setting` options to a `settings.json` file thanks to configuration directory mode: https://docs.datasette.io/en/stable/settings.html Maybe extending that mechanism to handle plugins would be a neat path forward here. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1100015398 | |
https://github.com/simonw/datasette/issues/1591#issuecomment-1013668967 | https://api.github.com/repos/simonw/datasette/issues/1591 | 1013668967 | IC_kwDOBm6k_c48a1xn | 9599 | 2022-01-15T11:53:21Z | 2022-01-15T11:53:21Z | OWNER | The `datasette publish --plugin-secret name setting value` option already implements something a bit like this. https://docs.datasette.io/en/stable/plugins.html#secret-configuration-values It's a bit of a messy hack to compensate for metadata being visible. Maybe I could replace that mechanism with the proposed plugin configuration rethink from this issue. I still like the debug benefits of making plugin settings public - perhaps add a rule that if a plugin setting has a `secret:` prefix it gets redacted on a new `/-/plugin-settings` page. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1100015398 |