github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/pull/1593#issuecomment-1031455498 | https://api.github.com/repos/simonw/datasette/issues/1593 | 1031455498 | IC_kwDOBm6k_c49esMK | 49699333 | 2022-02-07T13:13:22Z | 2022-02-07T13:13:22Z | CONTRIBUTOR | Superseded by #1631. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1101705012 | |
https://github.com/simonw/sqlite-utils/issues/402#issuecomment-1031779460 | https://api.github.com/repos/simonw/sqlite-utils/issues/402 | 1031779460 | IC_kwDOCGYnMM49f7SE | 25778 | 2022-02-07T18:24:56Z | 2022-02-07T18:24:56Z | CONTRIBUTOR | I wonder if there's any overlap with the goals here and the `sqlite3` module's concept of adapters and converters: https://docs.python.org/3/library/sqlite3.html#sqlite-and-python-types I'm not sure that's _exactly_ what we're talking about here, but it might be a parallel with some useful ideas to borrow. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1125297737 | |
https://github.com/simonw/sqlite-utils/issues/402#issuecomment-1031791783 | https://api.github.com/repos/simonw/sqlite-utils/issues/402 | 1031791783 | IC_kwDOCGYnMM49f-Sn | 25778 | 2022-02-07T18:37:40Z | 2022-02-07T18:37:40Z | CONTRIBUTOR | I've never used it either, but it's interesting, right? Feel like I should try it for something. I'm trying to get my head around how this conversions feature might work, because I really like the idea of it. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1125297737 | |
https://github.com/simonw/datasette/pull/1631#issuecomment-1031463789 | https://api.github.com/repos/simonw/datasette/issues/1631 | 1031463789 | IC_kwDOBm6k_c49euNt | 22429695 | 2022-02-07T13:21:48Z | 2022-02-07T13:21:48Z | NONE | # [Codecov](https://codecov.io/gh/simonw/datasette/pull/1631?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report > Merging [#1631](https://codecov.io/gh/simonw/datasette/pull/1631?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (62eed84) into [main](https://codecov.io/gh/simonw/datasette/commit/03305ea183b1534bc4cef3a721fe5f3700273b84?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (03305ea) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1631/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/datasette/pull/1631?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) ```diff @@ Coverage Diff @@ ## main #1631 +/- ## ======================================= Coverage 92.19% 92.19% ======================================= Files 34 34 Lines 4546 4546 ======================================= Hits 4191 4191 Misses 355 355 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1631?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov… | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1125973221 | |
https://github.com/simonw/datasette/issues/1176#issuecomment-1031108559 | https://api.github.com/repos/simonw/datasette/issues/1176 | 1031108559 | IC_kwDOBm6k_c49dXfP | 9599 | 2022-02-07T06:11:27Z | 2022-02-07T06:11:27Z | OWNER | I'm going with `@documented` as the decorator for functions that should be documented. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
779691739 | |
https://github.com/simonw/datasette/issues/1176#issuecomment-1031122800 | https://api.github.com/repos/simonw/datasette/issues/1176 | 1031122800 | IC_kwDOBm6k_c49da9w | 9599 | 2022-02-07T06:34:21Z | 2022-02-07T06:34:21Z | OWNER | New section is here: https://docs.datasette.io/en/latest/internals.html#the-datasette-utils-module But it's not correctly displaying the new autodoc stuff: <img width="688" alt="image" src="https://user-images.githubusercontent.com/9599/152736915-e6470e0a-05e2-4612-a2ff-ebd4f51b65cb.png"> | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
779691739 | |
https://github.com/simonw/datasette/issues/1176#issuecomment-1031123719 | https://api.github.com/repos/simonw/datasette/issues/1176 | 1031123719 | IC_kwDOBm6k_c49dbMH | 9599 | 2022-02-07T06:36:32Z | 2022-02-07T06:36:32Z | OWNER | https://github.com/simonw/sqlite-utils/blob/main/.readthedocs.yaml looks like this (it works correctly): ```yaml version: 2 sphinx: configuration: docs/conf.py python: version: "3.8" install: - method: pip path: . extra_requirements: - docs ``` Compare to the current Datasette one here: https://github.com/simonw/datasette/blob/d9b508ffaa91f9f1840b366f5d282712d445f16b/.readthedocs.yaml#L1-L13 Looks like I need this bit: ```python python: version: "3.8" install: - method: pip path: . extra_requirements: - docs ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
779691739 | |
https://github.com/simonw/datasette/issues/1176#issuecomment-1031125347 | https://api.github.com/repos/simonw/datasette/issues/1176 | 1031125347 | IC_kwDOBm6k_c49dblj | 9599 | 2022-02-07T06:40:16Z | 2022-02-07T06:40:16Z | OWNER | Read The Docs error: > Problem in your project's configuration. Invalid "python.version": .readthedocs.yaml: Invalid configuration option: python.version. Make sure the key name is correct. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
779691739 | |
https://github.com/simonw/datasette/issues/1176#issuecomment-1031126547 | https://api.github.com/repos/simonw/datasette/issues/1176 | 1031126547 | IC_kwDOBm6k_c49db4T | 9599 | 2022-02-07T06:42:58Z | 2022-02-07T06:42:58Z | OWNER | That fixed it: https://docs.datasette.io/en/latest/internals.html#parse-metadata-content <img width="695" alt="image" src="https://user-images.githubusercontent.com/9599/152737872-595e9a14-1a0d-47ff-9509-63ee765c0c5d.png"> | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
779691739 | |
https://github.com/simonw/datasette/issues/1176#issuecomment-1031126801 | https://api.github.com/repos/simonw/datasette/issues/1176 | 1031126801 | IC_kwDOBm6k_c49db8R | 9599 | 2022-02-07T06:43:31Z | 2022-02-07T06:43:31Z | OWNER | Here's the new test: https://github.com/simonw/datasette/blob/03305ea183b1534bc4cef3a721fe5f3700273b84/tests/test_docs.py#L91-L104 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
779691739 | |
https://github.com/simonw/datasette/issues/1439#issuecomment-1031141849 | https://api.github.com/repos/simonw/datasette/issues/1439 | 1031141849 | IC_kwDOBm6k_c49dfnZ | 9599 | 2022-02-07T07:11:11Z | 2022-02-07T07:11:11Z | OWNER | I added a Link header to solve this problem for the JSON version in: - #1533 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
973139047 | |
https://github.com/simonw/sqlite-utils/issues/402#issuecomment-1031787865 | https://api.github.com/repos/simonw/sqlite-utils/issues/402 | 1031787865 | IC_kwDOCGYnMM49f9VZ | 9599 | 2022-02-07T18:33:27Z | 2022-02-07T18:33:27Z | OWNER | Hah, that's interesting - I've never used that mechanism before so it wasn't something that came to mind. They seem to be using a pretty surprising trick there that takes advantage of SQLite allowing you to define a column "type" using a made-up type name, which you can then introspect later. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1125297737 | |
https://github.com/simonw/datasette/issues/1632#issuecomment-1032032686 | https://api.github.com/repos/simonw/datasette/issues/1632 | 1032032686 | IC_kwDOBm6k_c49g5Gu | 9599 | 2022-02-07T23:16:10Z | 2022-02-07T23:16:10Z | OWNER | I found this bug while trying to get the following to work: datasette /data/one.db /data/two.db /data/*.db --create I want this to create any missing database files on startup out of that literal list of `one.db` and `two.db` and to also open any other `*.db` files in that folder - needed for `datasette-publish-fly` in https://github.com/simonw/datasette-publish-fly/pull/12#issuecomment-1032029874 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1126604194 | |
https://github.com/simonw/datasette/issues/1632#issuecomment-1032034015 | https://api.github.com/repos/simonw/datasette/issues/1632 | 1032034015 | IC_kwDOBm6k_c49g5bf | 9599 | 2022-02-07T23:17:57Z | 2022-02-07T23:17:57Z | OWNER | I'm going to fix this in a 0.60.2 bug fix release. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1126604194 | |
https://github.com/simonw/datasette/issues/1632#issuecomment-1032036525 | https://api.github.com/repos/simonw/datasette/issues/1632 | 1032036525 | IC_kwDOBm6k_c49g6Ct | 9599 | 2022-02-07T23:19:59Z | 2022-02-07T23:19:59Z | OWNER | I'm going to fix this in the CLI code itself, rather than fixing it in the `Datasette` constructor. That way if someone has a truly weird reason to want this behaviour they can construct Datasette directly. https://github.com/simonw/datasette/blob/03305ea183b1534bc4cef3a721fe5f3700273b84/datasette/cli.py#L535-L550 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1126604194 | |
https://github.com/simonw/datasette/issues/1632#issuecomment-1032037391 | https://api.github.com/repos/simonw/datasette/issues/1632 | 1032037391 | IC_kwDOBm6k_c49g6QP | 9599 | 2022-02-07T23:21:07Z | 2022-02-07T23:21:07Z | OWNER | For the record, here's the code that picks the `one_2` name if that stem is already used as a database name: https://github.com/simonw/datasette/blob/03305ea183b1534bc4cef3a721fe5f3700273b84/datasette/app.py#L401-L417 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1126604194 | |
https://github.com/simonw/datasette/issues/1632#issuecomment-1032050489 | https://api.github.com/repos/simonw/datasette/issues/1632 | 1032050489 | IC_kwDOBm6k_c49g9c5 | 9599 | 2022-02-07T23:39:11Z | 2022-02-07T23:42:08Z | OWNER | That implementation broke on Python 3.6 - which is still a supported Python version for the 0.60.x branch - `test_homepage` failed. ``` > assert ( "2 rows in 1 table, 5 rows in 4 hidden tables, 1 view" == counts_p.text.strip() ) E AssertionError: assert '2 rows in 1 ...ables, 1 view' == '1 table, 4 h...ables, 1 view' E - 1 table, 4 hidden tables, 1 view E + 2 rows in 1 table, 5 rows in 4 hidden tables, 1 view E ? ++++++++++ ++++++++++ ``` That's because this idiom isn't guaranteed to preserve order in versions earlier than Python 3.7: https://github.com/simonw/datasette/blob/fa5fc327adbbf70656ac533912f3fc0526a3873d/datasette/cli.py#L552-L553 I could say that `0.60.2` is the first version to require Python 3.7 - but that feels a little surprising. I'm going to use a different idiom for order-preserving de-duplication from [this StackOverflow](https://stackoverflow.com/questions/480214/how-do-you-remove-duplicates-from-a-list-whilst-preserving-order) instead. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1126604194 | |
https://github.com/simonw/datasette/issues/1632#issuecomment-1032057472 | https://api.github.com/repos/simonw/datasette/issues/1632 | 1032057472 | IC_kwDOBm6k_c49g_KA | 9599 | 2022-02-07T23:50:01Z | 2022-02-07T23:50:01Z | OWNER | Released in https://github.com/simonw/datasette/releases/tag/0.60.2 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1126604194 |