github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1661#issuecomment-1071706993 | https://api.github.com/repos/simonw/datasette/issues/1661 | 1071706993 | IC_kwDOBm6k_c4_4PNx | 9599 | 2022-03-17T22:42:21Z | 2022-03-17T22:42:21Z | OWNER | As part of this I'm going to get rid of this mechanism: https://github.com/simonw/datasette/blob/30e5f0e67c38054a8087a2a4eae3fc4d1779af90/datasette/views/base.py#L170-L173 Unwrapping `request.scope["url_route"]["kwargs"]` into keyword argument to view functions just made the code harder to follow. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1170355774 | |
https://github.com/simonw/datasette/issues/1661#issuecomment-1071793307 | https://api.github.com/repos/simonw/datasette/issues/1661 | 1071793307 | IC_kwDOBm6k_c4_4kSb | 9599 | 2022-03-17T23:17:32Z | 2022-03-17T23:17:32Z | OWNER | Surprisingly I managed to break https://latest.datasette.io/fixtures/custom_foreign_key_label while working on this change: ![CleanShot 2022-03-17 at 16 16 54@2x](https://user-images.githubusercontent.com/9599/158909271-717b65e8-cfcc-44c4-b1cc-f34478b0f803.png) | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1170355774 | |
https://github.com/simonw/datasette/issues/1661#issuecomment-1071797707 | https://api.github.com/repos/simonw/datasette/issues/1661 | 1071797707 | IC_kwDOBm6k_c4_4lXL | 9599 | 2022-03-17T23:19:24Z | 2022-03-17T23:19:24Z | OWNER | Moving this to PR so I can comment on individual lines: - #1664 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1170355774 | |
https://github.com/simonw/datasette/issues/1663#issuecomment-1071519407 | https://api.github.com/repos/simonw/datasette/issues/1663 | 1071519407 | IC_kwDOBm6k_c4_3hav | 9599 | 2022-03-17T21:32:35Z | 2022-03-17T21:32:35Z | OWNER | Updated docs: - https://docs.datasette.io/en/latest/internals.html#datasette-class - https://docs.datasette.io/en/latest/internals.html#db-hash | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1170554975 | |
https://github.com/simonw/datasette/pull/1664#issuecomment-1071803114 | https://api.github.com/repos/simonw/datasette/issues/1664 | 1071803114 | IC_kwDOBm6k_c4_4mrq | 9599 | 2022-03-17T23:22:00Z | 2022-03-17T23:22:00Z | OWNER | Surprisingly I managed to break https://latest.datasette.io/fixtures/custom_foreign_key_label while working on this change: ![CleanShot 2022-03-17 at 16 16 54@2x](https://user-images.githubusercontent.com/9599/158909271-717b65e8-cfcc-44c4-b1cc-f34478b0f803.png) | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1173017980 | |
https://github.com/simonw/datasette/pull/1664#issuecomment-1071809988 | https://api.github.com/repos/simonw/datasette/issues/1664 | 1071809988 | IC_kwDOBm6k_c4_4oXE | 9599 | 2022-03-17T23:24:57Z | 2022-03-17T23:24:57Z | OWNER | My hunch is that this is broken because of this: https://github.com/simonw/datasette/blob/30e5f0e67c38054a8087a2a4eae3fc4d1779af90/datasette/app.py#L1098-L1107 Note how the table uses `table_and_format` but the row uses just `table` - I think there's code that's getting confused by this. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1173017980 | |
https://github.com/simonw/datasette/pull/1664#issuecomment-1071813296 | https://api.github.com/repos/simonw/datasette/issues/1664 | 1071813296 | IC_kwDOBm6k_c4_4pKw | 9599 | 2022-03-17T23:26:22Z | 2022-03-17T23:26:22Z | OWNER | Probably caused by the convoluted code is `get_format()`: https://github.com/simonw/datasette/blob/30e5f0e67c38054a8087a2a4eae3fc4d1779af90/datasette/views/base.py#L466-L481 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1173017980 |