github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/pull/1664#issuecomment-1072890524 | https://api.github.com/repos/simonw/datasette/issues/1664 | 1072890524 | IC_kwDOBm6k_c4_8wKc | 9599 | 2022-03-18T23:44:33Z | 2022-03-19T00:06:51Z | OWNER | Looks like that was set here: https://github.com/simonw/datasette/blob/77a904fea14f743560af9cc668146339bdbbd0a9/datasette/views/base.py#L490-L492 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1173017980 | |
https://github.com/simonw/datasette/pull/1664#issuecomment-1072890205 | https://api.github.com/repos/simonw/datasette/issues/1664 | 1072890205 | IC_kwDOBm6k_c4_8wFd | 9599 | 2022-03-18T23:43:15Z | 2022-03-18T23:43:15Z | OWNER | Now almost everything is working except for foreign key expansion: ![CleanShot 2022-03-18 at 16 41 39@2x](https://user-images.githubusercontent.com/9599/159097349-6f41dfdf-5bab-449b-a148-5cda3df6534c.png) Using the debugger I tracked it down to this code: https://github.com/simonw/datasette/blob/30e5f0e67c38054a8087a2a4eae3fc4d1779af90/datasette/views/table.py#L708-L715 Turns out `default_labels` there is `None` - and it's a parameter to that `data()` method: https://github.com/simonw/datasette/blob/30e5f0e67c38054a8087a2a4eae3fc4d1779af90/datasette/views/table.py#L325-L334 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1173017980 |