github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1831#issuecomment-1276693475 | https://api.github.com/repos/simonw/datasette/issues/1831 | 1276693475 | IC_kwDOBm6k_c5MGMvj | 9599 | 2022-10-12T20:23:01Z | 2022-10-12T20:23:01Z | OWNER | Here are all the places that display that navigation bar at the moment: https://github.com/simonw/datasette/blob/b7fec7f9020b79c1fe60cc5a2def86b50eeb5af9/datasette/templates/row.html#L18-L25 https://github.com/simonw/datasette/blob/b7fec7f9020b79c1fe60cc5a2def86b50eeb5af9/datasette/templates/table.html#L19-L25 https://github.com/simonw/datasette/blob/b7fec7f9020b79c1fe60cc5a2def86b50eeb5af9/datasette/templates/query.html#L21-L27 https://github.com/simonw/datasette/blob/b7fec7f9020b79c1fe60cc5a2def86b50eeb5af9/datasette/templates/error.html#L5-L10 https://github.com/simonw/datasette/blob/b7fec7f9020b79c1fe60cc5a2def86b50eeb5af9/datasette/templates/database.html#L12-L17 https://github.com/simonw/datasette/blob/b7fec7f9020b79c1fe60cc5a2def86b50eeb5af9/datasette/templates/show_json.html#L7-L12 https://github.com/simonw/datasette/blob/b7fec7f9020b79c1fe60cc5a2def86b50eeb5af9/datasette/templates/permissions_debug.html#L25-L30 https://github.com/simonw/datasette/blob/b7fec7f9020b79c1fe60cc5a2def86b50eeb5af9/datasette/templates/permissions_debug.html#L25-L30t Interesting to note that failing to include that `super()` call means the nav menu itself will not be rendered: https://github.com/simonw/datasette/blob/b7fec7f9020b79c1fe60cc5a2def86b50eeb5af9/datasette/templates/base.html#L20-L49 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1397084281 | |
https://github.com/simonw/datasette/issues/1831#issuecomment-1276694152 | https://api.github.com/repos/simonw/datasette/issues/1831 | 1276694152 | IC_kwDOBm6k_c5MGM6I | 9599 | 2022-10-12T20:23:44Z | 2022-10-12T20:23:44Z | OWNER | The fact that this code is inconsistent already (`urls.instance()` v.s. `base_url` for example) suggests that properly refactoring this is well overdue already. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1397084281 | |
https://github.com/simonw/datasette/issues/1831#issuecomment-1276696138 | https://api.github.com/repos/simonw/datasette/issues/1831 | 1276696138 | IC_kwDOBm6k_c5MGNZK | 9599 | 2022-10-12T20:25:39Z | 2022-10-12T20:25:39Z | OWNER | Related issue: - #1829 I'd like a code design for this that helps solve both these issues at once. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1397084281 | |
https://github.com/simonw/datasette/issues/1831#issuecomment-1276706181 | https://api.github.com/repos/simonw/datasette/issues/1831 | 1276706181 | IC_kwDOBm6k_c5MGP2F | 9599 | 2022-10-12T20:34:00Z | 2022-10-12T23:43:39Z | OWNER | Maybe new template functions: `table_crumbs(table, database)` and `database_crumbs(database)` and `instance_crumbs()` - which know how to both check the permissions and display the `<ul>` full of links. Or just `crumbs(table=table, database=database)` where both of those are optional. Maybe accept `actor=` or `request=` too. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1397084281 | |
https://github.com/simonw/datasette/issues/1831#issuecomment-1276848084 | https://api.github.com/repos/simonw/datasette/issues/1831 | 1276848084 | IC_kwDOBm6k_c5MGyfU | 9599 | 2022-10-12T23:39:02Z | 2022-10-12T23:39:02Z | OWNER | Made some notes on the Jinja documentation while thinking about the best way to do this: - https://github.com/simonw/public-notes/issues/4 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1397084281 | |
https://github.com/simonw/datasette/issues/1831#issuecomment-1276856836 | https://api.github.com/repos/simonw/datasette/issues/1831 | 1276856836 | IC_kwDOBm6k_c5MG0oE | 9599 | 2022-10-12T23:57:28Z | 2022-10-12T23:57:28Z | OWNER | As part of this I think I want `request` to always be available in the template context, which will remove the need for https://datasette.io/plugins/datasette-template-request | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1397084281 |