github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1871#issuecomment-1312822353 | https://api.github.com/repos/simonw/datasette/issues/1871 | 1312822353 | IC_kwDOBm6k_c5OQBRR | 9599 | 2022-11-13T21:07:40Z | 2022-11-13T21:07:40Z | OWNER | I'm going to need extra code to toggle POST closed when GET opens and vice-versa. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1427293909 | |
https://github.com/simonw/datasette/issues/1871#issuecomment-1312821031 | https://api.github.com/repos/simonw/datasette/issues/1871 | 1312821031 | IC_kwDOBm6k_c5OQA8n | 9599 | 2022-11-13T21:02:06Z | 2022-11-13T21:03:11Z | OWNER | Actually no, I'm going to add a class of `details-menu` to the other details elements that SHOULD be closed. That way custom templates using `<details>` won't close in a surprising way. | { "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1427293909 | |
https://github.com/simonw/datasette/issues/1871#issuecomment-1312816451 | https://api.github.com/repos/simonw/datasette/issues/1871 | 1312816451 | IC_kwDOBm6k_c5OP_1D | 9599 | 2022-11-13T20:39:26Z | 2022-11-13T20:39:34Z | OWNER | I'm going to add a special `no-auto-close` class to these and teach that code not to close them. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1427293909 | |
https://github.com/simonw/datasette/issues/1871#issuecomment-1312816292 | https://api.github.com/repos/simonw/datasette/issues/1871 | 1312816292 | IC_kwDOBm6k_c5OP_yk | 9599 | 2022-11-13T20:38:42Z | 2022-11-13T20:38:42Z | OWNER | The current API explorer uses details/summary elements for the GET and POST dialogs. I only want one of these to be open at a time, to reflect that you can make either a GET or a POST. I just noticed that clicking anywhere else on the page closes both elements, which isn't what I want to happen. Turns out that's because of this code I added as part of Datasette's menu implementation! https://github.com/simonw/datasette/blob/9f54f00a50a4d950cfd69a0ff3526ae82c858826/datasette/templates/_close_open_menus.html#L2-L15 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1427293909 |