github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1605#issuecomment-1331187551 | https://api.github.com/repos/simonw/datasette/issues/1605 | 1331187551 | IC_kwDOBm6k_c5PWE9f | 25778 | 2022-11-29T19:29:42Z | 2022-11-29T19:29:42Z | CONTRIBUTOR | Interesting. I started a version using metadata like I outlined up top, but I realized that there's no documented way for a plugin to access either metadata or canned queries. Or at least, I couldn't find a way. There is this method: https://github.com/simonw/datasette/blob/main/datasette/app.py#L472 but I don't want to rely on it if it's not documented. Same with this: https://github.com/simonw/datasette/blob/main/datasette/app.py#L544 If those are safe, I'll build on them. I'm also happy to document them, if that greases the wheels. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1108671952 | |
https://github.com/simonw/datasette/issues/1850#issuecomment-1331238841 | https://api.github.com/repos/simonw/datasette/issues/1850 | 1331238841 | IC_kwDOBm6k_c5PWRe5 | 9599 | 2022-11-29T20:11:20Z | 2022-11-29T20:11:20Z | OWNER | Released this in Datasette 1.0a0: - #1913 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1421529723 | |
https://github.com/simonw/datasette/issues/1863#issuecomment-1330974099 | https://api.github.com/repos/simonw/datasette/issues/1863 | 1330974099 | IC_kwDOBm6k_c5PVQ2T | 9599 | 2022-11-29T17:03:00Z | 2022-11-29T17:11:05Z | OWNER | I've decided that I won't do that validation for the first version of this - I'm going to teach `dclient` to send the correct types instead: https://github.com/simonw/dclient/issues/6#issuecomment-1330963953 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1425029242 | |
https://github.com/simonw/datasette/issues/1863#issuecomment-1331089156 | https://api.github.com/repos/simonw/datasette/issues/1863 | 1331089156 | IC_kwDOBm6k_c5PVs8E | 9599 | 2022-11-29T18:08:53Z | 2022-11-29T18:08:53Z | OWNER | I do think this needs type checking - I just tried and you really can send a string to an integer column and have it work, which feels bad. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1425029242 | |
https://github.com/simonw/datasette/issues/1877#issuecomment-1331201207 | https://api.github.com/repos/simonw/datasette/issues/1877 | 1331201207 | IC_kwDOBm6k_c5PWIS3 | 9599 | 2022-11-29T19:44:07Z | 2022-11-29T19:44:07Z | OWNER | I fixed the duplicate logic issue here: https://github.com/simonw/datasette/commit/ee64130fa8a5ff4a24791916c696e10cf2375102 - #1896 Decided not to address `views/table.py`. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1432012302 | |
https://github.com/simonw/datasette/issues/1891#issuecomment-1331140747 | https://api.github.com/repos/simonw/datasette/issues/1891 | 1331140747 | IC_kwDOBm6k_c5PV5iL | 9599 | 2022-11-29T18:55:42Z | 2022-11-29T18:55:42Z | OWNER | All features for the alpha are complete now. Release notes should be based on these commits: https://github.com/simonw/datasette/compare/0.63.2...6bda2257868a2cbd70b84b7a86a5bcb47dcc4874 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1450303205 | |
https://github.com/simonw/datasette/issues/1891#issuecomment-1331143292 | https://api.github.com/repos/simonw/datasette/issues/1891 | 1331143292 | IC_kwDOBm6k_c5PV6J8 | 9599 | 2022-11-29T18:57:40Z | 2022-11-29T18:57:40Z | OWNER | I'm going to keep these short - they'll mostly be links to the documentation for the new features. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1450303205 | |
https://github.com/simonw/datasette/issues/1891#issuecomment-1331181922 | https://api.github.com/repos/simonw/datasette/issues/1891 | 1331181922 | IC_kwDOBm6k_c5PWDli | 9599 | 2022-11-29T19:23:41Z | 2022-11-29T19:23:41Z | OWNER | https://github.com/simonw/datasette/blob/4d49a5a39739476e1ada43f70a0029abcef07977/docs/changelog.rst#10a0-2022-11-29 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1450303205 | |
https://github.com/simonw/datasette/issues/1911#issuecomment-1331120055 | https://api.github.com/repos/simonw/datasette/issues/1911 | 1331120055 | IC_kwDOBm6k_c5PV0e3 | 9599 | 2022-11-29T18:36:01Z | 2022-11-29T18:36:01Z | OWNER | Current API design: ``` POST /<database>/-/create ``` ```json { "table": "name_of_new_table", "columns": [ { "name": "id", "type": "integer" }, { "name": "title", "type": "text" } ], "pk": "id" } ``` I'm going to add a new `"pks"` key which is a list, and can be used in place of `"pk"`. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1468519699 | |
https://github.com/simonw/datasette/issues/1911#issuecomment-1331135709 | https://api.github.com/repos/simonw/datasette/issues/1911 | 1331135709 | IC_kwDOBm6k_c5PV4Td | 9599 | 2022-11-29T18:50:58Z | 2022-11-29T18:50:58Z | OWNER | Updated docs: https://docs.datasette.io/en/1.0-dev/json_api.html#creating-a-table | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1468519699 | |
https://github.com/simonw/datasette/pull/1912#issuecomment-1331196531 | https://api.github.com/repos/simonw/datasette/issues/1912 | 1331196531 | IC_kwDOBm6k_c5PWHJz | 9599 | 2022-11-29T19:39:10Z | 2022-11-29T19:39:10Z | OWNER | Annoyingly it looks like I can't rebase this one, and I don't want to squash-merge and lose the commits, so I'm going to do a regular merge instead. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1468592292 | |
https://github.com/simonw/datasette/issues/1913#issuecomment-1331203997 | https://api.github.com/repos/simonw/datasette/issues/1913 | 1331203997 | IC_kwDOBm6k_c5PWI-d | 9599 | 2022-11-29T19:47:13Z | 2022-11-29T19:47:13Z | OWNER | Weird, retrying the tests DID get them to pass. https://github.com/simonw/datasette/actions/runs/3577355358/jobs/6016518244 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1468603401 | |
https://github.com/simonw/datasette/issues/1913#issuecomment-1331204360 | https://api.github.com/repos/simonw/datasette/issues/1913 | 1331204360 | IC_kwDOBm6k_c5PWJEI | 9599 | 2022-11-29T19:47:40Z | 2022-11-29T19:47:40Z | OWNER | ... but the last step of the deploy failed, when it was meant to push to PyPI! ``` Uploading distributions to https://upload.pypi.org/legacy/ Traceback (most recent call last): File "/opt/hostedtoolcache/Python/3.11.0/x64/bin/twine", line 8, in <module> sys.exit(main()) ^^^^^^ File "/opt/hostedtoolcache/Python/3.11.0/x64/lib/python3.11/site-packages/twine/__main__.py", line 33, in main error = cli.dispatch(sys.argv[1:]) ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/hostedtoolcache/Python/3.11.0/x64/lib/python3.11/site-packages/twine/cli.py", line 123, in dispatch return main(args.args) ^^^^^^^^^^^^^^^ File "/opt/hostedtoolcache/Python/3.11.0/x64/lib/python3.11/site-packages/twine/commands/upload.py", line 198, in main return upload(upload_settings, parsed_args.dists) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/hostedtoolcache/Python/3.11.0/x64/lib/python3.11/site-packages/twine/commands/upload.py", line 123, in upload packages_to_upload = [ ^ File "/opt/hostedtoolcache/Python/3.11.0/x64/lib/python3.11/site-packages/twine/commands/upload.py", line 124, in <listcomp> _make_package(filename, signatures, upload_settings) for filename in uploads ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/hostedtoolcache/Python/3.11.0/x64/lib/python3.11/site-packages/twine/commands/upload.py", line 77, in _make_package package = package_file.PackageFile.from_filename(filename, upload_settings.comment) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/hostedtoolcache/Python/3.11.0/x64/lib/python3.11/site-packages/twine/package.py", line 96, in from_filename meta = DIST_TYPES[dtype](filename) ^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/hostedtoolcache/Python/3.11.0/x64/lib/python3.11/site-packages/twine/wheel.py", line 42, in __init__ self.extractMetadata() File "/opt/hostedtoolcache/Python/3.11.0/x64/… | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1468603401 | |
https://github.com/simonw/datasette/issues/1913#issuecomment-1331205613 | https://api.github.com/repos/simonw/datasette/issues/1913 | 1331205613 | IC_kwDOBm6k_c5PWJXt | 9599 | 2022-11-29T19:48:52Z | 2022-11-29T19:48:52Z | OWNER | https://github.com/simonw/datasette/blob/07aad511769da9242260c850e8d975cbd8c29552/.github/workflows/publish.yml#L52-L61 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1468603401 | |
https://github.com/simonw/datasette/issues/1913#issuecomment-1331207334 | https://api.github.com/repos/simonw/datasette/issues/1913 | 1331207334 | IC_kwDOBm6k_c5PWJym | 9599 | 2022-11-29T19:50:37Z | 2022-11-29T19:50:37Z | OWNER | https://pypi.org/project/setuptools/65.6.3/ came out most recently - 23rd November (wheel and twine are older). No search results at all for that error message. This is very weird, I would have expected it to have been reported by now. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1468603401 | |
https://github.com/simonw/datasette/issues/1913#issuecomment-1331208206 | https://api.github.com/repos/simonw/datasette/issues/1913 | 1331208206 | IC_kwDOBm6k_c5PWKAO | 9599 | 2022-11-29T19:51:31Z | 2022-11-29T19:51:31Z | OWNER | https://pypi.org/project/pkginfo/#history - 1.9.0 came out 39 minutes ago! | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1468603401 | |
https://github.com/simonw/datasette/issues/1913#issuecomment-1331216652 | https://api.github.com/repos/simonw/datasette/issues/1913 | 1331216652 | IC_kwDOBm6k_c5PWMEM | 9599 | 2022-11-29T19:54:22Z | 2022-11-29T19:54:22Z | OWNER | Filed a bug report here: https://bugs.launchpad.net/pkginfo/+bug/1998249 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1468603401 | |
https://github.com/simonw/datasette/issues/1913#issuecomment-1331225277 | https://api.github.com/repos/simonw/datasette/issues/1913 | 1331225277 | IC_kwDOBm6k_c5PWOK9 | 9599 | 2022-11-29T19:59:14Z | 2022-11-29T19:59:34Z | OWNER | I deleted the tag and tried creating a new release. Now running here: https://github.com/simonw/datasette/actions/runs/3577554546 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1468603401 | |
https://github.com/simonw/datasette/issues/1913#issuecomment-1331226346 | https://api.github.com/repos/simonw/datasette/issues/1913 | 1331226346 | IC_kwDOBm6k_c5PWObq | 9599 | 2022-11-29T20:00:16Z | 2022-11-29T20:00:36Z | OWNER | Looks like a fix is coming: https://github.com/pypa/twine/issues/940#issuecomment-1331225509 > > Note that `must_decode` was defined in `pkg_info/_compat.py`, and was thus never an API: before 1.9.0, it was only imported and used in `pkginfo/distribution.py'. > > Nevertheless, I will push out a 1.9.1 release of `pkginfo` which restores a deprecated compatibility alias. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1468603401 | |
https://github.com/simonw/datasette/issues/1913#issuecomment-1331238029 | https://api.github.com/repos/simonw/datasette/issues/1913 | 1331238029 | IC_kwDOBm6k_c5PWRSN | 9599 | 2022-11-29T20:10:35Z | 2022-11-29T20:10:35Z | OWNER | Released: - https://pypi.org/project/datasette/1.0a0/ - https://docs.datasette.io/en/latest/changelog.html#a0-2022-11-29 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1468603401 | |
https://github.com/simonw/datasette/issues/1915#issuecomment-1331331082 | https://api.github.com/repos/simonw/datasette/issues/1915 | 1331331082 | IC_kwDOBm6k_c5PWoAK | 9599 | 2022-11-29T21:24:59Z | 2022-11-29T21:34:53Z | OWNER | Maybe a plugin called `datasette-temporary-tables` or `datasette-demo-tables` or `datasette-demo-database`. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1468709531 | |
https://github.com/simonw/datasette/issues/1915#issuecomment-1331432223 | https://api.github.com/repos/simonw/datasette/issues/1915 | 1331432223 | IC_kwDOBm6k_c5PXAsf | 9599 | 2022-11-29T23:06:17Z | 2022-11-29T23:06:17Z | OWNER | To (slightly) discourage abuse I'm going to make the demo database only visible to the root user - so people can't create tables with rude names and have them show to the public on https://latest.datasette.io/ | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1468709531 |