github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/pull/1931#issuecomment-1339968514 | https://api.github.com/repos/simonw/datasette/issues/1931 | 1339968514 | IC_kwDOBm6k_c5P3kwC | 9599 | 2022-12-06T20:28:47Z | 2022-12-06T20:28:47Z | OWNER | Should the `"return": true` mode reflect the order in which the rows were provided when the API was called? I think it should. Since this is small enough to happily fit in Python memory (thanks to the `max_insert_rows` setting) I can load the fresh data from the database and then sort it in Python space before returning it. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1473814539 | |
https://github.com/simonw/datasette/issues/1855#issuecomment-1339952692 | https://api.github.com/repos/simonw/datasette/issues/1855 | 1339952692 | IC_kwDOBm6k_c5P3g40 | 9599 | 2022-12-06T20:15:50Z | 2022-12-06T20:16:00Z | OWNER | That commit there https://github.com/simonw/datasette/commit/6da17d5529773dfe41b53ed4ce5a6ecb46ed2457 (which will be squash-merged in a PR later on) made it so that `_r` was correctly copied across from the token to the created actor, and fixed a bug in the code that checks permissions against it for resources. I needed that mechanism to write a test that exercised different API permissions. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1423336089 | |
https://github.com/simonw/datasette/pull/1931#issuecomment-1339916064 | https://api.github.com/repos/simonw/datasette/issues/1931 | 1339916064 | IC_kwDOBm6k_c5P3X8g | 3556 | 2022-12-06T19:42:45Z | 2022-12-06T19:42:45Z | CONTRIBUTOR | The `"return": true` option is really nice! | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1473814539 | |
https://github.com/simonw/datasette/pull/1931#issuecomment-1339911152 | https://api.github.com/repos/simonw/datasette/issues/1931 | 1339911152 | IC_kwDOBm6k_c5P3Wvw | 9599 | 2022-12-06T19:38:12Z | 2022-12-06T19:38:12Z | OWNER | Documentation: https://datasette--1931.org.readthedocs.build/en/1931/json_api.html#upserting-rows | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1473814539 | |
https://github.com/simonw/datasette/issues/1927#issuecomment-1339910494 | https://api.github.com/repos/simonw/datasette/issues/1927 | 1339910494 | IC_kwDOBm6k_c5P3Wle | 9599 | 2022-12-06T19:37:39Z | 2022-12-06T19:37:39Z | OWNER | I'll finish this after I land: - #1931 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1473411197 | |
https://github.com/simonw/datasette/issues/1929#issuecomment-1339909159 | https://api.github.com/repos/simonw/datasette/issues/1929 | 1339909159 | IC_kwDOBm6k_c5P3WQn | 9599 | 2022-12-06T19:36:23Z | 2022-12-06T19:36:23Z | OWNER | https://docs.datasette.io/en/1.0a1/json_api.html 👍 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1473659191 | |
https://github.com/simonw/datasette/issues/1929#issuecomment-1339906969 | https://api.github.com/repos/simonw/datasette/issues/1929 | 1339906969 | IC_kwDOBm6k_c5P3VuZ | 3556 | 2022-12-06T19:34:20Z | 2022-12-06T19:34:20Z | CONTRIBUTOR | I confirm that it works 👍 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1473659191 | |
https://github.com/simonw/datasette/issues/1929#issuecomment-1339871933 | https://api.github.com/repos/simonw/datasette/issues/1929 | 1339871933 | IC_kwDOBm6k_c5P3NK9 | 9599 | 2022-12-06T19:23:48Z | 2022-12-06T19:24:17Z | OWNER | I can do that on this page: https://readthedocs.org/projects/datasette/versions/?version_filter=1.0 <img width="861" alt="image" src="https://user-images.githubusercontent.com/9599/206003351-1a480f9c-ffc3-413a-a7c8-ad138c25a2f6.png"> I'm making them both active and hidden: <img width="843" alt="CleanShot 2022-12-06 at 11 23 56@2x" src="https://user-images.githubusercontent.com/9599/206003466-3825bf2f-d58d-4eff-8848-8a28e1d5e19f.png"> | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1473659191 | |
https://github.com/simonw/datasette/issues/1929#issuecomment-1339867570 | https://api.github.com/repos/simonw/datasette/issues/1929 | 1339867570 | IC_kwDOBm6k_c5P3MGy | 9599 | 2022-12-06T19:22:47Z | 2022-12-06T19:22:47Z | OWNER | Yeah I should deploy the docs for the alpha versions (the intention is that the docs exactly match the release you are using), thanks for spotting that. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1473659191 | |
https://github.com/simonw/sqlite-utils/issues/516#issuecomment-1339844639 | https://api.github.com/repos/simonw/sqlite-utils/issues/516 | 1339844639 | IC_kwDOCGYnMM5P3Ggf | 122043 | 2022-12-06T19:08:13Z | 2022-12-06T19:08:13Z | NONE | Reference: tqdm (https://tqdm.github.io/) shows a progress bar when total is known, and falls back to counting units of work done for streams. File input vs. stdin seems like a similar situation. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1479914599 | |
https://github.com/simonw/sqlite-utils/issues/516#issuecomment-1339839767 | https://api.github.com/repos/simonw/sqlite-utils/issues/516 | 1339839767 | IC_kwDOCGYnMM5P3FUX | 122043 | 2022-12-06T19:04:17Z | 2022-12-06T19:04:17Z | NONE | Current behavior is different when importing via stdin vs. a file. Imports from a file give a progress bar. For this new request, I'd love to see total imported and total ignored/replaced in both cases. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1479914599 | |
https://github.com/simonw/sqlite-utils/issues/516#issuecomment-1339837520 | https://api.github.com/repos/simonw/sqlite-utils/issues/516 | 1339837520 | IC_kwDOCGYnMM5P3ExQ | 122043 | 2022-12-06T19:02:30Z | 2022-12-06T19:02:30Z | NONE | `--verbose` or `--verbosity=ABC` were the flags I looked for. Expected to see them at a global level near `--version`. But only sharing because that's where I looked first, I don't have a strong opinion on the exact wording/location. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1479914599 | |
https://github.com/simonw/sqlite-utils/issues/516#issuecomment-1339834918 | https://api.github.com/repos/simonw/sqlite-utils/issues/516 | 1339834918 | IC_kwDOCGYnMM5P3EIm | 9599 | 2022-12-06T19:00:18Z | 2022-12-06T19:00:35Z | OWNER | Right now the command produces no output at all. Maybe a `--verbose` mode that writes these numbers to standard error (or even standard output since it's an option)? Is there a better name than `--verbose` for this? `--summary` perhaps? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1479914599 | |
https://github.com/simonw/datasette/pull/1931#issuecomment-1339784569 | https://api.github.com/repos/simonw/datasette/issues/1931 | 1339784569 | IC_kwDOBm6k_c5P2315 | 9599 | 2022-12-06T18:16:15Z | 2022-12-06T18:17:56Z | OWNER | Just noticed the insert API returns `{}` when it should return `{"ok": true}` - will fix that here too. UPDATE: no it did that already, it was just the documentation that was wrong. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1473814539 | |
https://github.com/simonw/datasette/pull/1931#issuecomment-1339768422 | https://api.github.com/repos/simonw/datasette/issues/1931 | 1339768422 | IC_kwDOBm6k_c5P2z5m | 9599 | 2022-12-06T18:04:59Z | 2022-12-06T18:04:59Z | OWNER | I realized this API should require both the `insert-row` AND the `update-row` permissions, since calls to it could do either one. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1473814539 |