github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/2150#issuecomment-1690438270 | https://api.github.com/repos/simonw/datasette/issues/2150 | 1690438270 | IC_kwDOBm6k_c5kwgp- | 9599 | 2023-08-23T18:27:47Z | 2023-08-23T18:27:47Z | OWNER | I added `outline: 3px dotted pink` to that `form label` block to help spot where else it's being used. Oh interesting, looks like it's over-ridden here too: <img width="950" alt="CleanShot 2023-08-23 at 11 27 15@2x" src="https://github.com/simonw/datasette/assets/9599/f3f3e995-2d6c-4afe-8370-01e0b5141a64"> | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1863810783 | |
https://github.com/simonw/datasette/issues/2150#issuecomment-1690435866 | https://api.github.com/repos/simonw/datasette/issues/2150 | 1690435866 | IC_kwDOBm6k_c5kwgEa | 9599 | 2023-08-23T18:25:51Z | 2023-08-23T18:25:51Z | OWNER | Looks like that affects a few forms: <img width="701" alt="CleanShot 2023-08-23 at 11 24 46@2x" src="https://github.com/simonw/datasette/assets/9599/7145aec1-832e-4eea-84a6-a735df4dfd6e"> The search form on the table page over-rides it already: <img width="1243" alt="CleanShot 2023-08-23 at 11 25 26@2x" src="https://github.com/simonw/datasette/assets/9599/e002089e-e992-4cc5-bb6b-c54cf614ec95"> | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1863810783 | |
https://github.com/simonw/datasette/issues/2150#issuecomment-1690432928 | https://api.github.com/repos/simonw/datasette/issues/2150 | 1690432928 | IC_kwDOBm6k_c5kwfWg | 9599 | 2023-08-23T18:23:26Z | 2023-08-23T18:23:26Z | OWNER | That should be scoped just to the query filters form on the table page. I'll fix it in `main` but I'm still going to ship a fix for those plugins separately so they work well before people upgrade to the next Datasette release with this change in it. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1863810783 | |
https://github.com/simonw/datasette/issues/2150#issuecomment-1690431509 | https://api.github.com/repos/simonw/datasette/issues/2150 | 1690431509 | IC_kwDOBm6k_c5kwfAV | 9599 | 2023-08-23T18:22:47Z | 2023-08-23T18:22:47Z | OWNER | https://github.com/simonw/datasette/blob/64fd1d788eeed2624f107ac699f2370590ae1aa3/datasette/static/app.css#L485-L489 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1863810783 |