github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/227#issuecomment-382808266 | https://api.github.com/repos/simonw/datasette/issues/227 | 382808266 | MDEyOklzc3VlQ29tbWVudDM4MjgwODI2Ng== | 9599 | 2018-04-19T16:59:23Z | 2018-04-19T16:59:23Z | OWNER | Maybe this should have a second argument indicating which codepath was being handled. That way plugins could say "only inject this extra context variable on the row page". | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
315960272 | |
https://github.com/simonw/datasette/issues/227#issuecomment-382958693 | https://api.github.com/repos/simonw/datasette/issues/227 | 382958693 | MDEyOklzc3VlQ29tbWVudDM4Mjk1ODY5Mw== | 9599 | 2018-04-20T03:15:52Z | 2018-04-20T03:15:52Z | OWNER | A better way to do this would be with many different plugin hooks, one for each view. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
315960272 | |
https://github.com/simonw/datasette/issues/227#issuecomment-382959857 | https://api.github.com/repos/simonw/datasette/issues/227 | 382959857 | MDEyOklzc3VlQ29tbWVudDM4Mjk1OTg1Nw== | 9599 | 2018-04-20T03:21:43Z | 2018-04-20T03:21:43Z | OWNER | Plus a generic prepare_context() hook called in the common render method. prepare_context_table(), prepare_context_row() etc Arguments are context, request, self (hence can access self.ds) | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
315960272 | |
https://github.com/simonw/datasette/issues/227#issuecomment-382964794 | https://api.github.com/repos/simonw/datasette/issues/227 | 382964794 | MDEyOklzc3VlQ29tbWVudDM4Mjk2NDc5NA== | 9599 | 2018-04-20T03:45:18Z | 2018-04-20T03:45:18Z | OWNER | What if the context needs to make await calls? One possible option: plugins can either manipulate the context in place OR they can return an awaitable. If they do that, the caller will await it. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
315960272 | |
https://github.com/simonw/datasette/issues/227#issuecomment-382966604 | https://api.github.com/repos/simonw/datasette/issues/227 | 382966604 | MDEyOklzc3VlQ29tbWVudDM4Mjk2NjYwNA== | 9599 | 2018-04-20T03:54:56Z | 2018-04-20T03:54:56Z | OWNER | Should this differentiate between preparing the data to be sent back as JSON and preparing the context for the template? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
315960272 | |
https://github.com/simonw/datasette/issues/227#issuecomment-382967238 | https://api.github.com/repos/simonw/datasette/issues/227 | 382967238 | MDEyOklzc3VlQ29tbWVudDM4Mjk2NzIzOA== | 9599 | 2018-04-20T03:58:09Z | 2018-04-20T03:58:09Z | OWNER | Maybe prepare_table_data() vs prepare_table_context() | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
315960272 | |
https://github.com/simonw/datasette/issues/227#issuecomment-603534725 | https://api.github.com/repos/simonw/datasette/issues/227 | 603534725 | MDEyOklzc3VlQ29tbWVudDYwMzUzNDcyNQ== | 9599 | 2020-03-24T22:19:54Z | 2020-03-24T22:19:54Z | OWNER | I think the [extra_template_vars()](https://datasette.readthedocs.io/en/stable/plugins.html#extra-template-vars-template-database-table-view-name-request-datasette) hook covers this. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
315960272 |