github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/233#issuecomment-397842194 | https://api.github.com/repos/simonw/datasette/issues/233 | 397842194 | MDEyOklzc3VlQ29tbWVudDM5Nzg0MjE5NA== | 9599 | 2018-06-16T22:26:21Z | 2018-06-16T22:26:21Z | OWNER | Some demos: * https://datasette-labels-demo.now.sh/sf-trees-02c8ef1/Street_Tree_List - regular HTML view * https://datasette-labels-demo.now.sh/sf-trees-02c8ef1/Street_Tree_List?_labels=off - no labels * https://datasette-labels-demo.now.sh/sf-trees-02c8ef1/Street_Tree_List.json?_labels=on - JSON with all labels * https://datasette-labels-demo.now.sh/sf-trees-02c8ef1/Street_Tree_List.json?_label=qSpecies&_shape=array - JSON with specific labels in array shape * https://datasette-labels-demo.now.sh/sf-trees-02c8ef1/Street_Tree_List.csv?_labels=on - CSV with all labels * https://datasette-labels-demo.now.sh/sf-trees-02c8ef1/Street_Tree_List.csv?_label=qSpecies - CSV with specific labels | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
316444720 | |
https://github.com/simonw/datasette/issues/233#issuecomment-397840676 | https://api.github.com/repos/simonw/datasette/issues/233 | 397840676 | MDEyOklzc3VlQ29tbWVudDM5Nzg0MDY3Ng== | 9599 | 2018-06-16T21:49:50Z | 2018-06-16T21:49:50Z | OWNER | For the moment I'm going with `_labels=`. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
316444720 | |
https://github.com/simonw/datasette/issues/233#issuecomment-397839583 | https://api.github.com/repos/simonw/datasette/issues/233 | 397839583 | MDEyOklzc3VlQ29tbWVudDM5NzgzOTU4Mw== | 9599 | 2018-06-16T21:23:14Z | 2018-06-16T21:23:44Z | OWNER | I'm a bit torn on naming - choices are: * `?_labels=on` and `?_label=col1&_label=col2` * `?_expands=on` (or `?_expand_all=on`) and `?_expand=col1&_expand=col2` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
316444720 | |
https://github.com/simonw/datasette/issues/233#issuecomment-397839482 | https://api.github.com/repos/simonw/datasette/issues/233 | 397839482 | MDEyOklzc3VlQ29tbWVudDM5NzgzOTQ4Mg== | 9599 | 2018-06-16T21:21:03Z | 2018-06-16T21:21:03Z | OWNER | Should facets always have their labels expanded or should they also obey the `_labels` and `_label` querystring arguments? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
316444720 | |
https://github.com/simonw/datasette/issues/233#issuecomment-397824991 | https://api.github.com/repos/simonw/datasette/issues/233 | 397824991 | MDEyOklzc3VlQ29tbWVudDM5NzgyNDk5MQ== | 9599 | 2018-06-16T16:50:31Z | 2018-06-16T16:50:42Z | OWNER | I'm going to support `?_labels=` on HTML views, but I'll allow it to be used to turn them off (they are on by default) using `?_labels=off`. Related: 7e0caa1e62607c6579101cc0e62bec8899013715 where I added a new `value_as_boolean` helper extracted from how `--config` works in `cli.py`. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
316444720 | |
https://github.com/simonw/datasette/issues/233#issuecomment-397729500 | https://api.github.com/repos/simonw/datasette/issues/233 | 397729500 | MDEyOklzc3VlQ29tbWVudDM5NzcyOTUwMA== | 9599 | 2018-06-15T20:11:14Z | 2018-06-15T20:11:14Z | OWNER | The `.json` and `.csv` links displayed on the table page should default to using `?_labels=1` if Datasette detects that there are foreign key expansions available for the page. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
316444720 | |
https://github.com/simonw/datasette/issues/233#issuecomment-397729319 | https://api.github.com/repos/simonw/datasette/issues/233 | 397729319 | MDEyOklzc3VlQ29tbWVudDM5NzcyOTMxOQ== | 9599 | 2018-06-15T20:10:24Z | 2018-06-15T20:10:24Z | OWNER | I'm also going to add the ability to specify individual columns that you want to expand using `?_label=city_id&_label=state_id` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
316444720 | |
https://github.com/simonw/datasette/issues/233#issuecomment-397668427 | https://api.github.com/repos/simonw/datasette/issues/233 | 397668427 | MDEyOklzc3VlQ29tbWVudDM5NzY2ODQyNw== | 9599 | 2018-06-15T16:07:43Z | 2018-06-15T16:07:43Z | OWNER | Demo: https://datasette-json-labels-demo.now.sh/fixtures-fda0fea/facetable.json?_labels=1&_shape=array | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
316444720 | |
https://github.com/simonw/datasette/issues/233#issuecomment-397663968 | https://api.github.com/repos/simonw/datasette/issues/233 | 397663968 | MDEyOklzc3VlQ29tbWVudDM5NzY2Mzk2OA== | 9599 | 2018-06-15T15:51:17Z | 2018-06-15T15:51:17Z | OWNER | Nearly done, but I need the HTML view to ignore the `?_labels=1` param (it throws an error at the moment). | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
316444720 | |
https://github.com/simonw/datasette/issues/233#issuecomment-397648080 | https://api.github.com/repos/simonw/datasette/issues/233 | 397648080 | MDEyOklzc3VlQ29tbWVudDM5NzY0ODA4MA== | 9599 | 2018-06-15T14:56:21Z | 2018-06-15T14:56:21Z | OWNER | I considered including a `"table"` key like this: ``` "qLegalStatus": { "value" 2, "label": "Private", "table": "qLegalStatus" } ``` This would help generate the HTML links using just the JSON data. But... I realized that in a list of 50 rows that value would be duplicated 50 times which is a bit nasty. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
316444720 | |
https://github.com/simonw/datasette/issues/233#issuecomment-397637302 | https://api.github.com/repos/simonw/datasette/issues/233 | 397637302 | MDEyOklzc3VlQ29tbWVudDM5NzYzNzMwMg== | 9599 | 2018-06-15T14:24:08Z | 2018-06-15T14:55:19Z | OWNER | I'm going with the terminology "labels" here. You'll be able to add ``?_labels=1`` and the JSON will look something like this: ``` { "rowid": 233, "TreeID": 121240, "qLegalStatus": { "value" 2, "label": "Private" } "qSpecies": { "value": 16, "label": "Sycamore" } "qAddress": "91 Commonwealth Ave", ... } ``` I need this to help build foreign key expansions for CSV files, see #266 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
316444720 |