github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/291#issuecomment-392302456 | https://api.github.com/repos/simonw/datasette/issues/291 | 392302456 | MDEyOklzc3VlQ29tbWVudDM5MjMwMjQ1Ng== | 9599 | 2018-05-27T03:19:24Z | 2018-05-27T03:19:24Z | OWNER | The big gap in this solution is conflicting versions: I don't yet have a story for what happens if two plugins attempt to load different versions of Leaflet. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
326783670 | |
https://github.com/simonw/datasette/issues/291#issuecomment-392302416 | https://api.github.com/repos/simonw/datasette/issues/291 | 392302416 | MDEyOklzc3VlQ29tbWVudDM5MjMwMjQxNg== | 9599 | 2018-05-27T03:18:16Z | 2018-05-27T03:18:16Z | OWNER | For the moment then I'm going with a really simple solution: when iterating through `extra_css_urls` and `extra_js_urls` de-dupe by URL and avoid outputting the same link twice. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
326783670 | |
https://github.com/simonw/datasette/issues/291#issuecomment-392302406 | https://api.github.com/repos/simonw/datasette/issues/291 | 392302406 | MDEyOklzc3VlQ29tbWVudDM5MjMwMjQwNg== | 9599 | 2018-05-27T03:18:06Z | 2018-05-27T03:18:06Z | OWNER | My first attempt at this was to have plugins depend on each other - so there would be a `datasette-leaflet` plugin which adds Leaflet to the page, and the `datasette-cluster-map` and `datasette-leaflet-geojson` plugins would depend on that plugin. I tried this and it didn't work, because it turns out the order in which plugins are loaded isn't predictable. `datasette-cluster-map` ended up adding it's script link before Leaflet had been loaded by `datasette-leaflet`, resulting in JavaScript errors. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
326783670 |