github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/393#issuecomment-451415063 | https://api.github.com/repos/simonw/datasette/issues/393 | 451415063 | MDEyOklzc3VlQ29tbWVudDQ1MTQxNTA2Mw== | 1727065 | 2019-01-04T11:04:08Z | 2019-01-04T11:04:08Z | NONE | Awesome - will get myself up and running on 0.26 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
395236066 | |
https://github.com/simonw/datasette/issues/393#issuecomment-451047426 | https://api.github.com/repos/simonw/datasette/issues/393 | 451047426 | MDEyOklzc3VlQ29tbWVudDQ1MTA0NzQyNg== | 9599 | 2019-01-03T03:19:04Z | 2019-01-03T03:19:04Z | OWNER | https://fivethirtyeight.datasettes.com/-/versions is now running 0.26 - so your initial bug demo is now fixed: https://fivethirtyeight.datasettes.com/fivethirtyeight-c300360/classic-rock%2Fclassic-rock-song-list?Release+Year__exact=1989#export | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
395236066 | |
https://github.com/simonw/datasette/issues/393#issuecomment-451046123 | https://api.github.com/repos/simonw/datasette/issues/393 | 451046123 | MDEyOklzc3VlQ29tbWVudDQ1MTA0NjEyMw== | 9599 | 2019-01-03T03:05:07Z | 2019-01-03T03:05:07Z | OWNER | The fix was released as part of Datasette 0.26 - you can see the fix working here: https://v0-26.datasette.io/fixtures-dd88475/facetable?_facet=planet_int&planet_int=1#export | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
395236066 | |
https://github.com/simonw/datasette/issues/393#issuecomment-450944166 | https://api.github.com/repos/simonw/datasette/issues/393 | 450944166 | MDEyOklzc3VlQ29tbWVudDQ1MDk0NDE2Ng== | 9599 | 2019-01-02T18:32:12Z | 2019-01-02T18:32:12Z | OWNER | Here's the test that needs updating: https://github.com/simonw/datasette/blob/8b8ae55e7c8b9e1dceef53f55a330b596ca44d41/tests/test_html.py#L427-L435 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
395236066 | |
https://github.com/simonw/datasette/issues/393#issuecomment-450943632 | https://api.github.com/repos/simonw/datasette/issues/393 | 450943632 | MDEyOklzc3VlQ29tbWVudDQ1MDk0MzYzMg== | 9599 | 2019-01-02T18:30:20Z | 2019-01-02T18:30:20Z | OWNER | This is the code which is meant to add those options as hidden form fields: https://github.com/simonw/datasette/blob/fe5b6ea95a973534fe8a44907c0ea2449aae7602/datasette/templates/table.html#L150-L155 It's clearly not working. Need to fix this and add a corresponding unit test. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
395236066 | |
https://github.com/simonw/datasette/issues/393#issuecomment-450943172 | https://api.github.com/repos/simonw/datasette/issues/393 | 450943172 | MDEyOklzc3VlQ29tbWVudDQ1MDk0MzE3Mg== | 9599 | 2019-01-02T18:28:43Z | 2019-01-02T18:28:43Z | OWNER | Definitely a bug, thanks. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
395236066 |