github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/sqlite-utils/issues/46#issuecomment-592999503 | https://api.github.com/repos/simonw/sqlite-utils/issues/46 | 592999503 | MDEyOklzc3VlQ29tbWVudDU5Mjk5OTUwMw== | 35075 | 2020-02-29T22:08:20Z | 2020-02-29T22:08:20Z | NONE | @simonw any thoughts on allow extracts to specify the lookup column name? If I'm understanding the documentation right, `.lookup()` allows you to define the "value" column (the documentation uses name), but when you use `extracts` keyword as part of `.insert()`, `.upsert()` etc. the lookup must be done against a column named "value". I have an existing lookup table that I've populated with columns "id" and "name" as opposed to "id" and "value", and seems I can't use `extracts=`, unless I'm missing something... Initial thought on how to do this would be to allow the dictionary value to be a tuple of table name column pair... so: ``` table = db.table("trees", extracts={"species_id": ("Species", "name"}) ``` I haven't dug too much into the existing code yet, but does this make sense? Worth doing? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
471780443 | |
https://github.com/simonw/sqlite-utils/issues/46#issuecomment-593118471 | https://api.github.com/repos/simonw/sqlite-utils/issues/46 | 593118471 | MDEyOklzc3VlQ29tbWVudDU5MzExODQ3MQ== | 9599 | 2020-03-01T16:53:40Z | 2020-03-01T16:53:40Z | OWNER | That seems sensible to me. Opening a ticket for it. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
471780443 | |
https://github.com/simonw/sqlite-utils/issues/46#issuecomment-514273140 | https://api.github.com/repos/simonw/sqlite-utils/issues/46 | 514273140 | MDEyOklzc3VlQ29tbWVudDUxNDI3MzE0MA== | 9599 | 2019-07-23T15:57:53Z | 2019-07-23T15:57:53Z | OWNER | This will play very well with the new ability to specify these arguments in the class constructor, like so: ```python table = db.table("trees", extracts={"species_id": "Species"}) table.insert_all([{ "id": 1, "species_id": "Oak", }, { "id": 2, "species_id": "Oak", }, { "id": 3, "species_id": "Palm", }]) | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
471780443 |