github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/sqlite-utils/issues/81#issuecomment-581071434 | https://api.github.com/repos/simonw/sqlite-utils/issues/81 | 581071434 | MDEyOklzc3VlQ29tbWVudDU4MTA3MTQzNA== | 9599 | 2020-02-01T21:32:34Z | 2020-02-01T21:32:34Z | OWNER | While I'm at it I think I'll rename it to `suggest_column_types` - it's not really detecting them since the input is just a list of dictionaries. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
558600274 | |
https://github.com/simonw/sqlite-utils/issues/81#issuecomment-581071235 | https://api.github.com/repos/simonw/sqlite-utils/issues/81 | 581071235 | MDEyOklzc3VlQ29tbWVudDU4MTA3MTIzNQ== | 9599 | 2020-02-01T21:30:09Z | 2020-02-01T21:30:09Z | OWNER | Actually I'll put it in the `utils.py` module. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
558600274 | |
https://github.com/simonw/sqlite-utils/issues/81#issuecomment-581071116 | https://api.github.com/repos/simonw/sqlite-utils/issues/81 | 581071116 | MDEyOklzc3VlQ29tbWVudDU4MTA3MTExNg== | 9599 | 2020-02-01T21:28:35Z | 2020-02-01T21:28:53Z | OWNER | Should I keep `table.detect_column_types()` working so as not to break existing code? If it was part of the documented API then I wouldn't break that without bumping to 3.x. Since it's undocumented I'm going to make it as a breaking change instead (and bump the `geojson-to-sqlite` dependency version). | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
558600274 | |
https://github.com/simonw/sqlite-utils/issues/81#issuecomment-581071010 | https://api.github.com/repos/simonw/sqlite-utils/issues/81 | 581071010 | MDEyOklzc3VlQ29tbWVudDU4MTA3MTAxMA== | 9599 | 2020-02-01T21:27:00Z | 2020-02-01T21:27:00Z | OWNER | Here's the current method: https://github.com/simonw/sqlite-utils/blob/f7289174e66ae4d91d57de94bbd9d09fabf7aff4/sqlite_utils/db.py#L823-L845 If I make it a utility function instead of a class method I could ensure it is directly importable like so: ```python from sqlite_utils import detect_column_types ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
558600274 |