github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/724#issuecomment-612156367 | https://api.github.com/repos/simonw/datasette/issues/724 | 612156367 | MDEyOklzc3VlQ29tbWVudDYxMjE1NjM2Nw== | 9599 | 2020-04-10T18:23:39Z | 2020-04-10T18:23:39Z | OWNER | I think I'll use https://github.com/clarketm/mergedeep (MIT license) | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
598013965 | |
https://github.com/simonw/datasette/issues/724#issuecomment-612155297 | https://api.github.com/repos/simonw/datasette/issues/724 | 612155297 | MDEyOklzc3VlQ29tbWVudDYxMjE1NTI5Nw== | 9599 | 2020-04-10T18:20:53Z | 2020-04-10T18:20:53Z | OWNER | Lot's of recipes for deep dictionary merge on https://stackoverflow.com/q/7204805/6083 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
598013965 | |
https://github.com/simonw/datasette/issues/724#issuecomment-612154749 | https://api.github.com/repos/simonw/datasette/issues/724 | 612154749 | MDEyOklzc3VlQ29tbWVudDYxMjE1NDc0OQ== | 9599 | 2020-04-10T18:19:31Z | 2020-04-10T18:19:31Z | OWNER | Actually that code isn't the problem, since `extra_metadata` has not yet been read from `metadata.json` at that point. The bug is here: https://github.com/simonw/datasette/blob/d55fe8cdfc2ce7bc6960bf2507766c1fcd1d31a7/datasette/utils/__init__.py#L362-L368 I need to merge dictionaries in a smarter way. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
598013965 |